Commit Graph

296 Commits

Author SHA1 Message Date
Benjamin Morse a513c0ef58
Add scalaFix (#1393)
* adding scalaFix to the projecting, using two make targets, `scala-lint` and `scala-lint-check`
* adding documentation

Co-authored-by: David Biancolin <david.biancolin@sifive.com>
2023-01-25 10:34:10 -08:00
abejgonzalez cce21793fb Move testing configs to deploy/workloads/ci 2023-01-24 18:19:24 -08:00
Nandor Licker 6bf7c6f3eb
Enable clang-tidy on all C++ sources (#1400)
This PR adds a new make target, `clang-tidy` to run clang-tidy on all C++ sources.
Only a dummy check is enabled, as this patch applies the minimal number of fixes
to compile headers and sources with clang without the header. In a subsequent PR,
more checks will be enabled and the files will be formatted.

`clang-tidy` can be executed using `make -C sim clang-tidy`. It will automatically
apply fixes to known issues.
2023-01-24 18:42:20 +02:00
abejgonzalez e27622dafa Expand timeout 2023-01-23 01:26:55 +00:00
abejgonzalez 49239dc47f Don't use manager dir 2023-01-23 01:26:55 +00:00
abejgonzalez f36555b8a8 Add managerinit 2023-01-23 01:26:54 +00:00
abejgonzalez dad035a9b3 Remove extra cd 2023-01-23 01:26:54 +00:00
abejgonzalez 7a3349901f Move VCS metasims to run on on-premise FPGA machine 2023-01-23 01:26:54 +00:00
abejgonzalez c43df3f3ab Add VCS metasimulation to CI 2023-01-23 01:26:54 +00:00
Abraham Gonzalez 6652b02f56
Merge pull request #1344 from firesim/fix-ci
Fix Vitis CI
2023-01-19 13:51:12 -08:00
abejgonzalez 957e445a10 Fix exception indentation 2023-01-18 14:07:55 -08:00
abejgonzalez 6780d64074 Remove dependency on prior built workloads 2023-01-18 09:40:14 -08:00
abejgonzalez 3af6d553ed Add CI for metasims 2023-01-17 15:00:11 -08:00
abejgonzalez 59c4c6b438 Use S3 bucket for CI images 2022-12-29 13:09:46 -08:00
abejgonzalez 3c8d63bda1 Bump pre-built CI xclbin 2022-12-27 09:56:11 -08:00
abejgonzalez 88f943adf0 Download xclbin instead of hardcoded path 2022-12-26 20:44:03 -08:00
abejgonzalez 14ae433066 Re-name vitis-test to vitis_test 2022-12-26 20:44:03 -08:00
abejgonzalez 007af4f249 Re-enable Vitis CI 2022-12-26 20:44:03 -08:00
Nandor Licker 39dd9fab62
Fixed firesim.bridges CI tests (#1334)
Specified the correct package in the GitHub workflow definition
2022-12-19 19:53:59 +02:00
Tushar 2b043713df slightly incrased timeouts of fpga jobs in CI 2022-12-16 09:44:12 -08:00
Nandor Licker 5434084309
UART Bridge test (#1326)
Added a UART test in a new group of tests, 'bridges'.
This test group includes the bridges from firesim-lib, which rely on more external dependencies.
The previous `midasexamples` test suite is limited to simple tests with no dependencies.
2022-12-13 07:07:36 +02:00
abejgonzalez adaae496f4 Add CI typechecking 2022-12-10 15:20:04 -08:00
abejgonzalez 46880ce824 Fix issue number propagation | Catch only running/stopped CI instances 2022-12-09 17:19:55 -08:00
abejgonzalez 36d8b7e373 Consolidate CI time handling 2022-12-09 09:54:12 -08:00
abejgonzalez 7015094c85 Fix len and dict CI errors 2022-12-08 22:31:52 -08:00
abejgonzalez 66541a5ad5 Fix tag filter | Fix naming 2022-12-08 21:12:18 -08:00
abejgonzalez 27b0c5e0da Terminate based on cluster tag | Fix small issues 2022-12-08 14:47:06 -08:00
abejgonzalez c1e1c9e14a Raise NotImplemented for Azure 2022-12-08 11:14:23 -08:00
abejgonzalez a17111c513 Add typechecking for ci_variables.py 2022-12-08 11:10:08 -08:00
abejgonzalez 657dd27706 Most prints to exception msgs | Remove zombie screens | Remove startup workflow monitor msg 2022-12-06 22:26:49 -08:00
abejgonzalez 32da02b6c4 Misc. CI fixes 2022-12-06 16:40:57 -08:00
Abraham Gonzalez 08f9a3596b
Merge pull request #1320 from firesim/fix-dep-whitespace
CI Cleanup: Fix deprecations + Remove extra whitespace
2022-12-06 13:45:53 -08:00
Abraham Gonzalez 471ab53277
Fix spelling issue
Co-authored-by: Tushar Sondhi <sondhi.tushar@berkeley.edu>
2022-12-06 11:48:00 -08:00
abejgonzalez c51f0d24da Camel-case AWS CI variables 2022-12-06 11:10:52 -08:00
abejgonzalez cde5fa3ef8 Fix deprecations 2022-12-06 11:01:30 -08:00
abejgonzalez db7116ba27 Remove extra whitespace 2022-12-06 10:58:24 -08:00
David Biancolin 1b8a18e86d ci: serialize driver builds behind other scalatests 2022-11-17 16:40:59 +00:00
Tushar Sondhi 5d14f6f62c fixed runners for midas / targetutils tests 2022-11-09 22:32:14 +00:00
David Biancolin 6b50b4725c Fix scaladoc publish 2022-10-30 21:38:08 -07:00
Tushar Sondhi 8b906ef5fe adding azure support to CI and updating CI infra 2022-10-28 21:05:12 +00:00
David Biancolin acae5cd9a5
build setup: make env.sh sourcable in contexts without conda functions (#1285) 2022-10-28 11:58:05 -07:00
David Biancolin 13ea979535 ci: register midas + targetutils scala tests 2022-10-27 17:07:11 +00:00
Abraham Gonzalez 62f5daad31
Merge branch 'main' into update-ci 2022-10-19 11:30:58 -07:00
Sagar Karandikar ed09a6a6a2 Merge remote-tracking branch 'origin/main' into various-qol-fixes 2022-10-17 20:54:37 -07:00
Sagar Karandikar d401f1c54f delete old CI way of fixing buildroot open files issue 2022-10-17 20:53:20 -07:00
Abraham Gonzalez 97ccf8f659
Disable CI check for Local FPGAs 2022-10-17 18:46:07 -07:00
abejgonzalez 66aab42755 Bump CI checkout version 2022-10-16 19:54:49 -07:00
Sagar Karandikar fe8cad47ca confirm ci breakage 2022-10-16 16:08:16 -07:00
abejgonzalez b36d873b05 Bump CI to Ubuntu 20.04 2022-10-15 17:19:14 -07:00
abejgonzalez c18815f8be Update CI/.gitattr files for rename 2022-09-26 13:44:53 -07:00
tushar 0a95ff8302 improved error messages in ci, fixed catching failed inst
(cherry picked from commit b9b7e816ebe465a1537d6ed655a66fc9dd3054da)
2022-09-22 17:15:29 +00:00
Abraham Gonzalez bb5f6e77f9 Update comments 2022-09-20 12:51:45 -07:00
Abraham Gonzalez 195446d601
Update setup-manager-self-hosted.py 2022-09-20 09:19:24 -07:00
Abraham Gonzalez 1002cf1dbb Increase file descriptor limits 2022-09-19 22:54:15 -07:00
Abraham Gonzalez d81a1e3f76
Merge pull request #1217 from firesim/fix-local-execution
Fix self-hosted runner checkout
2022-09-19 13:57:11 -07:00
Abraham Gonzalez 4b5173767f Fix publish-scala-doc 2022-09-19 13:54:28 -07:00
Abraham Gonzalez be1b742bc2 Fix self-hosted runner checkout 2022-09-19 10:44:03 -07:00
Abraham Gonzalez 760b379a79 Fix change-filters output conda-lock var 2022-09-16 10:48:03 -07:00
Abraham Gonzalez aaa8747661
Merge pull request #1206 from firesim/refactor_conda_abe
Refactor Conda + Bump Chipyard (which now uses Conda)
2022-09-15 18:20:13 -07:00
abejgonzalez 82fdf66554 Update comments + docs 2022-09-15 18:13:07 -07:00
abejgonzalez 62f0fb5e9e Add docs | Remove esp-tools | Use CY build-setup | Add conda-lock CI 2022-09-15 11:38:20 -07:00
Sagar Karandikar 6d3569166f
Merge pull request #1193 from firesim/amifix-for-main
Bump to use AMI 1.12.1 (merge from stable which already has this)
2022-09-14 10:36:47 -07:00
Abraham Gonzalez 57d3cdde45 DEBUG info 2022-09-12 21:06:06 +00:00
tushar ac656d12fe added debug flags to CI, changed machinelaunch term. behavior 2022-09-12 20:36:37 +00:00
Abraham Gonzalez 2f88d24206 Use conda sbt | Source CY env.sh when lib 2022-09-12 18:38:21 +00:00
Abraham Gonzalez d8ebc4ea99 Add env lock files | Fix CI 2022-09-12 16:52:32 +00:00
Abraham Gonzalez a7ccd492b6 Merge remote-tracking branch 'origin/main' into refactor_conda_abe 2022-09-09 17:11:58 +00:00
David Biancolin f6a1ee309e metasim: remove dramsim2 + move mm in-tree 2022-09-07 20:07:05 -07:00
tushar bf4d8d4e17 added ci job to test f1 driver build 2022-09-03 01:46:06 +00:00
Sagar Karandikar 9dd5f1b75e Merge remote-tracking branch 'origin/stable' 2022-08-31 18:44:38 +00:00
Sagar Karandikar f06c96d5aa Update firesim-run-tests.yml 2022-08-31 01:40:58 +00:00
Sagar Karandikar 733b99d8fd Update firesim-publish-scala-doc.yml 2022-08-31 01:40:05 +00:00
Abraham Gonzalez c5dd8288ef Small cleanup to CI 2022-08-25 20:54:35 +00:00
Tim Snyder 8cb2325e7e
Revert "add xclbin URI support (#1140)" (#1173)
This reverts commit a517b1992a.
2022-08-16 23:44:35 +00:00
David Biancolin a4acaefe9c
Explain how to run CI on PRs from forks. (#1154) 2022-08-12 16:18:38 -07:00
Tim Snyder a517b1992a
add xclbin URI support (#1140)
use fsspec to enable xclbin's to be one of any URI protocol
supported by the library or an installed add-on

Co-authored-by: Tim Snyder <snyder.tim@gmail.com>
Co-authored-by: Filip Stamenkovic <92741622+filipstamenkovic-sifive@users.noreply.github.com>
Co-authored-by: Abraham Gonzalez <abe.j.gonza@gmail.com>
2022-08-10 16:00:19 -05:00
Abraham Gonzalez 61caa0d7c9 Remove repo on fresh re-run | Remove retry amt | Get all runners 2022-08-09 22:58:03 +00:00
Abraham Gonzalez 7ab50caf2b Use API URL variable 2022-08-09 22:20:44 +00:00
Abraham Gonzalez 5ba61feb73 Move cull to global periodic workflow 2022-08-09 22:16:01 +00:00
Abraham Gonzalez 400dbb03f3 Unique runners for workflow run | Delete offline runners 2022-08-09 22:07:33 +00:00
mergify[bot] 83e8083085
Improve fabric logging (#1159)
Co-authored-by: Filip Stamenkovic <filip.stamenkovic@sifive.com>
Co-authored-by: Tim Snyder <timothy.snyder@sifive.com>
2022-08-09 11:03:53 -05:00
Tim Snyder f24a3e256e
Make bug report system info copy pastable (#1104)
Make it easier to fill in the bug report by giving users commands they can copy&paste into their shell and copy&paste the results back into the bug report.
2022-08-06 09:10:56 -05:00
Nandor Licker 2e205dce13
Enabled clang-format on C++ sources (#1139)
* Enabled clang-format on C++ sources

Ran clang-format on sources committed to the repository and added a CI job to ensure sources are properly formatted on each commit.
Clang-format can be installed using Linux package managers and the `git clang-format` command can be used to format all files that change with a commit.

* Update docs/Developer-Docs/GoldenGate-and-Driver-Development.rst

Co-authored-by: Tim Snyder <timothy.snyder@sifive.com>

* Update scripts/machine-launch-script.sh

Co-authored-by: Tim Snyder <timothy.snyder@sifive.com>

Co-authored-by: David Biancolin <david.biancolin@sifive.com>
Co-authored-by: Tim Snyder <timothy.snyder@sifive.com>
2022-08-02 23:12:13 -07:00
David Biancolin c536762885
ci: set MANAGER_FIRESIM_LOCATION in all workflows (#1149) 2022-08-01 20:48:56 -07:00
David Biancolin c240b2596f ci: update setup-self-hosted runner name and copypasta docstring 2022-07-27 18:47:16 +00:00
David Biancolin 4d46dc0733 ci: reame initialize-manager -> initialize-repo 2022-07-27 18:47:16 +00:00
David Biancolin b81abe7dca ci: Consolidate run_local + ci_variables 2022-07-27 18:47:16 +00:00
David Biancolin 4f956018aa Update .github/scripts/common.py
Co-authored-by: Abraham Gonzalez <abe.j.gonza@gmail.com>
2022-07-27 18:47:16 +00:00
David Biancolin 3efaf2327a Have workflow catch orphaned managers aggressively 2022-07-27 18:47:16 +00:00
David Biancolin 124931d3ca ci: support running under forks of firesim 2022-07-27 18:47:16 +00:00
Tim Snyder e1727758e9 Revert "echo SHA immediately before running pytest"
This reverts commit 84c0ee0b05.
2022-07-25 19:53:34 +00:00
Tim Snyder 84c0ee0b05 echo SHA immediately before running pytest 2022-07-25 16:33:19 +00:00
David Biancolin 603bb23203 ci: don't try to filter out python tests
They run relatively quickly so there is little upside to selectively running them
2022-07-25 05:15:52 +00:00
David Biancolin 7839d4fda5
ci: print ScalaTest stdout as it is running (#1131) 2022-07-16 19:35:28 -07:00
David Biancolin 89ff002242
Update CI_README.md (#1128)
* Update CI_README.md

* Update .github/CI_README.md

Co-authored-by: Abraham Gonzalez <abe.j.gonza@gmail.com>

Co-authored-by: Abraham Gonzalez <abe.j.gonza@gmail.com>
2022-07-12 16:31:35 +00:00
David Biancolin b4958dd327
Add a lightweight issue template for devs. (#1107) 2022-07-05 14:32:16 -07:00
David Biancolin b7dcea14aa ci: Move check docs generated components out of setup-manager 2022-06-23 13:11:06 -07:00
Abraham Gonzalez 29aac588a7 Update documentation 2022-06-18 08:13:22 +00:00
Abraham Gonzalez 5c78a3d035 Small cleanup 2022-06-17 02:44:10 +00:00
Abraham Gonzalez d6049ed970 Merge remote-tracking branch 'origin/main' into local-fpga-conda-b-abe 2022-06-17 02:37:45 +00:00
Sagar Karandikar 7409ab635e fix 2022-06-16 07:20:24 +00:00
Sagar Karandikar d58d32db41 debug 2022-06-16 06:18:38 +00:00
abejgonzalez de4cea4c54 Merge remote-tracking branch 'origin/main' into local-fpga-conda-b-abe 2022-06-15 21:51:58 -07:00
Sagar Karandikar dbd26235b1 non-quiet diff 2022-06-16 04:40:02 +00:00
abejgonzalez c0d346aa8a Add Vitis CI 2022-06-15 21:35:37 -07:00
Sagar Karandikar 9468e4dd9e dont continue on error 2022-06-16 02:10:36 +00:00
Sagar Karandikar 1194e69c50 check in CI if example outputs used in docs are up to date 2022-06-15 23:31:54 +00:00
Sagar Karandikar e04e578a30 Merge remote-tracking branch 'origin/1.13.x' into merge-1.13.x-to-main 2022-06-15 19:59:54 +00:00
Sagar Karandikar 00b0185ac3
Update action.yml 2022-06-14 22:16:09 -07:00
Sagar Karandikar 1498aaf200
Fix rpm name 2022-06-14 19:11:35 -07:00
Abraham Gonzalez f6382e8f81 Use Git 2.36 in CI 2022-06-13 22:22:02 -07:00
Sagar Karandikar 1dc2c9368c fix ci 2022-06-12 09:03:06 +00:00
Sagar Karandikar 9f51cc129e ci/test fixes 2022-06-12 07:44:10 +00:00
Abraham Gonzalez 2113d5d219
Merge pull request #1028 from firesim/where-to-run
("Where to Run") Initial support running on different run farm hosts
2022-06-07 01:03:40 -07:00
Abraham Gonzalez f1559d1c20 Use script name in run farm prefix in CI 2022-06-07 04:43:06 +00:00
Abraham Gonzalez 5ec0bcaaff Apply changes from code review 2022-06-04 23:59:33 +00:00
David Biancolin 6ef7d469cd ci: Run Scalafmt in CI 2022-05-31 20:07:34 +00:00
Abraham Gonzalez afb8e437ed Fix externally provisioned runfarm tag + wait 2022-05-31 04:04:46 +00:00
Abraham Gonzalez 8df0bcaf9b Wait for CI inst launch | Proper exit code 2022-05-31 03:14:50 +00:00
Abraham Gonzalez b14e4367ed Add support for local CI | Re-add sudo | Other misc. fixes 2022-05-31 01:49:39 +00:00
Abraham Gonzalez 9c98c7a12e Fix import in CI 2022-05-30 23:03:24 +00:00
Abraham Gonzalez a7ca6b1e04 Fix CI workdir in exter. prov. CI 2022-05-30 20:16:25 +00:00
Abraham Gonzalez a645732758 Fix externally provisioned script in CI 2022-05-30 19:03:28 +00:00
Abraham Gonzalez 1db980fb74 Fix CI bugs and small cleanup 2022-05-30 18:56:34 +00:00
abejgonzalez 61ef7b4744 Add test for externally provisioned | Fix run-wkld 2022-05-30 10:59:18 -07:00
Abraham Gonzalez 1333a266f4 Fix linux poweroff GH-A [ci skip] 2022-05-30 17:10:55 +00:00
Abraham Gonzalez 7ad48750d9 Fix workloads/ dir + Fix CI 2022-05-07 04:10:24 +00:00
David Biancolin f7a1f95699
ci: Terminate potentially orphaned managers (#1049) 2022-05-03 10:28:58 -07:00
Abraham Gonzalez ef4d3298c9
Add Python typing to all files + Cleanup based off it (#1042)
* Fix typing across codebase

* Switches can be on any instance
2022-05-01 02:13:56 +00:00
Abraham Gonzalez 3eb1bb6053 Fix typing across codebase 2022-04-30 20:42:06 +00:00
abejgonzalez 2c67f9bc46 awstools typing + small organization 2022-04-25 22:17:32 +00:00
Abraham Gonzalez 4926b8ea45
Merge pull request #1040 from firesim/fix-fpga-sim-timeout
Fix CI FPGA sim timeout issue + Use Python3 formatting in `run_linux_poweroff` CI script
2022-04-25 12:22:23 -07:00
David Biancolin 2150c1697e
CI: Catch bad manager initialization in workflow control flow (#1038) 2022-04-23 20:29:43 -07:00
Abraham Gonzalez d4aec0f9f8 Don't ls + tail if there is no directory present 2022-04-23 01:52:38 +00:00
Abraham Gonzalez 2fde18ea72 Remove .format string formatting 2022-04-23 01:50:49 +00:00
David Biancolin 68b093823a ci: Terminate instances on failure or timeout conditions 2022-04-22 10:13:18 -07:00
David Biancolin 66f9aaaf3a ci: More aggressively clean up instances 2022-04-22 10:13:18 -07:00
David Biancolin ecf2615bce ci: Switch manager to use spot instances 2022-04-22 10:13:18 -07:00
Abraham Gonzalez b62d7a080a Remove manager_instance ci duplication 2022-04-22 03:43:02 +00:00
Abraham Gonzalez c06feb9124 Remove unused CI func 2022-04-22 03:38:37 +00:00
David Biancolin e798e7955b
ci: Fix git configuration in scaladoc publishing (#1032) 2022-04-21 00:49:30 +00:00
David Biancolin a9e4ac7d04 [ci] Update GH-hosted CI container machine-launch/build-setup for conda 2022-04-20 17:14:54 +00:00
David Biancolin e7b1b3f001
Conditionally run the scala doc build on PRs (#1025) 2022-04-15 11:21:13 -04:00
Tim Snyder 643b732148 source&persist env changes made by actions/machinelaunchscript 2022-04-13 12:47:29 -05:00
Tim Snyder 6bd99b2b8c Merge remote-tracking branch 'origin/main' into use_conda 2022-04-13 00:22:58 +00:00
Tim Snyder 2d10e882cc Revert "add debug output to build-default-workloads.py"
This reverts commit 892aadb5bd.
2022-04-11 19:58:25 +00:00
Tim Snyder 8e95550ac6 add more debug output for CI doc test 2022-04-06 14:31:44 +00:00
Abraham Gonzalez 12df0cb741 Apply suggestions from code review 2022-04-04 16:50:32 -07:00
Tim Snyder a78f3790fd use make 4.2 until marshal bumps buildroot 2022-04-04 20:31:19 +00:00
abejgonzalez b53422702d Merge remote-tracking branch 'origin/local-fpga' 2022-04-02 22:29:06 -07:00