Commit Graph

1254 Commits

Author SHA1 Message Date
giannozz ec2af1f255 Temporary fix for vdw-TS: atomic positions are brought back to the original
(input) ordering, then supplied to the vdw-TS routine. Forces are then
re-ordered. The reason is that array ityp used by vdw-TS referes to the
input ordering.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10710 c92efa57-630b-4861-b058-cf58834340f0
2014-01-31 07:20:49 +00:00
giannozz 29dd40e05b One more TS-vdw glitch; unused variables removed
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10689 c92efa57-630b-4861-b058-cf58834340f0
2014-01-22 08:10:30 +00:00
giannozz 4c4d449085 Cleanup and speedup of DFT+U calculations
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10688 c92efa57-630b-4861-b058-cf58834340f0
2014-01-21 21:22:04 +00:00
giannozz 98bda5de60 TS-vdW was crashing due to incorrect USEage of variable ts_vdw
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10686 c92efa57-630b-4861-b058-cf58834340f0
2014-01-20 20:25:51 +00:00
giannozz fe16005724 Makov-Payne calculation in CP wasn't working any longer: array ityp in
ions_position is never initialized. This is just a temporary fix: there
is still a considerable mess with sorted and unsorted atomic positions


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10680 c92efa57-630b-4861-b058-cf58834340f0
2014-01-13 06:52:37 +00:00
giannozz d4881fde32 No need to sum over k-points in CP
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10662 c92efa57-630b-4861-b058-cf58834340f0
2014-01-06 16:53:50 +00:00
giannozz b6e2ac925f First attempt of a band parallelization for LDA+U in CP.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10661 c92efa57-630b-4861-b058-cf58834340f0
2014-01-06 16:41:51 +00:00
giannozz b8228aab91 Oops...
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10660 c92efa57-630b-4861-b058-cf58834340f0
2014-01-05 21:37:25 +00:00
giannozz da3d43d9f4 More PW/CP harmonization for LDA+U
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10659 c92efa57-630b-4861-b058-cf58834340f0
2014-01-05 21:21:01 +00:00
giannozz 584c6337a0 For consistency with PW: wfc => wfcU, n_atomic_wfc => nwfcU
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10658 c92efa57-630b-4861-b058-cf58834340f0
2014-01-05 15:19:51 +00:00
giannozz 8453b0bb74 DTT+U in CP: more cleanup and a little bit of speedup
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10657 c92efa57-630b-4861-b058-cf58834340f0
2014-01-03 11:04:34 +00:00
spigafi 41d80c532d Dependencies issue fully resolved.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10655 c92efa57-630b-4861-b058-cf58834340f0
2013-12-31 12:19:17 +00:00
spigafi 2a8266edda Removed circular dependency.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10653 c92efa57-630b-4861-b058-cf58834340f0
2013-12-31 10:49:23 +00:00
giannozz b73e21d986 Cleanup of DFT+U: penalty function stuff moved into ldaUpen.f90. Not sure
whether it still works, since there is no test available, but it shouldn't
be worse than before, and maybe better, since I fixed two serious errors.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10652 c92efa57-630b-4861-b058-cf58834340f0
2013-12-30 14:45:14 +00:00
giannozz 53297f3416 Indices of variables ns, dns used in DFT+U aligned with PW usage
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10651 c92efa57-630b-4861-b058-cf58834340f0
2013-12-29 19:46:59 +00:00
giannozz 077f7e40d6 DFT+U should now work in CP together with "task groups"
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10650 c92efa57-630b-4861-b058-cf58834340f0
2013-12-29 09:39:14 +00:00
giannozz 6fbb3bc62d Tkatchenko-Scheffler in PW as well. Will likely need some more tweaking
but it is already sort of working (courtesy of Simone Piccinin) 


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10630 c92efa57-630b-4861-b058-cf58834340f0
2013-12-02 16:02:21 +00:00
giannozz 1d2b3d6646 TS-vdW moved from CPV to Modules. No changes, apart charge density (rhor)
passed as variable in a call instead of a module variable


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10619 c92efa57-630b-4861-b058-cf58834340f0
2013-11-25 14:25:56 +00:00
giannozz 7d6bd3de29 make.depend.updated
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10594 c92efa57-630b-4861-b058-cf58834340f0
2013-11-08 11:12:17 +00:00
riccardo 45f503ebe4 Extended CPV management of nonlocal functionals. Now
depending on the inlc the correct non-local functional is
loaded and executed



git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10592 c92efa57-630b-4861-b058-cf58834340f0
2013-11-08 10:59:29 +00:00
giannozz 7c01062ba0 Final (?) set of changes to the build system, especially for Windows (Axel)
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10590 c92efa57-630b-4861-b058-cf58834340f0
2013-11-07 21:06:06 +00:00
giannozz d224f9d7b8 Small fixes for unitialized variables and questionable constructs,
courtesy of Ake Sandgren


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10577 c92efa57-630b-4861-b058-cf58834340f0
2013-11-05 14:35:41 +00:00
giannozz c1f947ba6e make.depend updated + minor format fix
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10568 c92efa57-630b-4861-b058-cf58834340f0
2013-11-03 20:19:48 +00:00
giannozz 3fcc01b467 Variables for task group (actually a single one) moved to where it belongs
(I think): mp_bands.f90 . Many changes but nothing dangerous. Note that 
codes not in svn may be broken by this change, but the fix is very simple


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10567 c92efa57-630b-4861-b058-cf58834340f0
2013-11-03 19:16:37 +00:00
giannozz a79a80e862 Compilation error in parallel execution. Note: please reduce #ifdef __MPI to
the strict minimum!


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10559 c92efa57-630b-4861-b058-cf58834340f0
2013-10-28 08:50:41 +00:00
giannozz 95600c8582 More cleanup of parallel modules: mp_global no longer contains references to
variables for the "world" MPI communicator. The latter are to be found in 
world_comm instead. mp_global should be used only to start and to end the
various parallelization levels. Many small but harmless changes: a few 
variables removed or moved to another module in most cases.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10558 c92efa57-630b-4861-b058-cf58834340f0
2013-10-27 09:09:10 +00:00
ccavazzoni eabe5f67fd - commit of the latest Axel patch
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10533 c92efa57-630b-4861-b058-cf58834340f0
2013-10-12 22:28:12 +00:00
ccavazzoni 3667d17bd3 - optional communicator completely removed
- PWCOND was not compiling any more after last branch merging,
  I fix it mapping old to new variables (realus), but I need someone checking it 


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10532 c92efa57-630b-4861-b058-cf58834340f0
2013-10-12 21:32:01 +00:00
giannozz 1976e0715c Removal of tabulators. There are many more in iotk and QHA, though
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10525 c92efa57-630b-4861-b058-cf58834340f0
2013-10-10 12:59:30 +00:00
giannozz 41c8b628f1 Minor fixes by Axel to reduce the number of compiler warnings - harmless but
too many of them may hide serious warnings


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10524 c92efa57-630b-4861-b058-cf58834340f0
2013-10-10 12:46:35 +00:00
ccavazzoni 288ebfcc42 - more implicit world communicator clean-up
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10522 c92efa57-630b-4861-b058-cf58834340f0
2013-10-09 08:17:40 +00:00
ccavazzoni 34781504de - more implicit world communicator clean-up
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10511 c92efa57-630b-4861-b058-cf58834340f0
2013-10-06 19:09:46 +00:00
giannozz 14383b42b9 Some updates to input documentation
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10505 c92efa57-630b-4861-b058-cf58834340f0
2013-10-03 08:38:28 +00:00
giannozz b43bb27ce1 Same for CP
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10504 c92efa57-630b-4861-b058-cf58834340f0
2013-10-03 08:29:37 +00:00
giannozz d6584cfc27 Out-of-bounds error noticed by Axel
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10496 c92efa57-630b-4861-b058-cf58834340f0
2013-09-28 12:40:07 +00:00
ccavazzoni 8b9c1a54d0 - more Axel patches for LAMMPS and QE integration
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10493 c92efa57-630b-4861-b058-cf58834340f0
2013-09-27 14:37:51 +00:00
ccavazzoni 728a1c33d0 adding explicit communicator in "mp" cals
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10490 c92efa57-630b-4861-b058-cf58834340f0
2013-09-26 20:52:09 +00:00
giannozz b1820bac3c Workaround for strange compilation errors on BG with OpenMP: apparently
the compiler doesn't recognize a reduction as such in PW/src/v_of_rho.f90;
in CPV/src/tsvdw.f90, it requires to specify the sign. There is however a 
case (varoable FtsvdW_period) for which the reduction is done once with 
a + and once with a - sign, so it is not clear to me what to do!


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10448 c92efa57-630b-4861-b058-cf58834340f0
2013-08-26 19:40:11 +00:00
giannozz b2a9bf931b One more Makefile updated, minor release-notes update
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10447 c92efa57-630b-4861-b058-cf58834340f0
2013-08-26 16:43:58 +00:00
giannozz db78b5799b More careful removal of scratch files in examples: only files starting with
"pwscf" or "cp" are removed when the scratch directory is cleaned. May still
need some tweaking in some cases, though, because not all files start with
the value of "prefix" variable


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10437 c92efa57-630b-4861-b058-cf58834340f0
2013-08-16 14:39:10 +00:00
giannozz a57d85860c Removed comma that shouldn't be there
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10436 c92efa57-630b-4861-b058-cf58834340f0
2013-08-16 07:58:43 +00:00
giannozz a6a83aff18 Harmonization of Tkachenko-Scheffler VdW correction with existing Grimme
semiempirical correction and with general QE programming style (if any):
* there is a new variable "vdw_corr", in namelist &system (not &control)
  that can have 'TS', 'ts', 'Grimme-D2', etc values. I guess there will
  be soon 2n+1 different van der Waals semiempirical corrections, so it
  is wise to have a single variable for all of them. Related variables
  (options, cutoffs, etc) keep their current names, are read from &system.
* variables read on input are copied to internal variables, as in all
  other cases. It is clumsy and I am starting to doubt it will ever be
  useful, but it has to be done in a consistent way.
Note that this may introduce some incompatibilities, especially for users
of modified CP code. If anybody has better ideas, feel free to propose.
If something doesn't work as expected, please let me know.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10426 c92efa57-630b-4861-b058-cf58834340f0
2013-08-06 15:01:29 +00:00
giannozz 8d7a616789 Documentation updated with latest developments
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10419 c92efa57-630b-4861-b058-cf58834340f0
2013-08-02 19:17:55 +00:00
giannozz 19e69111cb Compilation in serial (no warrantly newly added feature Tkatchenko-Scheffler
works in serial, though); make.depend updated


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10415 c92efa57-630b-4861-b058-cf58834340f0
2013-08-01 16:12:01 +00:00
robdistasio 5d57b11ec3 Added vdW correction of Tkatchenko-Scheffler (PRL, 102, 073005, (2009)) in CP code
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10404 c92efa57-630b-4861-b058-cf58834340f0
2013-07-26 20:34:54 +00:00
robdistasio 91465980a4 Fixed spelling of accumulated in CPV/src/print_out.f90
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10403 c92efa57-630b-4861-b058-cf58834340f0
2013-07-26 18:57:50 +00:00
giannozz 76088ea7eb Mior fix
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10383 c92efa57-630b-4861-b058-cf58834340f0
2013-07-16 07:06:48 +00:00
giannozz d7a8231ddb Fortran instruction "read(string,*) something" does not read anything if
"string" starts with a "/", leaving "something" unchanged. This may lead
to a rather obscure behavior. Added warning in documentation.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10343 c92efa57-630b-4861-b058-cf58834340f0
2013-07-02 17:08:14 +00:00
giannozz 857f524175 Bug in exx.f90 (courtesy of Simone Ziraldo): bad array copy if nopool=1,
plus minor things here and there 


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10335 c92efa57-630b-4861-b058-cf58834340f0
2013-06-25 13:30:44 +00:00
giannozz c15acb5030 Printout of XC functional in CP uses the same routine in module "funct" as PW.
Maybe less nice but accurate and updated. Do not print info on exact exchange
fraction if the latter is zero. Format enlarged.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10309 c92efa57-630b-4861-b058-cf58834340f0
2013-06-10 12:55:41 +00:00