replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[ELF] Remove FIXME(s) that are already fixed. 

FIXME code was left around in few places where its already been taken care of.

This removes the FIXME's that are not needed.

llvm-svn: 230139
This commit is contained in:
Shankar Easwaran 2015-02-21 15:51:54 +00:00
parent 99abafb4af
commit 75ed9746e6
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lld/lib/ReaderWriter/ELF/Atoms.h
View File

@ -124,9 +124,8 @@ public:
StringRef name() const override { return _name; } StringRef name() const override { return _name; }
// FIXME: What distinguishes a symbol in ELF that can help decide if the // A symbol in ELF can be undefined at build time if the symbol is a undefined
// symbol is undefined only during build and not runtime? This will make us // weak symbol.
// choose canBeNullAtBuildtime and canBeNullAtRuntime.
CanBeNull canBeNull() const override { CanBeNull canBeNull() const override {
if (_symbol->getBinding() == llvm::ELF::STB_WEAK) if (_symbol->getBinding() == llvm::ELF::STB_WEAK)
return CanBeNull::canBeNullAtBuildtime; return CanBeNull::canBeNullAtBuildtime;
@ -192,7 +191,6 @@ public:
// FIXME: Need to revisit this in future. // FIXME: Need to revisit this in future.
Interposable interposable() const override { return interposeNo; } Interposable interposable() const override { return interposeNo; }
// FIXME: What ways can we determine this in ELF?
Merge merge() const override { Merge merge() const override {
if (_symbol->getBinding() == llvm::ELF::STB_WEAK) if (_symbol->getBinding() == llvm::ELF::STB_WEAK)
return mergeAsWeak; return mergeAsWeak;