From 75ed9746e6a61b6c052f5a6d387fb6eed6aef309 Mon Sep 17 00:00:00 2001 From: Shankar Easwaran Date: Sat, 21 Feb 2015 15:51:54 +0000 Subject: [PATCH] [ELF] Remove FIXME(s) that are already fixed. FIXME code was left around in few places where its already been taken care of. This removes the FIXME's that are not needed. llvm-svn: 230139 --- lld/lib/ReaderWriter/ELF/Atoms.h | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/lld/lib/ReaderWriter/ELF/Atoms.h b/lld/lib/ReaderWriter/ELF/Atoms.h index b95c782a0a8f..be1daaa78393 100644 --- a/lld/lib/ReaderWriter/ELF/Atoms.h +++ b/lld/lib/ReaderWriter/ELF/Atoms.h @@ -124,9 +124,8 @@ public: StringRef name() const override { return _name; } - // FIXME: What distinguishes a symbol in ELF that can help decide if the - // symbol is undefined only during build and not runtime? This will make us - // choose canBeNullAtBuildtime and canBeNullAtRuntime. + // A symbol in ELF can be undefined at build time if the symbol is a undefined + // weak symbol. CanBeNull canBeNull() const override { if (_symbol->getBinding() == llvm::ELF::STB_WEAK) return CanBeNull::canBeNullAtBuildtime; @@ -192,7 +191,6 @@ public: // FIXME: Need to revisit this in future. Interposable interposable() const override { return interposeNo; } - // FIXME: What ways can we determine this in ELF? Merge merge() const override { if (_symbol->getBinding() == llvm::ELF::STB_WEAK) return mergeAsWeak;