maxjhandsome
/
react
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #1716 from somethingkindawierd/master 

Removes value attribute from rendered html of textarea
This commit is contained in:
Cheng Lou 2014-06-24 19:14:19 -07:00
parent 56263c44e8 e077dd40eb
commit d52bebd07b
2 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/browser/ui/dom/components/ReactDOMTextarea.js
View File

@ -88,8 +88,7 @@ var ReactDOMTextarea = ReactCompositeComponent.createClass({
// `textContent` (unnecessary since we update value). // `textContent` (unnecessary since we update value).
// The initial value can be a boolean or object so that's why it's // The initial value can be a boolean or object so that's why it's
// forced to be a string. // forced to be a string.
initialValue: '' + (value != null ? value : defaultValue), initialValue: '' + (value != null ? value : defaultValue)
value: defaultValue
}; };
}, },
@ -101,7 +100,6 @@ var ReactDOMTextarea = ReactCompositeComponent.createClass({
render: function() { render: function() {
// Clone `this.props` so we don't mutate the input. // Clone `this.props` so we don't mutate the input.
var props = merge(this.props); var props = merge(this.props);
var value = LinkedValueUtils.getValue(this);
invariant( invariant(
props.dangerouslySetInnerHTML == null, props.dangerouslySetInnerHTML == null,
@ -109,7 +107,7 @@ var ReactDOMTextarea = ReactCompositeComponent.createClass({
); );
props.defaultValue = null; props.defaultValue = null;
props.value = value != null ? value : this.state.value; props.value = null;
props.onChange = this._handleChange; props.onChange = this._handleChange;
// Always set children to the same thing. In IE9, the selection range will // Always set children to the same thing. In IE9, the selection range will

8
src/browser/ui/dom/components/__tests__/ReactDOMTextarea-test.js
View File

@ -85,6 +85,14 @@ describe('ReactDOMTextarea', function() {
expect(node.value).toBe('foobar'); expect(node.value).toBe('foobar');
}); });
it('should not render value as an attribute', function() {
var stub = <textarea value="giraffe" onChange={emptyFunction} />;
stub = renderTextarea(stub);
var node = stub.getDOMNode();
expect(node.getAttribute('value')).toBe(null);
});
it('should display `value` of number 0', function() { it('should display `value` of number 0', function() {
var stub = <textarea value={0} />; var stub = <textarea value={0} />;
stub = renderTextarea(stub); stub = renderTextarea(stub);