From b9c132e58ae9490747bbb09de0e76455af4f0a7d Mon Sep 17 00:00:00 2001 From: Jon Beebe Date: Wed, 18 Jun 2014 14:34:04 -0500 Subject: [PATCH 1/2] Removes value from rendered attributes of textarea --- src/browser/ui/dom/components/ReactDOMTextarea.js | 6 ++---- .../ui/dom/components/__tests__/ReactDOMTextarea-test.js | 8 ++++++++ 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/browser/ui/dom/components/ReactDOMTextarea.js b/src/browser/ui/dom/components/ReactDOMTextarea.js index a8aa82f661..91d0e346e9 100644 --- a/src/browser/ui/dom/components/ReactDOMTextarea.js +++ b/src/browser/ui/dom/components/ReactDOMTextarea.js @@ -88,8 +88,7 @@ var ReactDOMTextarea = ReactCompositeComponent.createClass({ // `textContent` (unnecessary since we update value). // The initial value can be a boolean or object so that's why it's // forced to be a string. - initialValue: '' + (value != null ? value : defaultValue), - value: defaultValue + initialValue: '' + (value != null ? value : defaultValue) }; }, @@ -101,7 +100,6 @@ var ReactDOMTextarea = ReactCompositeComponent.createClass({ render: function() { // Clone `this.props` so we don't mutate the input. var props = merge(this.props); - var value = LinkedValueUtils.getValue(this); invariant( props.dangerouslySetInnerHTML == null, @@ -109,7 +107,7 @@ var ReactDOMTextarea = ReactCompositeComponent.createClass({ ); props.defaultValue = null; - props.value = value != null ? value : this.state.value; + props.value = null; props.onChange = this._handleChange; // Always set children to the same thing. In IE9, the selection range will diff --git a/src/browser/ui/dom/components/__tests__/ReactDOMTextarea-test.js b/src/browser/ui/dom/components/__tests__/ReactDOMTextarea-test.js index f0617de95b..7b4b433c61 100644 --- a/src/browser/ui/dom/components/__tests__/ReactDOMTextarea-test.js +++ b/src/browser/ui/dom/components/__tests__/ReactDOMTextarea-test.js @@ -85,6 +85,14 @@ describe('ReactDOMTextarea', function() { expect(node.value).toBe('foobar'); }); + it('should not render value as an attribute', function() { + var stub =