Commit Graph

1212 Commits

Author SHA1 Message Date
Ville Skyttä 495d049fb9 Improve PreReq and broken context marked dep syntax regexps and descriptions.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1298 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä ebf324d1f5 Don't hardcode InvalidRequires default, fix up indentation.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1297 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä e5c9893934 InvalidRequires is a list of regexps, not strings.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1296 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 3b5a1c9818 Add Creative Commons licenses, https://bugzilla.redhat.com/211417
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1295 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä d5fc57750b Fine tune forbidden-selinux-command info message.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1294 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä a6e4adb3cd Check for forbidden SELinux related commands (Steve Grubb, https://bugzilla.redhat.com/214605)
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1293 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä ed5754d463 Drop some duplicate code.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1292 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 3eba0092e6 Allow 3-letter language codes in locale subdirs (Dave Lehman, https://bugzilla.redhat.com/212491).
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1291 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 7bc3247b21 Skip non-PIC check if objdump failed.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1290 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 4ec4e82bd1 Don't run ldd on ar archives, https://bugzilla.redhat.com/210110
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1289 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 36963589f3 Try to avoid infinite recursion in shell variable expansion
https://bugzilla.redhat.com/210261


git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1288 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä a085538e82 Add start boundary to shell variable assignment regexp
https://bugzilla.redhat.com/210261


git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1287 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 8f247d67d3 Fix regression introduced in [1242]: shell variable expansion needs the whole
file to be passed to it, not just the current line being examined
https://bugzilla.redhat.com/210261


git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1286 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 14f7c5562d Don't crash in istextfile() if reading fails, eg. https://bugzilla.redhat.com/209876
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1285 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 5657780353 Don't assume all packages have a source rpm or i18n table, eg. gpg-pubkeys don't; https://bugzilla.redhat.com/209889
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1284 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä def2cc1c9c Only try to check rpm files when given a directory.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1283 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 69656f61c7 Don't run main() when importing rpmlint.py, makes eg. pychecker happier (#48).
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1282 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 62fd404bcc Add editor indentation settings.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1281 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Michael Scherer bc44329ab3 tag 0.78 in Makefile
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1279 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Michael Scherer 3451fdecf5 - some refactoring
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1278 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Michael Scherer 8188e74efc - fix test
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1277 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä d8c3bac63a Python >= 2.0 required for popen4.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1276 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 4af39f65b4 Use sequence based command invocation more; avoids shell escaping/whitespace issues eg. like https://bugzilla.redhat.com/206383
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1275 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä d50d7f49b1 sw is valid for Swahili, don't treat is as misspelled Swedish.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1274 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 32f9671d70 Take escaping into account when finding buildroot strings, fixes #47.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1273 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 7e1f0b382b Say which section lacks cleanup in no-cleaning-of-buildroot.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1272 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 2fc56f47ef Recognize GIT and Mercurial "SCM internal" files.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1271 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä f8371af444 More literal dot in regexp escaping.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1270 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 8662c5940d Drop unused regexps.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1269 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 0e8e67fc94 Check for unversioned Provides/Obsoletes in specfiles.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1268 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 851af13a44 Distinguish between sourced and executed scripts (Guillaume Rousse, #17).
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1267 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 44404e0824 Add comment about *.pm shebang (initially from #17)
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1266 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 3991d5e074 s/shellbang/shebang/ (part of #17)
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1265 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 8712d56a83 Escape literal dots in regexps.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1264 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:26 +03:00
Ville Skyttä 626cd9bd2b Don't demand executable scripts in /etc/profile.d; cf. https://bugzilla.redhat.com/35714
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1263 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Ville Skyttä 22d076ef28 Allow init scripts with package name + 'd'.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1262 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Ville Skyttä 609a9fd967 Use Pkg.grep, output line numbers; fixes #38.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1261 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Ville Skyttä 98cad727d0 Improve invalid dir reference regexp, compile it only once.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1260 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Ville Skyttä decf2b26a3 Make Pkg.grep more robust, change to instance method, return matching line numbers.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1259 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Ville Skyttä 94fe076be1 Tone down invalid-license message a bit.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1258 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Ville Skyttä d369c943de Add no-url-tag description (duh).
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1257 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Ville Skyttä ced0c77883 Improve broken scriptlet dep regex.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1256 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Ville Skyttä 66309466d6 Check broken scriptlet dep syntax only in the "package" section (Pascal Terjan, #42).
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1255 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Ville Skyttä 963f180248 Check for world writable files and dirs.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1254 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Ville Skyttä e6d0ac91be Add some TODO comments.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1253 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Michael Scherer 7aaea86c5f - add Xdg menu directory to %updates-menus detection
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1252 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Michael Scherer 444bb748c4 - really fix the call to desktop-file-validate
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1251 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Michael Scherer 5c400d2499 - fix the check
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1250 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Ville Skyttä b67df45571 Catch macroized %{__make} etc in make check regexp, and ignore all of it in %description too.
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1249 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00
Ville Skyttä 132ee09363 Use zlib/libpng, not zlib for that license to follow the OSI list (bugzilla.redhat.com/198616).
git-svn-id: svn+ssh://rpmlint.zarb.org/home/projects/rpmlint/svn/trunk@1248 9bc8b190-ac0f-0410-8968-dc7d1f502856
2015-07-09 16:43:25 +03:00