This patch adds a new warning when detecting the use of python_module
macro definition in the spec file.
It's included by default in python-rpm-macros so every modern distro
should have this module defined.
This macro was added by py2pack by default in new packages, but now it's
removed:
https://github.com/openSUSE/py2pack/pull/166
Python stable ABI extension modules have filenames with the .ai3.so suffix, e.g.:
python3-tpm2-pytss.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.11/site-packages/tpm2_pytss/_libtpm2_pytss.abi3.so ...
This patch makes the code a bit more readable, breaking the big for-loop
that check the spec file line by line in a series of methods in the
SpecCheck class.
With this change it's easier to extend the line-by-line check with
small functions and the if-else-if-... complexity is reduced a bit.
See #225
The epilog added in f551541a (rpmdiff: improve help for multiple values
with -i/-e options, 2022-10-04) mentions multiple values for the -i/-e
options. However, the issue is present regardless of the number of
values. Remove the reference to multiple values to simplify the help
text.
When using multiple values with the -i or -e options, rpmlint-2.x
is incompatible with earlier releases. Moreover, the behavior is not
immediately obvious to users¹.
To help alleviate this slightly, add an epilog to the parser which
explains how to pass multiple options to -i/-e options using either '--'
to separate the values from the following positional arguments or lists
the options _after_ the positional arguments.
This isn't really a fix for the poor behavior we get from argparse
relative to what older releases had with getopt, but maybe it's enough
until folks get used to how the options must be handled in 2.x releases.
This partially addresses #940.
¹ https://bugzilla.redhat.com/1969534
Update the script from 5ee8dc83 (extract script generating Fedora users
and groups to tools/, 2021-03-24) to produce output suitable for writing
directly to configs/Fedora/users-groups.toml.
Sort the user and group lists to provide more stable output.
The uidgid file in setup was changed to use '#' for comments in c2d8d46
(uidgid: simplify table format by properly commenting lines,
2022-05-30), released in 2.14.1.
Before then, a few stray comment lines were added in a2b68d4 (remove
uidgid reservation for systemd-journal-gateway (#1174304), 2014-12-18)
and 6563bed (Stop creating katello user, 2021-06-16), released in
setup-2.9.3 and setup-2.13.9, respectively.
Skip lines beginning with a comment marker when parsing the uidgid file.
Similarly to library-without-ldconfig-postin and library-without-ldconfig-postun,
add postin-without-ldconfig and postun-without-ldconfig to Filters.
Fixes: #922
System V requires that .hash sections is present in shared libraries
for dynamic symbol resolution. And we can emit warning when .gnu.hash
section is missing as it rapidly speeds up the symbol resolution.
Daniel Garcia Moreno