Commit Graph

3408 Commits

Author SHA1 Message Date
Daniel Garcia Moreno 6fbcbe8706 test: Add another test for patch-not-applied
See https://github.com/rpm-software-management/rpmlint/issues/398
2024-01-23 11:31:57 +01:00
danigm ea2d230c5f
Adding support for RPM packages containing files greater than 4GB
Use rpm2archive instead rpm2cpio if the command is available, to extract the rpm package files.

#1168
2024-01-19 07:44:13 +01:00
Mikhail Campos Guadamuz 532069198f read rpm package directly with open() while extracting 2024-01-17 11:48:45 +01:00
Mikhail Campos Guadamuz ec86552bc5 remove redundant TODO comments; checking is handled with check_output() pretty well now 2024-01-17 10:42:05 +01:00
Mikhail Campos Guadamuz c3e0d7ed44 leave rpm2cpio as fallback for distros which do not have rpm2archive available yet 2024-01-17 10:28:41 +01:00
Mikhail Campos Guadamuz 72e74a16fa fix warnings about import order, attempt 2 2024-01-16 08:13:48 +01:00
Mikhail Campos Guadamuz 0c4cae3055 fix warnings about import order 2024-01-15 19:07:44 +01:00
Mikhail Campos Guadamuz d15426661e Fixes for nsafe shell command 2024-01-15 17:11:56 +01:00
Mikhail Campos Guadamuz cc971569fc Drop rpm2cpio usage entirely 2024-01-15 15:13:56 +01:00
Mikhail Campos Guadamuz 2cf3e0de2c Adding support for RPM packages containing files greater than 4GB 2024-01-15 14:11:14 +01:00
danigm 8be437fef3
Merge pull request #1163 from rpm-software-management/reset-checks
lint: Reset all checks for each package
2024-01-08 13:55:54 +01:00
Daniel García Moreno 50a33b41c6 lint: Reset all checks for each package
Some check classes keep state during checking and this cause problems
when checking several files with the same call.

This patch resets all the checks for each package to check. This is a
quick solution, maybe the best way to handle this is to reset the state
for each check in with a common method in the AbstractCheck, a common
way to handle and reset the state to avoid this problem in the future.

Fix https://github.com/rpm-software-management/rpmlint/issues/1161
2024-01-03 15:08:05 +01:00
danigm a79af73d23
Merge pull request #1153 from rpm-software-management/missing-dependency-on-with-epoch
test: Extend tag tests to check 'W: missing-dependency-on'
2023-12-14 10:29:08 +01:00
Daniel Garcia Moreno 663c98adbd test: Extend tag tests to check 'W: missing-dependency-on'
See https://github.com/rpm-software-management/rpmlint/pull/1152
2023-12-14 10:13:35 +01:00
danigm cb507aa60a
Merge pull request #1148 from carlosrodfern/main
fix readelf output encoding handling of errors
2023-12-04 17:41:58 +01:00
Carlos Rodriguez-Fernandez af2c43fa81
fix readelf output encoding handling of errors
Fixes: #1147
Signed-off-by: Carlos Rodriguez-Fernandez <carlosrodrifernandez@gmail.com>
2023-12-04 07:21:30 -07:00
danigm d2dc3b182c
Merge pull request #1144 from dirkmueller/handle_invalid_symbols
Ignore (and escape) symbols that are not valid utf8
2023-11-30 07:17:33 +01:00
Dirk Müller 82c9323767 Ignore (and escape) symbols that are not valid utf8
the golang binaries are not creating utf8 symbols, so we need
to escape them otherwise rpmlint crashes on decoding them as utf8
2023-11-29 07:31:43 +01:00
danigm f69a8f4efd
Merge pull request #1143 from rpm-software-management/enable-mageia
Revert "Disable Mageia CI builds due to system problem"
2023-11-27 09:30:08 +01:00
Daniel Garcia Moreno c038458d42 Revert "Disable Mageia CI builds due to system problem"
This reverts commit 57e75f34f8.
2023-11-27 09:18:47 +01:00
Daniel Garcia Moreno 57e75f34f8 Disable Mageia CI builds due to system problem
Bug url: https://bugs.mageia.org/show_bug.cgi?id=32527
2023-11-15 11:23:47 +01:00
danigm ba80405c1f
Merge pull request #1131 from antlarr-suse/add_pgadmin_user
Add pgadmin user/group
2023-10-26 07:49:16 +02:00
Antonio Larrosa ca6cdc27cc Add pgadmin user/group 2023-10-25 10:54:24 +02:00
Daniel Garcia Moreno 8faa54d18b Release 2.5.0 2023-10-20 08:42:45 +02:00
danigm 0d3cef792c
Merge pull request #1122 from rpm-software-management/link-to-shebang
Add new check to detect links to scripts
2023-10-19 12:33:12 +02:00
Daniel Garcia Moreno aeb59a3deb Add new check to detect links to scripts
This new check looks for links in /usr/bin that points to some script in
a non bin path that contains a shebang, and checks if the needed
interpreter is included as a requirement, because in that case rpm won't
be able to inject the requirement by itself.

Fix https://github.com/rpm-software-management/rpmlint/issues/1120
2023-10-19 11:23:32 +02:00
danigm 3691f93869
Merge pull request #1130 from rpm-software-management/patch-not-applied
SpecCheck: Support "%patch n" to detect applied patches
2023-10-19 11:19:20 +02:00
Daniel Garcia Moreno 094df2eaed SpecCheck: Support "%patch n" to detect applied patches
"%patch n" is a valid usage of the %patch macro, similar to
"%patch -P n", this patch support the usage of this method when
checkinng for not applied patches.

See https://github.com/rpm-software-management/rpmlint/issues/1099
2023-10-19 10:06:09 +02:00
danigm 63c980aeaa
Merge pull request #1129 from rpm-software-management/details-for-crypto-policy
lint: Show dynamic description for WarnOnFunction config
2023-10-19 08:20:35 +02:00
danigm fcf5e01ff0
Merge pull request #1128 from rpm-software-management/details-for-invalid-lc-messages-dir
descriptions: Add invalid-lc-messages-dir
2023-10-19 08:19:58 +02:00
danigm 10796b73fb
Merge pull request #1127 from rpm-software-management/details-for-files-duplicates
description: Add files-duplicate description
2023-10-19 08:19:44 +02:00
Daniel Garcia Moreno dc4f43144f lint: Show dynamic description for WarnOnFunction config
Fix https://github.com/rpm-software-management/rpmlint/issues/1075
2023-10-18 10:56:29 +02:00
Daniel Garcia Moreno 6bacc31073 description: Add files-duplicate description
Fix https://github.com/rpm-software-management/rpmlint/issues/1076
2023-10-18 08:36:56 +02:00
Daniel Garcia Moreno 224168a7bb descriptions: Add invalid-lc-messages-dir
Add invalid-lc-messages-dir and invalid-locale-man-dir error
descriptions.

Fix https://github.com/rpm-software-management/rpmlint/issues/1123
2023-10-18 08:28:57 +02:00
danigm 78f5077db6
Merge pull request #1125 from rpm-software-management/iso-15924
Add iso_15924 to LANGUAGES
2023-10-16 12:21:09 +02:00
Daniel Garcia Moreno 847c199b34 test: Add some tests for I18NCheck
See https://github.com/rpm-software-management/rpmlint/issues/1124
2023-10-11 10:18:01 +02:00
Daniel Garcia Moreno 4a04aadfb2 Add iso_15924 to LANGUAGES
Fix https://github.com/rpm-software-management/rpmlint/issues/1124
2023-10-11 10:18:01 +02:00
danigm ecdde2757b
Merge pull request #1126 from rpm-software-management/improve-test-framework
Improve test framework
2023-10-11 10:17:03 +02:00
Daniel Garcia Moreno ea3d5852ff pkg: Set default user/group as root for FakePkg files 2023-10-11 09:36:38 +02:00
Daniel Garcia Moreno 92e66b628c pkg: Add linkto parameter to FakePkg files
With this parameter it will be easy to define a FakePkg with symlinks
just using:

files={ '/path/to/link': { 'linkto': '../path/to/file' } }
2023-10-11 09:34:09 +02:00
Daniel Garcia Moreno 1a5aba68e8 pkg: Add filenames to FakePkg headers 2023-10-11 09:33:41 +02:00
Daniel Garcia Moreno 1de5d65060 pkg: Move scriptprog to AbstractPkg
This function will be used also in FakePkg class so it should go to the
AbstractPkg class.
2023-10-11 09:31:45 +02:00
danigm 401cf4eba0
Merge pull request #1119 from rpm-software-management/fix-ci
Use "int" as defaultdict factory instead of lambda
2023-10-09 17:36:54 +02:00
Daniel Garcia Moreno 7073d76f4b Use "int" as defaultdict factory instead of lambda 2023-10-09 14:23:31 +02:00
danigm ddbe9b7cdb
Merge pull request #1115 from rpm-software-management/remove-bintests
test: Replace bin in test_zypp_syntax
2023-10-03 11:54:03 +02:00
Daniel Garcia Moreno 5b1f639611 test: Replace bin in test_zypp_syntax
See https://github.com/rpm-software-management/rpmlint/issues/1105
2023-10-03 11:06:34 +02:00
danigm d50336580b
Merge pull request #1111 from rpm-software-management/fix-format-strings
Fix time report function output string creation
2023-09-18 11:52:46 +02:00
Daniel Garcia Moreno b5e3d85f20 Fix time report function output string creation
The format builtin function receives the format spec as second value,
but the `:` was a mistake from the refactoring done before, those colon
are not correct in the format and produces an Exception.

This patch also introduces a test to avoid regressions.
2023-09-18 11:41:22 +02:00
danigm 2796a9254d
Merge pull request #1108 from rpm-software-management/test-real-files
test: Remove real_files opotional parameter
2023-09-13 09:18:42 +02:00
Daniel Garcia Moreno 3c88388e98 test: Remove real_files opotional parameter
Do not create the FakePkg files could make tests run faster, but it's
safer, and simpler, to just create the files because some checks expects
the files to exists, so it's a better default option.
2023-09-13 09:09:22 +02:00