Commit Graph

872 Commits

Author SHA1 Message Date
bors[bot] ed736b1ac1 Merge #153
153: Restore folding import groups r=matklad a=aochagavia

Closes #133 

Co-authored-by: Adolfo Ochagavía <github@adolfo.ochagavia.xyz>
2018-10-23 13:28:05 +00:00
Adolfo Ochagavía 7ee10b073e Restore folding import groups 2018-10-23 14:58:02 +02:00
bors[bot] 0043d7e9c7 Merge #151
151: Add LspError to explicity return errors from LSP handlers r=matklad a=kjeremy

Fixes #145

Co-authored-by: Jeremy A. Kolb <jkolb@ara.com>
2018-10-23 12:28:57 +00:00
bors[bot] e514084f28 Merge #150
150: Add link to ferrous r=+ a=matklad

@skade just took the logo from the website. Is there a more specific page we want to link to?

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2018-10-22 22:11:44 +00:00
bors[bot] fd7f6beedc Merge #152
152: Fix typo r=matklad a=kjeremy



Co-authored-by: Jeremy A. Kolb <jkolb@ara.com>
2018-10-22 22:00:42 +00:00
bors[bot] 27694abd94 Merge #138
138: Fix some clippy lints r=matklad a=alanhdu

I went ahead and fixed all the clippy lints (there were a couple I thought would be better unfixed and added `cfg` statements to allow them) and also re-enabled clippy and rustfmt in CI.

They were disabled with `no time to explain, disable clippy checks`, so hopefully this won't go against whatever the reason at the time was 😆.

One question about the CI though: right now, it's an allowed failure that runs against the latest nightly each time. Would it be better to pin it to a specific nightly (or use the `beta` versions) to lower the churn?

Co-authored-by: Alan Du <alanhdu@gmail.com>
2018-10-22 21:14:38 +00:00
Jeremy A. Kolb 652afa17ad Fix typo 2018-10-22 13:55:17 -04:00
Jeremy A. Kolb 6453b29cb5 Add LspError to explicity return errors from LSP handlers
Fixes #145
2018-10-22 13:49:27 -04:00
Alan Du dc9ce8ff74 Rename new to new_item (to match new_impl) 2018-10-22 10:50:55 -04:00
Aleksey Kladov 3b7058098b
Add link to ferrous 2018-10-22 15:59:01 +03:00
Aleksey Kladov 5a64b9a811
Merge pull request #149 from killercup/patch-1
Fix a small typo
2018-10-22 10:49:51 +03:00
Pascal Hertleif b774de6e03
Fix typo
Truly an A+, errrr, +a commit
2018-10-21 21:39:50 +02:00
bors[bot] da7adc0c6d Merge #148
148: Don't cache ever changing stuff r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2018-10-20 20:34:34 +00:00
Aleksey Kladov f965cd0c15 Don't cache ever changing stuff 2018-10-20 23:33:45 +03:00
Aleksey Kladov dbe2880219 cleanup 2018-10-20 23:27:06 +03:00
bors[bot] fd336d1134 Merge #147
147: Cancelation r=matklad a=matklad

This series of commits switch cancellation strategy from `JobToken` (which are cancellation tokens, explicitly controlled by the called) to salsa built-in auto cancellation. "Auto" means that, as soon as we advance the revision, all pending queries are cancelled automatically, and this looks like a semantic we actually want. 

"client-side" cancellation is a rare event, and it's ok to just punt on it. Automatic cancellation after the user types something in happens all the time. 

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2018-10-20 20:04:06 +00:00
Aleksey Kladov 0102a01f76 Remove job handle 2018-10-20 22:59:54 +03:00
Aleksey Kladov 8bb4380448 Fix tests 2018-10-20 22:43:36 +03:00
Aleksey Kladov 6e88aaef5d use pythonic import order
use std
// blank line
use extern crates
// blank line
use crate::{}
2018-10-20 22:38:52 +03:00
Aleksey Kladov 8eea10e3ab actually check for cancelation 2018-10-20 22:35:55 +03:00
Aleksey Kladov 71cbdddf1c make file-symbols query cancelable 2018-10-20 22:29:26 +03:00
Aleksey Kladov e74bf6e56e mark module queries as cacelable 2018-10-20 22:15:03 +03:00
Aleksey Kladov 9fb41716de make more things cancelable 2018-10-20 22:09:12 +03:00
Aleksey Kladov 998f2ae762 remove job tokens 2018-10-20 22:02:41 +03:00
Aleksey Kladov c4b0d3cd56 make parent module cancelable 2018-10-20 21:52:49 +03:00
Aleksey Kladov 61518580ed introduce cancelable 2018-10-20 21:46:17 +03:00
Alan Du 0857c22f26 Revert "clippy: Fix new_ret_no_self"
This reverts commit 2ae9dfa812.
2018-10-20 12:29:25 -04:00
Aleksey Kladov 73dd870da2 update salsa 2018-10-20 18:43:02 +03:00
bors[bot] 2ded93a78a Merge #143
143: Implement Find All References and Rename for local variables r=matklad a=kjeremy

Expose `find_all_refs` in `Analysis`. This currently only works for local variables.

Use this in the LSP to implement find all references and rename.

Co-authored-by: Jeremy A. Kolb <jkolb@ara.com>
2018-10-20 12:51:30 +00:00
Jeremy A. Kolb 3de77908eb Update vscode-languageclient package to support RenameOptions 2018-10-19 15:25:43 -04:00
Jeremy A. Kolb 9f9e41885c LSP: Add support for prepareRename 2018-10-19 15:25:10 -04:00
Jeremy A. Kolb 2844c8fdfa Handle renaming of local variables 2018-10-18 17:56:22 -04:00
Jeremy A. Kolb 3746689e9d Implement Find All References for local variables 2018-10-18 13:40:12 -04:00
Alan Du 6dd3fa6a94 clippy: cast_lossless 2018-10-17 19:42:23 -04:00
Alan Du a5da770ec6 Fix function calls 2018-10-17 19:42:23 -04:00
Alan Du fc8024de51 clippy: type_complexity 2018-10-17 19:42:23 -04:00
Alan Du bc774fe6cf clippy: needless_lifetimes 2018-10-17 19:42:23 -04:00
Alan Du 2ae9dfa812 clippy: Fix new_ret_no_self 2018-10-17 19:42:23 -04:00
Alan Du 2268a2f8c6 Silence clippy::derive_hash_xor_eq
Manually implement PartialEq
2018-10-17 19:42:23 -04:00
Alan Du 4e8ea94e2b Remove Copy trait on LeafAtOffset
Because it's a stateful iterator, it's easier to explicitly clone it
when necesary.

Fixes clippy:clone_on_copy
2018-10-17 19:42:23 -04:00
Alan Du d493a4476c clippy: Use if lets and remove redundant returns 2018-10-17 19:42:23 -04:00
Alan Du 5db663d61f Clippy lint: single-character string constant 2018-10-17 19:42:23 -04:00
bors[bot] 4dbf0379cc Merge #141
141: Update rowan r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2018-10-17 16:53:00 +00:00
Aleksey Kladov 00cdde2c52 Update rowan 2018-10-17 19:52:25 +03:00
bors[bot] 2a704035f4 Merge #137
137: rename gen-kinds to gen-syntax r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2018-10-16 18:17:40 +00:00
Aleksey Kladov 2f4a248f80 rename gen-kinds to gen-syntax 2018-10-16 21:17:19 +03:00
bors[bot] 06ab643b00 Merge #136
136: Teraro r=matklad a=matklad



Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2018-10-16 17:54:33 +00:00
Aleksey Kladov b43bcd43c6 fix tests 2018-10-16 20:53:19 +03:00
Aleksey Kladov 0b6d4983de Switch to published teraron 2018-10-16 20:36:45 +03:00
Aleksey Kladov 514aa3cf85 extract teraron 2018-10-16 20:31:30 +03:00