Commit Graph

6533 Commits

Author SHA1 Message Date
Jeremy Stucki 4366137d2e
Update tests 2019-08-14 19:35:17 +02:00
Jeremy Stucki 08f658bc72
Use different span 2019-08-14 19:35:06 +02:00
Jeremy Stucki 214d499103
Add multiline test 2019-08-14 19:34:50 +02:00
bors dbe2bb4256 Auto merge of #4379 - matthiaskrgr:url_dep, r=phansch
update url dependency from 1.7.0 to 2.1.0

changelog: none
2019-08-14 13:07:19 +00:00
bors 06430e7af4 Auto merge of #4363 - phansch:fix_lint_deprecation, r=flip1995
Update lint deprecation for tool lints

changelog: Allow tool lints (`clippy::*`) to be deprecated

Our lint deprecation previously didn't work for tool lints, because
`register_removed` was registering lints to be removed _without_ the
`clippy` prefix.

Fixes #4349
2019-08-14 11:37:10 +00:00
Matthias Krüger 37d79d9a29 update url dependency from 1.7.0 to 2.1.0 2019-08-14 13:04:17 +02:00
bors 63d2d066f9 Auto merge of #4369 - mikerite:fix-4293, r=flip1995
Fix `wrong_self_convention` issue

Resolves #4293

changelog: Fix `wrong_self_convention` issue
2019-08-14 10:59:36 +00:00
bors 4f8bdf3587 Auto merge of #4231 - jeremystucki:flat-map, r=flip1995
Implement flat_map lint

Fixes #4224

changelog: New Lint `flat_map_identity` to detect unnecessary calls to `flat_map`
2019-08-14 09:36:16 +00:00
bors 36f7faee05 Auto merge of #4378 - flip1995:ui-toml, r=flip1995
Update ui-toml tests

changelog: none
2019-08-14 08:54:07 +00:00
flip1995 17808c7d00
Update ui-toml tests 2019-08-14 09:58:00 +02:00
Jeremy Stucki 2bfcf89f82
Merge branch 'origin/master' into flat-map 2019-08-14 07:36:37 +02:00
Jeremy Stucki 2fe5e2cea9
Update test 2019-08-13 21:50:52 +02:00
Jeremy Stucki d578c43c51
Use correct span 2019-08-13 21:50:42 +02:00
Jeremy Stucki 6a263c0816
Add 'unnecessary_flat_map.fixed' 2019-08-13 08:03:04 +02:00
Jeremy Stucki 4275d7b6ac
Run 'update_lints' 2019-08-12 21:47:12 +02:00
Jeremy Stucki d51136d594
Use 'span_lint_and_sugg' 2019-08-12 21:42:57 +02:00
Jeremy Stucki 3a65e4e75a
Minor refactoring 2019-08-12 21:29:33 +02:00
Philipp Hansch e406ab5117
Add deprecation tests for deprecated tool lints 2019-08-12 19:42:23 +02:00
Philipp Hansch 0d0db5ed5f
Move old lint deprecation tests to deprecated_old.rs 2019-08-12 19:42:23 +02:00
Philipp Hansch b50c13c578
Fix invalid_ref deprecation 2019-08-12 19:42:23 +02:00
Philipp Hansch 0b7e2376c8
Keep old deprecated lints deprecated as non-tool, too 2019-08-12 19:42:23 +02:00
Philipp Hansch 5114050839
Update lint deprecation for tool lints
Our lint deprecation previously didn't work for tool lints, because
`register_removed` was registering lints to be removed _without_ the
`clippy` prefix.
2019-08-12 19:20:36 +02:00
bors c154754b74 Auto merge of #4373 - flip1995:filter_changelog_none, r=phansch
Filter out PRs with changelog: none

cc #4372

Filtering out the `changelog: none` merge commits, to unclutter the output.

changelog: none
2019-08-12 11:05:49 +00:00
Jeremy Stucki 09e9568c26
Change lint type from 'pedantic' → 'complexity' 2019-08-12 10:53:23 +02:00
flip1995 27ddde561e
Filter out PRs with changelog: none 2019-08-12 09:38:52 +02:00
Jeremy Stucki 6ddf8c36d7
Run 'update_lints' 2019-08-12 07:53:22 +02:00
bors e255f36afe Auto merge of #4365 - lukas-code:async_new_ret_no_self, r=flip1995
new_ret_no_self: allow Self in inner type for impl Trait return types

Check the inner types of associated types of a trait when checking for Self in the return type of a `new` method. This means that the following will no longer warn:
```rust
trait Trait {
    type Inner;
}

struct S;

impl S {
    fn new() -> impl Trait<Inner = Option<Self>> {
        struct TraitImpl;

        impl Trait for TraitImpl {
            type Inner = Option<S>;
        }

        TraitImpl
    }
}
```
```rust
#![feature(async_await)]

struct Connection;

impl Connection {
    async fn new() -> Result<Self, ()> {
        Ok(S)
    }
}
```
closes #4359

changelog: fix `new_ret_no_self` lint for async `new` functions.
2019-08-12 05:15:16 +00:00
bors ed1de3d377 Auto merge of #4367 - flip1995:doc_edition_2018_tests, r=phansch
Document how to write tests requiring the 2018 edition

[Rendered](https://github.com/flip1995/rust-clippy/blob/doc_edition_2018_tests/doc/adding_lints.md#Edition-2018-tests)

cc #4365

changelog: none
2019-08-12 04:38:50 +00:00
Jeremy Stucki df9063013e
Update rustdoc 2019-08-11 22:18:58 +02:00
Jeremy Stucki 5fd7d44f36
Refactor if_chain
Co-authored-by: Philipp Krones <hello@philkrones.com>
2019-08-11 21:02:01 +02:00
bors 7a0ac4c25d Auto merge of #4370 - vallentin:master, r=flip1995
Fixed repeated word

changelog: none
2019-08-11 18:42:16 +00:00
Jeremy Stucki b651f19eb8
Rename 'flat_map' → 'flat_map_identity' 2019-08-11 20:34:25 +02:00
Jeremy Stucki f0ce04f814
Handle calls with 'std::convert::identity' 2019-08-11 19:51:43 +02:00
Jeremy Stucki 05d9f884e1
Merge branch 'origin/master' into flat-map 2019-08-11 19:22:40 +02:00
Vallentin b7460ad70b Fixed repeated word 2019-08-11 12:56:30 +02:00
bors 72da1015d6 Auto merge of #4368 - RalfJung:invalid_ref, r=oli-obk
deprecate invalid_ref lint

This fixes the `invalid_ref` lint test to no longer fail when https://github.com/rust-lang/rust/pull/63346/ lands.  I also fixed the lint itself, because its wording made no sense: there is no "reference to zeroed/uninitialized memory" here.

changelog: none
2019-08-11 09:08:22 +00:00
Ralf Jung 40fea7a9e0 update_lints 2019-08-11 11:02:25 +02:00
Ralf Jung 2dcce60fdc deprecate invalid_ref lint 2019-08-11 09:31:55 +02:00
Michael Wright 77278ccda9 Fix `wrong_self_convention` issue
Resolves #4293
2019-08-10 06:01:15 +02:00
Michael Wright 170d4861c6 Simplify `wrong_self_convention` code
Use actual types instead of hir types.
2019-08-10 06:00:27 +02:00
Michael Wright ebd24985bf Rename implitem to impl_item
`impl_item` is proper snake case and used everywhere else.
2019-08-10 05:58:52 +02:00
Lukas Markeffsky d55315808d fixed tests (again) and added a test that should actually cause a warning for new_ret_no_self 2019-08-09 23:15:49 +02:00
Lukas Markeffsky 54efffcec1 removed unused imports #2 2019-08-09 19:47:25 +02:00
Lukas Markeffsky 1d2c23a2a5 removed unused imports 2019-08-09 19:44:20 +02:00
Lukas Markeffsky 4fbe9f67ee upgrade test to rust 2018 2019-08-09 19:19:49 +02:00
flip1995 99d1cde8d8
Document how to write tests requiring the 2018 edition 2019-08-09 19:14:59 +02:00
Lukas Markeffsky d7b9a845aa new_ret_no_self: walk associated types in impl Trait return types 2019-08-09 17:44:05 +02:00
bors c55d38ed7a Auto merge of #4362 - lzutao:expect-on-cstring_as_ptr, r=flip1995
Fix lint_cstring_as_ptr for expect

Closes #4312
changelog: none
2019-08-09 09:22:02 +00:00
bors 26a1e532e6 Auto merge of #4361 - lzutao:fix-raw-string-on-single_char_pattern, r=phansch
Fix lint_single_char_pattern on raw string literal

Closes #4356
changelog: Handle raw string literal on `single_char_literal` lint.
2019-08-09 07:58:39 +00:00
Lzu Tao b825cddb6d Add more tests for raw string literal 2019-08-09 06:22:26 +00:00