Commit Graph

13325 Commits

Author SHA1 Message Date
Sven Neumann e2d8f7e48d make the "Save EXIF data" toggle insensitive when no EXIF data is present
2004-09-13  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/jpeg.c (save_dialog): make the "Save EXIF data"
	toggle insensitive when no EXIF data is present (bug #140042).

	* app/display/gimpdisplayshell-close.c: as suggested by the HIG,
	ask the user to save the image when the last display is being
	closed. Addresses some issues raised in bug #106726.
2004-09-13 21:58:27 +00:00
Michael Natterer 359303a796 install the message handler for the "Gimp-Dialogs" domain.
2004-09-13  Michael Natterer  <mitch@gimp.org>

	* app/app_procs.c (app_run): install the message handler for the
	"Gimp-Dialogs" domain.
2004-09-13 20:00:19 +00:00
Michael Natterer e93af81c53 resurrected file_open_dialog_show() and file_save_dialog_show() as private
2004-09-13  Michael Natterer  <mitch@gimp.org>

	* app/actions/file-commands.c: resurrected file_open_dialog_show()
	and file_save_dialog_show() as private utility functions to get
	rid of code duplication.
2004-09-13 19:33:07 +00:00
Michael Natterer 0a8523a828 forgot to mention fixed bug. 2004-09-13 16:39:04 +00:00
Michael Natterer 582a096604 app/dialogs/Makefile.am removed these files.
2004-09-13  Michael Natterer  <mitch@gimp.org>

	* app/dialogs/Makefile.am
	* app/dialogs/file-dialog-utils.[ch]: removed these files.

	* app/dialogs/file-save-dialog.[ch]: removed functions
	file_save_dialog_show() and file_save_a_copy_dialog_show() and
	changed internal function file_save_dialog_create() to
	file_save_dialog_new().

	* app/dialogs/dialogs.c
	* app/dialogs/dialogs-constructors.[ch]: made it completely
	managed by the dialog factory.

	* app/actions/file-commands.c: create it using the dialog
	factory. Attach it to the image so we open only one save
	dialog per image.

	* app/dialogs/file-open-dialog.c: added precondition checks
	to file_open_dialog_new().
2004-09-13 16:37:01 +00:00
Sven Neumann 2449510d5b some code cleanup.
2004-09-13  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/jpeg.c: some code cleanup.
2004-09-13 16:29:59 +00:00
Michael Natterer 593e98c6de removed function file_open_dialog_show() and changed internal function
2004-09-13  Michael Natterer  <mitch@gimp.org>

	* app/dialogs/file-open-dialog.[ch]: removed function
	file_open_dialog_show() and changed internal function
	file_open_dialog_create() to file_open_dialog_new().

	* app/dialogs/dialogs.c
	* app/dialogs/dialogs-constructors.[ch]: made it completely
	managed by the dialog factory.

	* app/actions/file-commands.c: create it using the dialog factory.
2004-09-13 16:01:52 +00:00
Michael Natterer a7e5ebef55 eek 2004-09-13 15:22:58 +00:00
Michael Natterer 7d065360c7 configure.in added new directory app/dialogs and link libappdialogs.c into
2004-09-13  Michael Natterer  <mitch@gimp.org>

	* configure.in
	* app/Makefile.am: added new directory app/dialogs and link
	libappdialogs.c into the gimp binary.

	* app/gui/Makefile.am
	* app/gui/gui-types.h
	* app/gui/gui-vtable.c
	* app/gui/gui.c

	* app/gui/about-dialog.[ch]
	* app/gui/authors.h
	* app/gui/color-notebook.[ch]
	* app/gui/convert-dialog.[ch]
	* app/gui/dialogs-constructors.[ch]
	* app/gui/dialogs.[ch]
	* app/gui/file-dialog-utils.[ch]
	* app/gui/file-new-dialog.[ch]
	* app/gui/file-open-dialog.[ch]
	* app/gui/file-open-location-dialog.[ch]
	* app/gui/file-save-dialog.[ch]
	* app/gui/grid-dialog.[ch]
	* app/gui/info-dialog.[ch]
	* app/gui/info-window.[ch]
	* app/gui/module-browser.[ch]
	* app/gui/offset-dialog.[ch]
	* app/gui/palette-import-dialog.[ch]
	* app/gui/preferences-dialog.[ch]
	* app/gui/quit-dialog.[ch]
	* app/gui/resize-dialog.[ch]
	* app/gui/resolution-calibrate-dialog.[ch]
	* app/gui/stroke-dialog.[ch]
	* app/gui/tips-dialog.[ch]
	* app/gui/tips-parser.[ch]
	* app/gui/user-install-dialog.[ch]: removed these files...

	* app/dialogs/Makefile.am
	* app/dialogs/dialogs-types.h

	* app/dialogs/*.[ch]: ...and added them here. Changed some
	filenames like module-browser -> module-dialog.

	* app/app_procs.c
	* app/actions/actions-types.h
	* app/actions/actions.c
	* app/actions/dialogs-actions.c
	* app/actions/dialogs-commands.c
	* app/actions/dockable-commands.c
	* app/actions/drawable-commands.c
	* app/actions/edit-commands.c
	* app/actions/file-commands.c
	* app/actions/gradient-editor-commands.c
	* app/actions/image-commands.c
	* app/actions/layers-commands.c
	* app/actions/palettes-commands.c
	* app/actions/select-commands.c
	* app/actions/templates-commands.c
	* app/actions/templates-commands.h
	* app/actions/vectors-commands.c
	* app/actions/view-commands.c
	* app/display/gimpdisplayshell-cursor.c
	* app/display/gimpdisplayshell-title.c
	* app/display/gimpdisplayshell.[ch]
	* app/tools/gimpcroptool.c
	* app/tools/gimpperspectivetool.c
	* app/tools/gimprotatetool.c
	* app/tools/gimpscaletool.c
	* app/tools/gimpsheartool.c
	* app/tools/gimptransformtool.[ch]
	* app/tools/gimpvectortool.c
	* app/widgets/gimpcolormapeditor.[ch]
	* app/widgets/gimpcolorpanel.c
	* app/widgets/gimpgradienteditor.[ch]
	* app/widgets/gimppaletteeditor.[ch]
	* app/widgets/gimptoolbox-color-area.c
	* menus/toolbox-menu.xml.in
	* tools/authorsgen/authorsgen.pl: changed accordingly.
2004-09-13 15:15:23 +00:00
Michael Natterer 95da4fd6a6 dialog sources were moved to app/dialogs/.
2004-09-13  Michael Natterer  <mitch@gimp.org>

	* POTFILE.in: dialog sources were moved to app/dialogs/.
2004-09-13 15:14:53 +00:00
Michael Natterer 4f6f5316eb Restore binary compatibility of the wire protocol that was broken by the
2004-09-13  Michael Natterer  <mitch@gimp.org>

	Restore binary compatibility of the wire protocol that was
	broken by the recent GPConfig changes:

	* libgimpbase/gimpprotocol.[ch] (struct _GPConfig)
	(_gp_config_read)
	(_gp_config_write): argh, we can't use the two bytes padding
	because that's just a binary compatible struct change, but inserts
	two bytes into the byte stream that goes over the wire. Use the
	first two bytes of the former "gdouble gamma" instead.

	* app/plug-in/plug-in-run.c (plug_in_run)
	* libgimp/gimp.c (gimp_config): changed accordingly.
2004-09-13 13:33:56 +00:00
Sven Neumann 952cd37e00 simulate the behaviour of GNU gettext and look at the LANGUAGE environment
2004-09-13  Sven Neumann  <sven@gimp.org>

	* app/widgets/gimphelp.c: simulate the behaviour of GNU gettext and
	look at the LANGUAGE environment variable if the locale is not "C".
2004-09-13 12:19:34 +00:00
Simon Budig c07125554a Fix trailing whitespace introduced by me. /me hides embarrassed in a
2004-09-13  Simon Budig  <simon@gimp.org>

	* app/tools/gimpcroptool.c: Fix trailing whitespace introduced by me.
	/me hides embarrassed in a corner...   :)
2004-09-13 12:02:06 +00:00
Simon Budig ef206e7fd2 Fix warnings and coding style.
2004-09-13  Simon Budig  <simon@gimp.org>

	* app/tools/gimpcroptool.c: Fix warnings and coding style.
2004-09-13 10:10:43 +00:00
Nathan Summers 8be9e2b2be disable crop and resize buttons while the operation is being processed.
2004-09-12  Nathan Summers  <rock@gimp.org>

        * app/tools/gimpcroptool.c: disable crop and resize buttons while the
	operation is being processed.  Fixes #152372.
2004-09-13 01:45:45 +00:00
Sven Neumann 6c2aa00188 use a combo box for format selection.
2004-09-12  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/aa.c (aa_dialog): use a combo box for format
	selection.
2004-09-12 21:29:46 +00:00
Sven Neumann 835e591286 fixed gtk-doc comments, removed trailing whitespace.
2004-09-12  Sven Neumann  <sven@gimp.org>

	* libgimp/gimppixelrgn.c: fixed gtk-doc comments, removed trailing
	whitespace.
2004-09-12 12:23:50 +00:00
David Odin 91836bfce4 some more fixes by nomis.
* libgimp/gimppixelrgn.c: some more fixes by nomis.
2004-09-12 00:00:38 +00:00
David Odin cd03397ffa nomis helped me to make some correction to the documentation.
* libgimp/gimppixelrgn.c: nomis helped me to make some correction to
  the documentation.
2004-09-11 23:43:38 +00:00
David Odin 41a86d046b more documentation.
* libgimp/gimppixelrgn.c: more documentation.
2004-09-11 23:05:56 +00:00
David Odin 35cb43787b added a default value (TRUE) for the update_preview toggle.
* plug-ins/common/edge.c: added a default value (TRUE) for the
  update_preview toggle.

* plug-ins/common/wind.c: ported to GimpPreviewArea, so the preview is
  much more useful now.
2004-09-11 21:39:36 +00:00
David Odin e5be3aa6dc added some gtk-doc documentation to pixel region related functions. (work
* libgimp/gimppixelrgn.c: added some gtk-doc documentation to pixel
  region related functions. (work in progress)
2004-09-11 20:04:29 +00:00
Simon Budig 4a75d7271e Added boolean parameter to gimp_dialog_factories_toggle to make it
2004-09-11  Simon Budig  <simon@gimp.org>

	* app/widgets/gimpdialogfactory.[ch]: Added boolean parameter to
	gimp_dialog_factories_toggle to make it possible to ensure a visible
	toolbox.

	* app/actions/dialogs-commands.c: Use the new parameter to ensure
	toolbox visibility after the last image window closes.

	* app/display/gimpdisplayshell-callbacks.c: Changed accordingly.

	Fixes bug #137057 (the discussion is in bug #152285)
2004-09-11 19:19:26 +00:00
David Odin 004a5e0cd8 ported to GimpPreviewArea. 100 less lines of code and much more features!
* plug-ins/common/edge.c: ported to GimpPreviewArea. 100 less lines of
  code and much more features!
2004-09-11 19:11:04 +00:00
David Odin 9f0842f021 some code cleanup and small optimisations.
* plug-ins/common/oilify.c: some code cleanup and small optimisations.
2004-09-11 15:29:30 +00:00
Sven Neumann 94d0dfb6b3 fixed spelling.
2004-09-10  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/xpm.c (query): fixed spelling.
2004-09-10 17:00:28 +00:00
William Skaggs fe876df0ed Bill Skaggs <weskaggs@primate.ucdavis.edu>
* app/widgets/gimperrorconsole.c: fix typo
2004-09-10 15:38:17 +00:00
Michael Natterer 6b4f7b3955 untabified, removed useless inclusion of <gdk/gdkkeysyms.h>.
2004-09-10  Michael Natterer  <mitch@gimp.org>

	* libgimpwidgets/gimpcolorselect.c: untabified, removed useless
	inclusion of <gdk/gdkkeysyms.h>.
2004-09-10 13:16:55 +00:00
Sven Neumann a840af33ea ported to GimpPreviewArea. Destroy the GdkGC in unrealize() instead of in
2004-09-10  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimpcolorselect.c: ported to GimpPreviewArea.
	Destroy the GdkGC in unrealize() instead of in finalize().
2004-09-10 13:04:45 +00:00
Michael Natterer 4b553f186c always call gdk_drag_status() before returning FALSE.
2004-09-10  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpcontainertreeview-dnd.c
	(gimp_container_tree_view_drop_status): always call
	gdk_drag_status() before returning FALSE.

	(gimp_container_tree_view_drag_motion): never return FALSE, an
	impossible drop location is now reported by calling
	gdk_drag_status() above. Always returning TRUE makes sure
	gimp_container_tree_view_drag_leave() is called unconditionally
	and can remove the scroll_timeout set in drag_motion().

	Fixes bug #152193 and many other obscure DND crashes caused by the
	scroll_timeout being invoked after the widget is destroyed.
2004-09-10 12:20:16 +00:00
Sven Neumann 8f3ea939a8 improved PDB blurb and help. Very loosely based on a patch attached to bug
2004-09-10  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/xpm.c: improved PDB blurb and help. Very loosely
	based on a patch attached to bug #151912.
2004-09-10 12:05:00 +00:00
Sven Neumann b6cc80e154 tools/pdbgen/pdb/drawable.pdb corrected documentation for
2004-09-10  Sven Neumann  <sven@gimp.org>

	* tools/pdbgen/pdb/drawable.pdb
	* tools/pdbgen/pdb/image.pdb: corrected documentation for
	_gimp_drawable_thumbnail() and _gimp_image_thumbnail().

	* app/pdb/drawable_cmds.c
	* app/pdb/image_cmds.c
	* libgimp/gimpdrawable_pdb.c
	* libgimp/gimpimage_pdb.c: regenerated.

	* libgimp/gimpdrawablepreview.c (gimp_drawable_preview_draw_thumb):
	also handle GRAY and GRAYA thumbnails.
2004-09-10 09:30:06 +00:00
Sven Neumann 6a824465f5 fixed positioning of the navigation marker and handling of motion events.
2004-09-10  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimppreview.c: fixed positioning of the
	navigation marker and handling of motion events.
2004-09-10 09:02:19 +00:00
Sven Neumann e9d5536720 libgimpwidgets/gimppreview.c documented new functions.
2004-09-10  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimppreview.c
	* libgimpwidgets/gimppreviewarea.c: documented new functions.
2004-09-09 22:36:15 +00:00
Sven Neumann cf9e2368eb improved handling of motion events in navigation popup 2004-09-09 21:39:08 +00:00
Sven Neumann 025e58a12d libgimp/gimpdrawablepreview.c added a navigation popup similar to the one
2004-09-09  Sven Neumann  <sven@gimp.org>

	* libgimp/gimpdrawablepreview.c
	* libgimpwidgets/gimppreview.[ch]: added a navigation popup
	similar to the one in the image window. Needs some more work.
2004-09-09 21:36:52 +00:00
Sven Neumann 8a80b8e73e fixed coding style issues 2004-09-09 17:13:58 +00:00
David Odin 3f099b0660 added a utility function gimp_preview_area_queue_draw(), which queue the
* libgimpwidgets/gimppreviewarea.c: added a utility function
  gimp_preview_area_queue_draw(), which queue the right part of the
  preview to be redrawn. And use it in all the drawing functions. This
  fix a problem where the preview wasn't updated correctly after a
  resize.
2004-09-09 17:11:16 +00:00
Michael Natterer 094909cd8a plug-ins/common/cartoon.c plug-ins/common/despeckle.c
2004-09-09  Michael Natterer  <mitch@gimp.org>

	* plug-ins/common/cartoon.c
	* plug-ins/common/despeckle.c
	* plug-ins/common/gauss.c
	* plug-ins/common/grid.c
	* plug-ins/common/neon.c
	* plug-ins/common/noisify.c
	* plug-ins/common/photocopy.c
	* plug-ins/common/sel_gauss.c
	* plug-ins/common/sharpen.c
	* plug-ins/common/sobel.c
	* plug-ins/common/softglow.c
	* plug-ins/common/spread.c
	* plug-ins/common/struc.c
	* plug-ins/common/unsharp.c: pack all drawable previews expanding.
	Also did some general cleanups like consistently naming the dialog
	variable "dialog" and the main vbox "main_vbox".
2004-09-09 16:08:56 +00:00
Sven Neumann b3c30779a0 right-align the preview for RTL layouts.
2004-09-09  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimppreview.[ch]: right-align the preview for RTL
	layouts.
2004-09-09 15:27:34 +00:00
Sven Neumann a514ce7db1 allow to set a maximum size and center the preview area if its allocation
2004-09-09  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimppreviewarea.[ch]: allow to set a maximum size
	and center the preview area if its allocation extends the maximum.

	* libgimpwidgets/gimppreview.[ch]: derive from GtkVBox, moved the
	toggle button out of the table and put the table into an aspect
	frame. Added an API to set the preview boundaries. Set the maximum
	size of the GimpPreviewArea from that function.

	* libgimpwidgets/gimpwidgets.def: added new entries.

	* libgimp/gimpdrawablepreview.c: use gimp_preview_set_bounds().

	* plug-ins/common/gauss.c: pack the preview widget so that it
	resizes with the dialog.
2004-09-09 14:47:39 +00:00
David Odin 824b5289db optimized the case where both buffers have the same alpha for a given
* libgimpwidgets/gimppreviewarea.c (gimp_preview_area_blend)
  (gimp_preview_area_mask): optimized the case where both buffers have
  the same alpha for a given pixel.
2004-09-09 13:22:27 +00:00
Michael Natterer fa3f37e96e app/widgets/gimpviewrendererbrush.c app/widgets/gimpviewrendererdrawable.c
2004-09-09  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpviewrendererbrush.c
	* app/widgets/gimpviewrendererdrawable.c
	* app/widgets/gimpviewrenderergradient.c
	* app/widgets/gimpviewrendererimage.c
	* app/widgets/gimpviewrendererimagefile.c
	* app/widgets/gimpviewrendererlayer.c
	* app/widgets/gimpviewrenderervectors.c: purely cosmetic cleanup.
2004-09-09 11:58:49 +00:00
Michael Natterer d7fc14fbc8 use g_type_name(dialog_type) instead of just "pdb dialog" as name for the
2004-09-09  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimppdbdialog.c (gimp_pdb_dialog_constructor): use
	g_type_name(dialog_type) instead of just "pdb dialog" as name for
	the dialog's private context.
2004-09-09 11:48:45 +00:00
Michael Natterer 04b784ec43 fixed #include i broke with last commit. 2004-09-09 11:46:57 +00:00
Michael Natterer 09536dbf37 changed GimpDisplay* parameter to GimpProgress* because that's what it's
2004-09-09  Michael Natterer  <mitch@gimp.org>

	* app/gui/convert-dialog.[ch] (convert_dialog_new): changed
	GimpDisplay* parameter to GimpProgress* because that's what it's
	used for.

	* app/actions/image-commands.c (image_convert_cmd_callback):
	changed accordingly.

	* app/gui/convert-dialog.c: massively cleaned up internals. Use a
	GimpViewableButton + GimpContainerEntry combo as in text options
	for selecting the custom palette. Use a filtered container which
	contains only palettes with a maximum of 256 colors.
	Fixes bug #136574
2004-09-09 11:42:39 +00:00
Michael Natterer ff6ee61780 changed file_open_location_dialog_show() to
2004-09-09  Michael Natterer  <mitch@gimp.org>

	* app/gui/file-open-location-dialog.[ch]: changed
	file_open_location_dialog_show() to
	file_open_location_dialog_new() and return the dialog.

	* app/gui/dialogs.c
	* app/gui/dialogs-constructors.[ch]: added a constructor for it
	and let the dialog factory manage it entirely.

	* app/actions/file-commands.c
	(file_open_location_dialog_cmd_callback): use the dialog factory
	to create it.
2004-09-09 09:47:33 +00:00
Michael Natterer abf395c0cd renamed parameter "gboolean raise_if_found" to "return_existing" and added
2004-09-09  Michael Natterer  <mitch@gimp.org>

	* app/widgets/gimpdialogfactory.c
	(gimp_dialog_factory_dialog_new_internal): renamed parameter
	"gboolean raise_if_found" to "return_existing" and added
	additional parameter "gboolean present".

	(gimp_dialog_factory_dialog_new)
	(gimp_dialog_factory_dialog_raise)
	(gimp_dialog_factory_dockable_new): pass both parameters (passing
	"present" as "raise_if_found" was not quite correct).
2004-09-09 09:02:26 +00:00
David Odin ee2e6eac86 fixed a stupid typo.
* libgimpwidgets/gimppreviewarea.c: fixed a stupid typo.
2004-09-08 14:51:02 +00:00
Sven Neumann 7f075c87d8 optimized solid color fills.
2004-09-08  Sven Neumann  <sven@gimp.org>

	* libgimpwidgets/gimppreviewarea.c (gimp_preview_area_fill):
	optimized solid color fills.
2004-09-08 12:54:36 +00:00