Commit Graph

26740 Commits

Author SHA1 Message Date
Martin Nordholts b5defd4e4a app: Add GIMP_LOG_FLOATING_SELECTION domain
Add GIMP_LOG_FLOATING_SELECTION domain to get rid of the somewhat
annoying debug prints. Floating selection is likely to require further
debuggin later on, so instead of just removing the output, use
GIMP_LOG for it.
2010-01-02 23:41:52 +01:00
Martin Nordholts 86e14c2c2f app/tests: Add a GIMP 2.8 XCF feature test template
Add template code for writing a test that makes sure GIMP 2.8 images
do not lose information when written to a file and loaded again, in
hope that mitch will fill in the rest ;)
2010-01-02 23:30:14 +01:00
Martin Nordholts 19183f81b2 app/tests: Test loading of an XCF file created with GIMP 2.6
Do a basic regression test on being able to load XCF files created
with GIMP 2.6. To add things to this file, add things to
gimp_write_and_read_file() and run the code in GIMP 2.6.

Also add a file-local helper function gimp_test_load_image().
2010-01-02 23:16:55 +01:00
Martin Nordholts f86f9e2adf app/tests: Sort TESTS in Makefile.am 2010-01-02 23:10:54 +01:00
Martin Nordholts 745d2dbf76 app/tests: Add a "gimp-comment" with an explanation of the file
Make it clear that the file is created from pure code execution and
not graphically with GIMP.
2010-01-02 23:09:21 +01:00
Martin Nordholts 0724959b61 app/tests: Make channel same size as image in XCF test
In order to avoid crashes when rending the image, make the channel the
same size as the image.
2010-01-02 23:06:57 +01:00
Martin Nordholts 69f28be91c app: Remove unused variable 'hardness' in paint/gimpbrushcore.c 2010-01-02 20:36:59 +01:00
Martin Nordholts c380512ce1 Revert "app: Add gimp_vectors_get_stroke()"
This reverts commit 2d2b6f03c5 and
adapts the code. We can use gimp_vectors_stroke_get_next (vectors,
NULL) instead of gimp_vectors_get_stroke (vectors, 0). Thanks to nomis
for pointing this out.
2010-01-02 20:20:10 +01:00
Martin Nordholts 3e81e87bca app/tests: Improve code coverage and test names in XCF test
Add another layer, a channel, a selection and two vectors to the test
image. Parameterize the image construction so we can create different
variants of test images, and add a test for an "unusual" GimpImage,
which is an image with compatible vectors and with a floating
selection. The test are renamed to something with "GIMP 2.6" to
emphasize that the tests work with files that might as well have been
constructed with GIMP 2.6. Also adjust the list of things that should
be tested, but that isn't tested yet.

FWIW, using the GNU gcc gcov tool it can be seen that xcf-load.c now
has a code coverage of 67.04% of 722 lines.
2010-01-02 18:55:44 +01:00
Martin Nordholts 2d2b6f03c5 app: Add gimp_vectors_get_stroke() 2010-01-02 18:55:44 +01:00
Michael Natterer 3014d8d81d tools: fix typo in help text: libgumpui -> libgimpui 2010-01-01 18:48:20 +01:00
Alexia Death bdec911bfc app: Fix a mixing quirk in linear dynamics mixing
Angular dynamics could have resulted in a value > 1 giving unexpected results with hardness.
2010-01-01 19:03:59 +02:00
Alexia Death 2c4c9ad333 app: Clean up the hardness feature. Lets convolve PixelRegions. 2010-01-01 18:16:29 +02:00
Alexia Death 9774988f30 Real dynamic hardness support for both generated and pixmap brushes.
For generated brushes, dynamic input is applied on top of the set hardness as a factor.
For pixmaps, it influences the amount of blur applied to the stamp. Be warned, process is slow
for large pixmaps. The odd feature previously advertised as hardness is left in but disabled.
If I figure out what it should be exposed as, it might be made available again.
2010-01-01 15:54:31 +02:00
Michael Natterer 37b6a205d3 app: change the way the operation for layer compositing is determined
By default, get the operation from gimp_layer_mode_to_gegl_operation()
and special-case all modes except from "normal", so the special cases
actually become less as the new operations are filled with code.
2009-12-30 18:01:09 +01:00
Sven Neumann b9b1cbe00e comment out debug output from tag-cache 2009-12-30 16:39:35 +01:00
Michael Natterer 9f6827be7c app: add back individual operation classes for the layer modes
They are derived from GimpOperationPointLayerMode and are completely
empty and unused, but can be filled with code and enabled one-by-one
now.
2009-12-30 15:22:35 +01:00
Michael Natterer a58e7ee918 app: add .libs to .gitignore 2009-12-30 15:22:35 +01:00
Alexia Death 9b4ff636ed app: Fix typo in event history option blurb noticed by Mikael Magnusson 2009-12-30 16:03:11 +02:00
Alexia Death e79834b75e app: Fix garbage appearing in generated brushes with dynamic angles
Rounds angle used in generated brushes to avoid floating point precision problems.
2009-12-30 15:10:34 +02:00
Alexia Death c5b4643d69 Revert "app: Fix garbage appearing in 1:1 apect ratio 2 spike generated brushes"
This reverts commit 54844e8ab8.
An unneded pseudofix. Proper fix will be commited soon.
2009-12-30 13:21:26 +02:00
Omari Stephens 11f094f565 plug-ins/pygimp: Minor style cleanup for readability
Use all the same quotation marks (", not '), switch from string slicing to
.startswith(), and fix and indentation mishap.
2009-12-29 12:52:49 +01:00
Michael Natterer bb852184e1 app: pass the drop_path to GimpContainerTreeView::drop_possible()
Together with some more refactoring, this will soon enable smarter
layer group dnd behavior.
2009-12-28 21:10:04 +01:00
Michael Natterer 3d9f9124f3 app: formatting 2009-12-28 21:07:38 +01:00
Michael Natterer 79c4023552 app: inline the inner curve mapping function for internal use
Makes gegl-curves about 1/3 faster for a simple case where only
the "value" curve was changed. The speedup should be better when
multiple curves are changed from the identity mapping.
2009-12-28 20:50:26 +01:00
Martin Nordholts 14ca90ac2f app/tests: Clean up test-ui.c a bit 2009-12-28 11:00:40 +01:00
Sven Neumann a3a8cf16c0 add libgimpapptestutils.a to .gitignore 2009-12-27 19:47:14 +01:00
Sven Neumann f0348aff40 some minor code cleanups 2009-12-27 13:28:14 +01:00
Roman Joost 3749f2c62c Revamped the GimpXmpModelEntry object initialisation.
It is now possible to create an entry widget by using g_object_new and
provide three parameters: the schema_uri, the property name you want to
subscribe and an instance of an xmp-model.
2009-12-27 10:03:30 +01:00
Roman Joost 1c8255de59 Code cleanup.
I changed the name of the GimpXMPModelEntry, which reads now better as
GimpXmpModelEntry. I removed functions in the interface, which are not
in use anymore, because of the code improvements in the entry widget and
the XMPModel. The new entry widget is not build as a library anymore.
2009-12-27 10:03:28 +01:00
Roman Joost 9578088ce8 Set the correct icons if the entry changed a property in the XMPModel and use the new EntryWidget for the caption writer as well. 2009-12-27 10:03:26 +01:00
Roman Joost 3705c85e1e Implemented better signal handling for property-changed events.
The XMPModel listens now on the row-changed event and checks if the row
belong to a property or schema change. If a property change occured a
detailed property-changed signal is emitted. A detailed schema-changed
signal is currently not emitted, because not implemented.
2009-12-27 10:03:23 +01:00
Roman Joost a13e4692fb Registered new GimpXMPModelEntry, connected it with the XMPModel.
The new entry widget now makes use of the detailed signal from the
XMPModel.
2009-12-27 10:03:19 +01:00
Alexia Death 54844e8ab8 app: Fix garbage appearing in 1:1 apect ratio 2 spike generated brushes 2009-12-27 00:27:29 +02:00
Sven Neumann 345bbfe475 app: adjust wording and spelling in error messages 2009-12-26 20:46:19 +01:00
Michael Natterer 105b7c5afa app: fix mapping for CURVE_BLUE (use the blue, not the green curve) 2009-12-26 14:10:31 +01:00
Martin Nordholts 780ebd7c24 app/tests: Fix warnings about files not existing
Let each test sets GIMP2_DIRECTORY on their own through the help of a
new test utility function gimp_test_utils_set_gimp2_directory() that
is compiled into its own lib which tests are then linked with. Also,
instead of using "/tmp/gimpdir", we use "gimpdir-empty" in the source
dir. This way we get rid of a bunch of annoying warnings when running
the tests and have more control.
2009-12-24 23:01:48 +01:00
Martin Nordholts 47709fab18 app/tests: Use implicit _SOURCES 2009-12-24 18:54:11 +01:00
Martin Nordholts 999fb38164 app/tests: Create brushes, gradients and patterns dirs in gimpdir
Create brushes, gradients and patterns dirs in gimpdir to get rid of
warnings for those dirs not existing.
2009-12-24 18:15:43 +01:00
Martin Nordholts 1e89d01417 app/tests: Run main loop until idle instead of for a given time
Use gimp_test_run_mainloop_until_idle() instead of
gimp_test_run_temp_mainloop () since we then don't have to wait for a
timeout, we only wait the minimal amount of time.
2009-12-24 17:50:39 +01:00
Martin Nordholts ad56949d5b app: Make gimp_tool_options_editor_new() use only g_object_new()
In preparation for cleaning up the dialog factory stuff, start making
dockable constructable with just g_object_new(). First out is
gimp_tool_options_editor_new(). Move code from that function into
gimp_tool_options_editor_constructor() and add the necessary "gimp"
GObject property. The regression test
"/gimp-ui/tool-options-editor-updates" still passes after the
refactoring, of course.
2009-12-24 17:50:39 +01:00
Martin Nordholts 5e9aa1281c app/tests: Add regression test "/gimp-ui/tool-options-editor-updates"
Add a new test suite called "test-ui" which will contain several UI
related tests. Right now it just contains a test to make sure that the
tool options editor is updated when the tool changes
("/gimp-ui/tool-options-editor-updates").
2009-12-24 17:50:39 +01:00
Martin Nordholts 049de90d81 app: Add gimp_test_run_mainloop_until_idle()
Add function that runs a main loop until it is idle. Useful for test
cases.
2009-12-24 17:50:39 +01:00
Martin Nordholts 0f7c373f3b app: Add gimp_tool_options_editor_get_tool_options()
Add gimp_tool_options_editor_get_tool_options() for unit testing
purposes.
2009-12-24 17:50:39 +01:00
Sven Neumann e8ff034ab5 Bug 605237 - the "Antialiasing..." message in the progress bar does not show translated
Add missing call to INIT_I18N().
2009-12-23 23:56:45 +01:00
Martin Nordholts cf5d4953fd app: Add GimpToolOptionsEditorPrivate
Add GimpToolOptionsEditorPrivate and format static function
prototypes.
2009-12-23 22:39:47 +01:00
Martin Nordholts c331d5f9eb Bug 598454 - Improve visual feedback for Free Select Tool handles
Highlight the handle for the first vertex in the Free Select Tool even
with button1 down, since releasing the button on the first point will
close the polygon, so it's a significant state which we must give
feedback for.
2009-12-21 22:24:26 +01:00
Martin Nordholts 50525e4543 app: Fill Free Select Tool handles when mouse is over them
Right now the Free Select Tool vertex handles are shown when the
cursor is in the proximity. Extend this a bit, so when the cursor is
_on_ a vertex handle, fill it completely. See bug 598454.
2009-12-21 21:27:54 +01:00
Martin Nordholts caccbe8b67 app/tests: Add XCF write-and-load sanity test
Lay a foundation for having automated XCF file format testing. The
only current test constructs an image, writes it to a file, loads a
new image from that file, and makes sure the loaded image is in the
state we expected, i.e. the same state as the original file.

Next up is adding GIMP 2.6 regression testing to this test suite.
2009-12-21 19:04:48 +01:00
Martin Nordholts 8efb46bd0b app: Remove unused include #include <sys/types.h> in base/base.c 2009-12-21 17:25:01 +01:00