Improve performance of link preview parsing

This commit is contained in:
trevor-signal 2024-08-02 13:07:52 -04:00 committed by GitHub
parent 1a4bc49563
commit 517007ad04
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 4 deletions

View File

@ -290,8 +290,6 @@ const getHtmlDocument = async (
abortSignal: AbortSignal,
logger: Pick<LoggerType, 'warn'> = log
): Promise<HTMLDocument> => {
let result: HTMLDocument = emptyHtmlDocument();
const buffer = new Uint8Array(MAX_HTML_BYTES_TO_LOAD);
let bytesLoadedSoFar = 0;
@ -313,8 +311,6 @@ const getHtmlDocument = async (
buffer.set(truncatedChunk, bytesLoadedSoFar);
bytesLoadedSoFar += truncatedChunk.byteLength;
result = parseHtmlBytes(buffer.slice(0, bytesLoadedSoFar), httpCharset);
const hasLoadedMaxBytes = bytesLoadedSoFar >= buffer.length;
if (hasLoadedMaxBytes) {
break;
@ -326,6 +322,7 @@ const getHtmlDocument = async (
);
}
const result = parseHtmlBytes(buffer.slice(0, bytesLoadedSoFar), httpCharset);
return result;
};