test_framework
/
pytest-bdd
mirror of https://github.com/pytest-dev/pytest-bdd.git
2
0
Fork 1
Code Issues Packages Projects Releases Wiki Activity

Fix gherkin terminal reporter test flakiness (#340) 

The test compares the output of two different reporters and tries to account for
the different runtime being printed. However, the output format changed with
pytest v5.1.0:

https://docs.pytest.org/en/latest/changelog.html#id76

This changes the regex to be a bit more permissive.
This commit is contained in:
Florian Bruhin 2019-11-20 22:19:18 +01:00 committed by Alessio Bogon
parent 76d4d876d6
commit 3f1ba96c2d
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/feature/test_gherkin_terminal_reporter.py
View File

@ -174,9 +174,9 @@ def output_must_be_the_same_as_regular_reporter(test_execution):
assert ghe.ret == 0
# last line can be different because of test execution time is printed
reg_lines = reg.stdout.lines if reg.stdout.lines[-1] else reg.stdout.lines[:-2]
reg_lines[-1] = re.sub(r" \d+\.\d+ ", " X ", reg_lines[-1])
reg_lines[-1] = re.sub(r" in [^=]*", " in X ", reg_lines[-1])
ghe_lines = ghe.stdout.lines if ghe.stdout.lines[-1] else ghe.stdout.lines[:-2]
ghe_lines[-1] = re.sub(r" \d+\.\d+ ", " X ", ghe_lines[-1])
ghe_lines[-1] = re.sub(r" in [^=]*", " in X ", ghe_lines[-1])
for l1, l2 in zip(reg_lines, ghe_lines):
assert l1 == l2