terapines
/
circt
mirror of https://github.com/llvm/circt.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[FIRRTL] Bump FIRRTL version to 3.3.0 for parsing 

Change the gating of new FIRRTL features from 3.2.0 to 3.3.0.  Simplify
this through the use of a new `nextFIRVersion`.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
This commit is contained in:
Schuyler Eldridge 2023-09-27 21:30:24 -04:00
parent fe376a8052
commit d4d71bd4d1
No known key found for this signature in database
GPG Key ID: 50C5E9936AAD536D
6 changed files with 67 additions and 66 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
include/circt/Dialect/FIRRTL/FIRParser.h
View File

@ -107,7 +107,8 @@ struct FIRVersion {
}; };
constexpr FIRVersion minimumFIRVersion(0, 2, 0); constexpr FIRVersion minimumFIRVersion(0, 2, 0);
constexpr FIRVersion latestFIRVersion(3, 2, 0); constexpr FIRVersion latestFIRVersion(3, 3, 0);
constexpr FIRVersion nextFIRVersion(3, 3, 0);
constexpr FIRVersion defaultFIRVersion(1, 0, 0); constexpr FIRVersion defaultFIRVersion(1, 0, 0);
template <typename T> template <typename T>

30
lib/Dialect/FIRRTL/Import/FIRParser.cpp
View File

@ -869,7 +869,7 @@ ParseResult FIRParser::parseType(FIRRTLType &result, const Twine &message) {
break; break;
case FIRToken::kw_Inst: { case FIRToken::kw_Inst: {
if (requireFeature({3, 2, 0}, "Inst types")) if (requireFeature(nextFIRVersion, "Inst types"))
return failure(); return failure();
consumeToken(FIRToken::kw_Inst); consumeToken(FIRToken::kw_Inst);
@ -897,7 +897,7 @@ ParseResult FIRParser::parseType(FIRRTLType &result, const Twine &message) {
} }
case FIRToken::kw_AnyRef: { case FIRToken::kw_AnyRef: {
if (requireFeature({3, 2, 0}, "AnyRef types")) if (requireFeature(nextFIRVersion, "AnyRef types"))
return failure(); return failure();
consumeToken(FIRToken::kw_AnyRef); consumeToken(FIRToken::kw_AnyRef);
@ -1054,29 +1054,29 @@ ParseResult FIRParser::parseType(FIRRTLType &result, const Twine &message) {
result = FIntegerType::get(getContext()); result = FIntegerType::get(getContext());
break; break;
case FIRToken::kw_Bool: case FIRToken::kw_Bool:
if (requireFeature({3, 2, 0}, "Bools")) if (requireFeature(nextFIRVersion, "Bools"))
return failure(); return failure();
consumeToken(FIRToken::kw_Bool); consumeToken(FIRToken::kw_Bool);
result = BoolType::get(getContext()); result = BoolType::get(getContext());
break; break;
case FIRToken::kw_Double: case FIRToken::kw_Double:
if (requireFeature({3, 2, 0}, "Doubles")) if (requireFeature(nextFIRVersion, "Doubles"))
return failure(); return failure();
consumeToken(FIRToken::kw_Double); consumeToken(FIRToken::kw_Double);
result = DoubleType::get(getContext()); result = DoubleType::get(getContext());
break; break;
case FIRToken::kw_Path: case FIRToken::kw_Path:
if (requireFeature({3, 1, 0}, "Paths")) if (requireFeature(nextFIRVersion, "Paths"))
return failure(); return failure();
consumeToken(FIRToken::kw_Path); consumeToken(FIRToken::kw_Path);
result = PathType::get(getContext()); result = PathType::get(getContext());
break; break;
case FIRToken::kw_List: case FIRToken::kw_List:
if (requireFeature({3, 2, 0}, "Lists") || parseListType(result)) if (requireFeature(nextFIRVersion, "Lists") || parseListType(result))
return failure(); return failure();
break; break;
case FIRToken::kw_Map: case FIRToken::kw_Map:
if (requireFeature({3, 2, 0}, "Maps") || parseMapType(result)) if (requireFeature(nextFIRVersion, "Maps") || parseMapType(result))
return failure(); return failure();
break; break;
} }
@ -1854,7 +1854,7 @@ ParseResult FIRStmtParser::parseExpImpl(Value &result, const Twine &message,
break; break;
} }
case FIRToken::kw_Bool: { case FIRToken::kw_Bool: {
if (requireFeature({3, 2, 0}, "Bools")) if (requireFeature(nextFIRVersion, "Bools"))
return failure(); return failure();
locationProcessor.setLoc(getToken().getLoc()); locationProcessor.setLoc(getToken().getLoc());
consumeToken(FIRToken::kw_Bool); consumeToken(FIRToken::kw_Bool);
@ -1873,7 +1873,7 @@ ParseResult FIRStmtParser::parseExpImpl(Value &result, const Twine &message,
break; break;
} }
case FIRToken::kw_Double: { case FIRToken::kw_Double: {
if (requireFeature({3, 2, 0}, "Doubles")) if (requireFeature(nextFIRVersion, "Doubles"))
return failure(); return failure();
locationProcessor.setLoc(getToken().getLoc()); locationProcessor.setLoc(getToken().getLoc());
consumeToken(FIRToken::kw_Double); consumeToken(FIRToken::kw_Double);
@ -1893,7 +1893,7 @@ ParseResult FIRStmtParser::parseExpImpl(Value &result, const Twine &message,
break; break;
} }
case FIRToken::kw_List: { case FIRToken::kw_List: {
if (requireFeature({3, 2, 0}, "Lists")) if (requireFeature(nextFIRVersion, "Lists"))
return failure(); return failure();
if (isLeadingStmt) if (isLeadingStmt)
return emitError("unexpected List<>() as start of statement"); return emitError("unexpected List<>() as start of statement");
@ -1902,7 +1902,7 @@ ParseResult FIRStmtParser::parseExpImpl(Value &result, const Twine &message,
break; break;
} }
case FIRToken::kw_Map: { case FIRToken::kw_Map: {
if (requireFeature({3, 2, 0}, "Maps")) if (requireFeature(nextFIRVersion, "Maps"))
return failure(); return failure();
if (isLeadingStmt) if (isLeadingStmt)
return emitError("unexpected Map<>() as start of statement"); return emitError("unexpected Map<>() as start of statement");
@ -1913,7 +1913,7 @@ ParseResult FIRStmtParser::parseExpImpl(Value &result, const Twine &message,
case FIRToken::lp_path: case FIRToken::lp_path:
if (isLeadingStmt) if (isLeadingStmt)
return emitError("unexpected path() as start of statement"); return emitError("unexpected path() as start of statement");
if (requireFeature({3, 2, 0}, "paths") || parsePathExp(result)) if (requireFeature(nextFIRVersion, "paths") || parsePathExp(result))
return failure(); return failure();
break; break;
@ -3691,7 +3691,7 @@ ParseResult FIRStmtParser::parseObject() {
if (auto isExpr = parseExpWithLeadingKeyword(startTok)) if (auto isExpr = parseExpWithLeadingKeyword(startTok))
return *isExpr; return *isExpr;
if (requireFeature({3, 2, 0}, "object statements")) if (requireFeature(nextFIRVersion, "object statements"))
return failure(); return failure();
StringRef id; StringRef id;
@ -4569,7 +4569,7 @@ ParseResult FIRCircuitParser::parseClass(CircuitOp circuit, unsigned indent) {
SmallVector<SMLoc> portLocs; SmallVector<SMLoc> portLocs;
LocWithInfo info(getToken().getLoc(), this); LocWithInfo info(getToken().getLoc(), this);
if (requireFeature({3, 2, 0}, "classes")) if (requireFeature(nextFIRVersion, "classes"))
return failure(); return failure();
consumeToken(FIRToken::kw_class); consumeToken(FIRToken::kw_class);
@ -4606,7 +4606,7 @@ ParseResult FIRCircuitParser::parseExtClass(CircuitOp circuit,
SmallVector<SMLoc> portLocs; SmallVector<SMLoc> portLocs;
LocWithInfo info(getToken().getLoc(), this); LocWithInfo info(getToken().getLoc(), this);
if (requireFeature({3, 2, 0}, "classes")) if (requireFeature(nextFIRVersion, "classes"))
return failure(); return failure();
consumeToken(FIRToken::kw_extclass); consumeToken(FIRToken::kw_extclass);

2
test/CAPI/firrtl.c
View File

@ -42,7 +42,7 @@ void testExport(MlirContext ctx) {
MlirLogicalResult result = mlirExportFIRRTL(module, exportCallback, NULL); MlirLogicalResult result = mlirExportFIRRTL(module, exportCallback, NULL);
assert(mlirLogicalResultIsSuccess(result)); assert(mlirLogicalResultIsSuccess(result));
// CHECK: FIRRTL version 3.2.0 // CHECK: FIRRTL version 3.3.0
// CHECK-NEXT: circuit ExportTestSimpleModule : // CHECK-NEXT: circuit ExportTestSimpleModule :
// CHECK-NEXT: module ExportTestSimpleModule : @[- 2:3] // CHECK-NEXT: module ExportTestSimpleModule : @[- 2:3]
// CHECK-NEXT: input in_1 : UInt<32> @[- 2:44] // CHECK-NEXT: input in_1 : UInt<32> @[- 2:44]

4
test/Dialect/FIRRTL/emit-basic.mlir
View File

@ -12,7 +12,7 @@
// Check if printing with very short line length, removing info locators (@[...]), no line is longer than 5x line length. // Check if printing with very short line length, removing info locators (@[...]), no line is longer than 5x line length.
// RUN: circt-translate --export-firrtl %s --target-line-length=10 | sed -e 's/ @\[.*\]//' | FileCheck %s --implicit-check-not "{{^(.{50})}}" --check-prefix PRETTY // RUN: circt-translate --export-firrtl %s --target-line-length=10 | sed -e 's/ @\[.*\]//' | FileCheck %s --implicit-check-not "{{^(.{50})}}" --check-prefix PRETTY
// CHECK-LABEL: FIRRTL version 3.2.0 // CHECK-LABEL: FIRRTL version 3.3.0
// CHECK-LABEL: circuit Foo : // CHECK-LABEL: circuit Foo :
// PRETTY-LABEL: circuit Foo : // PRETTY-LABEL: circuit Foo :
firrtl.circuit "Foo" { firrtl.circuit "Foo" {
@ -646,7 +646,7 @@ firrtl.circuit "Foo" {
firrtl.ref.define %_12, %18 : !firrtl.probe<uint<1>> firrtl.ref.define %_12, %18 : !firrtl.probe<uint<1>>
firrtl.ref.define %_13, %_15_ref : !firrtl.rwprobe<uint<1>> firrtl.ref.define %_13, %_15_ref : !firrtl.rwprobe<uint<1>>
} }
// CHECK-LABEL: module Properties : // CHECK-LABEL: module Properties :
firrtl.module @Properties(out %string : !firrtl.string, firrtl.module @Properties(out %string : !firrtl.string,
out %integer : !firrtl.integer, out %integer : !firrtl.integer,

4
test/Dialect/FIRRTL/parse-basic.fir
View File

@ -1679,7 +1679,7 @@ circuit Groups:
;// ----- ;// -----
; CHECK-LABEL: firrtl.circuit "BasicProps" ; CHECK-LABEL: firrtl.circuit "BasicProps"
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit BasicProps : circuit BasicProps :
module BasicProps : module BasicProps :
; CHECK-LABEL: module private @Integer ; CHECK-LABEL: module private @Integer
@ -1879,7 +1879,7 @@ circuit WireOfProbesAndNames:
wire probe : Probe<UInt<1>> wire probe : Probe<UInt<1>>
;// ----- ;// -----
FIRRTL version 3.2.0 FIRRTL version 3.3.0
; CHECK-LABEL: circuit "AnyRef" ; CHECK-LABEL: circuit "AnyRef"
circuit AnyRef: circuit AnyRef:

90
test/Dialect/FIRRTL/parse-errors.fir
View File

@ -166,7 +166,7 @@ circuit invalid_inst :
;// ----- ;// -----
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit class_inst : circuit class_inst :
class some_class : class some_class :
module class_inst : module class_inst :
@ -819,21 +819,21 @@ circuit GroupAndCircuitShareName:
;// ----- ;// -----
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit Top: circuit Top:
; expected-error @below {{class cannot be the top of a circuit}} ; expected-error @below {{class cannot be the top of a circuit}}
class Top: class Top:
;// ----- ;// -----
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit Top: circuit Top:
; expected-error @below {{extclass cannot be the top of a circuit}} ; expected-error @below {{extclass cannot be the top of a circuit}}
extclass Top: extclass Top:
;// ----- ;// -----
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit Top: circuit Top:
module Top: module Top:
class Foo: class Foo:
@ -842,7 +842,7 @@ circuit Top:
;// ----- ;// -----
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit Top: circuit Top:
module Top: module Top:
extclass Foo: extclass Foo:
@ -868,7 +868,7 @@ circuit Top:
propassign out, in propassign out, in
;// ----- ;// -----
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit Top: circuit Top:
module Top: module Top:
@ -876,7 +876,7 @@ circuit Top:
input in : Inst<Missing> input in : Inst<Missing>
;// ----- ;// -----
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit Top: circuit Top:
module Top: module Top:
@ -884,7 +884,7 @@ circuit Top:
object x of Missing object x of Missing
;// ----- ;// -----
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit Top: circuit Top:
class MyClass: class MyClass:
@ -900,7 +900,7 @@ circuit Top:
FIRRTL version 3.0.0 FIRRTL version 3.0.0
circuit Top: circuit Top:
; expected-error @below {{classes are a FIRRTL 3.2.0+ feature, but the specified FIRRTL version was 3.0.0}} ; expected-error @below {{classes are a FIRRTL 3.3.0+ feature, but the specified FIRRTL version was 3.0.0}}
class MyClass: class MyClass:
skip skip
@ -912,15 +912,15 @@ FIRRTL version 3.0.0
circuit Top: circuit Top:
module Top: module Top:
; expected-error @below {{object statements are a FIRRTL 3.2.0+ feature, but the specified FIRRTL version was 3.0.0}} ; expected-error @below {{object statements are a FIRRTL 3.3.0+ feature, but the specified FIRRTL version was 3.0.0}}
object x of MyClass object x of MyClass
;// ----- ;// -----
FIRRTL version 3.0.0 FIRRTL version 3.0.0
circuit Top: circuit Top:
module Top: module Top:
; expected-error @below {{Inst types are a FIRRTL 3.2.0+ feature, but the specified FIRRTL version was 3.0.0}} ; expected-error @below {{Inst types are a FIRRTL 3.3.0+ feature, but the specified FIRRTL version was 3.0.0}}
output o: Inst<MyClass> output o: Inst<MyClass>
;// ----- ;// -----
@ -928,11 +928,11 @@ circuit Top:
FIRRTL version 3.1.0 FIRRTL version 3.1.0
circuit ListOfInt: circuit ListOfInt:
module ListOfInt: module ListOfInt:
; expected-error @below {{Lists are a FIRRTL 3.2.0+ feature}} ; expected-error @below {{Lists are a FIRRTL 3.3.0+ feature}}
output a : List<Integer> output a : List<Integer>
;// ----- ;// -----
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit ListOfUInt: circuit ListOfUInt:
module ListOfUInt: module ListOfUInt:
; expected-error @below {{expected property type}} ; expected-error @below {{expected property type}}
@ -940,7 +940,7 @@ circuit ListOfUInt:
;// ----- ;// -----
; Wrong type of elements in List expression. ; Wrong type of elements in List expression.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit ListOfUInt: circuit ListOfUInt:
module ListOfUInt: module ListOfUInt:
output a : List<String> output a : List<String>
@ -949,7 +949,7 @@ circuit ListOfUInt:
;// ----- ;// -----
; List should not be leading a statement. ; List should not be leading a statement.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit LeadingList: circuit LeadingList:
module LeadingList: module LeadingList:
; expected-error @below {{unexpected List<>() as start of statement}} ; expected-error @below {{unexpected List<>() as start of statement}}
@ -957,7 +957,7 @@ circuit LeadingList:
;// ----- ;// -----
; Path should not be leading a statement. ; Path should not be leading a statement.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit LeadingPath: circuit LeadingPath:
module LeadingPath: module LeadingPath:
; expected-error @below {{unexpected path() as start of statement}} ; expected-error @below {{unexpected path() as start of statement}}
@ -967,13 +967,13 @@ circuit LeadingPath:
FIRRTL version 3.1.0 FIRRTL version 3.1.0
circuit PathVersion: circuit PathVersion:
module PathVersion: module PathVersion:
; expected-error @below {{Paths are a FIRRTL 3.3.0+ feature, but the specified FIRRTL version was 3.1.0}}
output path : Path output path : Path
; expected-error @below {{paths are a FIRRTL 3.2.0+ feature, but the specified FIRRTL version was 3.1.0}}
propassign path, path("") propassign path, path("")
;// ----- ;// -----
; Path operation should have a single string argument. ; Path operation should have a single string argument.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit BadPathExpr: circuit BadPathExpr:
module BadPathExp: module BadPathExp:
output path : Path output path : Path
@ -982,7 +982,7 @@ circuit BadPathExpr:
;// ----- ;// -----
; Path operation should have a single string argument. ; Path operation should have a single string argument.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit BadPathExpr: circuit BadPathExpr:
module BadPathExp: module BadPathExp:
output path : Path output path : Path
@ -991,7 +991,7 @@ circuit BadPathExpr:
;// ----- ;// -----
; Path operation should have a single string argument. ; Path operation should have a single string argument.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit BadPathExpr: circuit BadPathExpr:
module BadPathExp: module BadPathExp:
output path : Path output path : Path
@ -1004,14 +1004,14 @@ FIRRTL version 3.0.0
circuit Top: circuit Top:
module Top: module Top:
; expected-error @below {{Bools are a FIRRTL 3.2.0+ feature, but the specified FIRRTL version was 3.0.0}} ; expected-error @below {{Bools are a FIRRTL 3.3.0+ feature, but the specified FIRRTL version was 3.0.0}}
input in : Bool input in : Bool
output out : Bool output out : Bool
propassign out, in propassign out, in
;// ----- ;// -----
; Bool literal must be true or false. ; Bool literal must be true or false.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit Top: circuit Top:
module Top: module Top:
@ -1021,7 +1021,7 @@ circuit Top:
;// ----- ;// -----
; Properties can't be const. ; Properties can't be const.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit Top: circuit Top:
module Top: module Top:
@ -1033,12 +1033,12 @@ circuit Top:
FIRRTL version 3.1.0 FIRRTL version 3.1.0
circuit MapStrToInt: circuit MapStrToInt:
module MapStrToInt: module MapStrToInt:
; expected-error @below {{Maps are a FIRRTL 3.2.0+ feature}} ; expected-error @below {{Maps are a FIRRTL 3.3.0+ feature}}
output a : Map<String, Integer> output a : Map<String, Integer>
;// ----- ;// -----
; Map with non-property key type. ; Map with non-property key type.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit MapUIntTo: circuit MapUIntTo:
module MapUIntTo: module MapUIntTo:
; expected-error @below {{expected property type}} ; expected-error @below {{expected property type}}
@ -1046,7 +1046,7 @@ circuit MapUIntTo:
;// ----- ;// -----
; Map with non-property value type. ; Map with non-property value type.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit MapToUInt: circuit MapToUInt:
module MapToUInt: module MapToUInt:
; expected-error @below {{expected property type}} ; expected-error @below {{expected property type}}
@ -1054,7 +1054,7 @@ circuit MapToUInt:
;// ----- ;// -----
; Wrong type of keys in Map expression. ; Wrong type of keys in Map expression.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit MapToString: circuit MapToString:
module MapToString: module MapToString:
output a : Map<Integer, String> output a : Map<Integer, String>
@ -1063,7 +1063,7 @@ circuit MapToString:
;// ----- ;// -----
; Wrong type of values in Map expression. ; Wrong type of values in Map expression.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit MapBoolTo: circuit MapBoolTo:
module MapBoolTo: module MapBoolTo:
output a : Map<Bool, Integer> output a : Map<Bool, Integer>
@ -1073,7 +1073,7 @@ circuit MapBoolTo:
;// ----- ;// -----
; Map should not be leading a statement. ; Map should not be leading a statement.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit LeadingMap: circuit LeadingMap:
module LeadingMap: module LeadingMap:
; expected-error @below {{unexpected Map<>() as start of statement}} ; expected-error @below {{unexpected Map<>() as start of statement}}
@ -1081,7 +1081,7 @@ circuit LeadingMap:
;// ----- ;// -----
; Map should not be const. ; Map should not be const.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit ConstMap: circuit ConstMap:
module ConstMap: module ConstMap:
; expected-error @below {{only hardware types can be 'const'}} ; expected-error @below {{only hardware types can be 'const'}}
@ -1092,12 +1092,12 @@ circuit ConstMap:
FIRRTL version 3.1.0 FIRRTL version 3.1.0
circuit AnyRef: circuit AnyRef:
module AnyRef: module AnyRef:
; expected-error @below {{AnyRef types are a FIRRTL 3.2.0+ feature}} ; expected-error @below {{AnyRef types are a FIRRTL 3.3.0+ feature}}
output a : AnyRef output a : AnyRef
;// ----- ;// -----
; Only objects are valid as AnyRef ; Only objects are valid as AnyRef
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit AnyRef: circuit AnyRef:
module AnyRef: module AnyRef:
output out : AnyRef output out : AnyRef
@ -1106,7 +1106,7 @@ circuit AnyRef:
;// ----- ;// -----
; Only objects are valid as AnyRef in Lists ; Only objects are valid as AnyRef in Lists
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit AnyRefList: circuit AnyRefList:
module AnyRefList: module AnyRefList:
output list : List<AnyRef> output list : List<AnyRef>
@ -1115,7 +1115,7 @@ circuit AnyRefList:
;// ----- ;// -----
; Only objects are valid as AnyRef in Maps (keys) ; Only objects are valid as AnyRef in Maps (keys)
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit MapFromAnyRef: circuit MapFromAnyRef:
module MapFromAnyRef: module MapFromAnyRef:
output mapFrom : Map<AnyRef, Integer> output mapFrom : Map<AnyRef, Integer>
@ -1124,7 +1124,7 @@ circuit MapFromAnyRef:
;// ----- ;// -----
; Only objects are valid as AnyRef in Maps (values) ; Only objects are valid as AnyRef in Maps (values)
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit MapToAnyRef: circuit MapToAnyRef:
module MapToAnyRef: module MapToAnyRef:
output mapTo: Map<Integer, AnyRef> output mapTo: Map<Integer, AnyRef>
@ -1133,7 +1133,7 @@ circuit MapToAnyRef:
;// ----- ;// -----
; Not Covariant. ; Not Covariant.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit NotCovariant: circuit NotCovariant:
class Class: class Class:
@ -1146,7 +1146,7 @@ circuit NotCovariant:
;// ----- ;// -----
; Not Contravariant. ; Not Contravariant.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit NotContravariant: circuit NotContravariant:
class Class: class Class:
@ -1159,7 +1159,7 @@ circuit NotContravariant:
;// ----- ;// -----
; Double: must have digit before point. ; Double: must have digit before point.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit DoubleNegPeriod: circuit DoubleNegPeriod:
module DoubleNegPeriod: module DoubleNegPeriod:
output d : Double output d : Double
@ -1168,7 +1168,7 @@ circuit DoubleNegPeriod:
;// ----- ;// -----
; Double: must have digit after point. ; Double: must have digit after point.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit DoublePeriodEnd: circuit DoublePeriodEnd:
module DoublePeriodEnd: module DoublePeriodEnd:
output d : Double output d : Double
@ -1177,7 +1177,7 @@ circuit DoublePeriodEnd:
;// ----- ;// -----
; Double: Not an integer. ; Double: Not an integer.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit DoubleInteger: circuit DoubleInteger:
module DoubleInteger: module DoubleInteger:
output d : Double output d : Double
@ -1186,7 +1186,7 @@ circuit DoubleInteger:
;// ----- ;// -----
; Double: don't support NaN or inf. ; Double: don't support NaN or inf.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit DoubleNaN: circuit DoubleNaN:
module DoubleNaN: module DoubleNaN:
output d : Double output d : Double
@ -1195,7 +1195,7 @@ circuit DoubleNaN:
;// ----- ;// -----
; Double: Don't support hex. ; Double: Don't support hex.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit DoubleHex: circuit DoubleHex:
module DoubleHex: module DoubleHex:
output d : Double output d : Double
@ -1203,8 +1203,8 @@ circuit DoubleHex:
propassign d, Double(0x0) propassign d, Double(0x0)
;// ----- ;// -----
; Double: Don't support FIRRTL-y radix. ; Double: Don't suuport FIRRTL-y radix.
FIRRTL version 3.2.0 FIRRTL version 3.3.0
circuit DoubleRadix: circuit DoubleRadix:
module DoubleRadix: module DoubleRadix:
output d : Double output d : Double