terapines
/
circt
mirror of https://github.com/llvm/circt.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[FIRRTL][CheckCombCycles] Use range-based loop to traverse op users, NFC

This commit is contained in:
Hanchen Ye 2021-08-05 03:05:16 -05:00
parent deaaa6c79f
commit a81395d2d4
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
lib/Dialect/FIRRTL/Transforms/CheckCombCycles.cpp
View File

@ -245,12 +245,11 @@ public:
// Only `data` or `rdata` subfield is combinationally connected to `addr` // Only `data` or `rdata` subfield is combinationally connected to `addr`
// subfield. Find the corresponding subfield op. // subfield. Find the corresponding subfield op.
auto users = subfield.input().getUsers(); for (auto user : subfield.input().getUsers()) {
for (auto it = users.begin(), e = users.end(); it != e; ++it) { auto currentSubfield = dyn_cast<SubfieldOp>(user);
auto currentSubfield = dyn_cast<SubfieldOp>(*it);
if (!currentSubfield) { if (!currentSubfield) {
it->emitOpError("MemOp must be used by SubfieldOp, please run " user->emitOpError("MemOp must be used by SubfieldOp, please run "
"-firrtl-lower-types first"); "-firrtl-lower-types first");
return; return;
} }