terapines
/
circt
mirror of https://github.com/llvm/circt.git
2
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[SV] Further cleanups for sv.wire/sv.reg now that they require a name.

This commit is contained in:
Chris Lattner 2021-03-31 10:29:40 -07:00
parent 74f99727c6
commit a18efe7638
1 changed files with 10 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
lib/Dialect/SV/SVOps.cpp
View File

@ -144,9 +144,9 @@ void ConstantZOp::getAsmResultNames(
void RegOp::build(OpBuilder &odsBuilder, OperationState &odsState,
Type elementType, StringAttr name) {
if (name)
odsState.addAttribute("name", name);
if (!name)
name = odsBuilder.getStringAttr("");
odsState.addAttribute("name", name);
odsState.addTypes(rtl::InOutType::get(elementType));
}
@ -154,7 +154,8 @@ void RegOp::build(OpBuilder &odsBuilder, OperationState &odsState,
/// attribute.
void RegOp::getAsmResultNames(OpAsmSetValueNameFn setNameFn) {
// If the wire has an optional 'name' attribute, use it.
if (auto nameAttr = (*this)->getAttrOfType<StringAttr>("name"))
auto nameAttr = (*this)->getAttrOfType<StringAttr>("name");
if (!nameAttr.getValue().empty())
setNameFn(getResult(), nameAttr.getValue());
}
@ -827,9 +828,10 @@ LogicalResult verifySignalExists(Value ifaceVal, FlatSymbolRefAttr signalName) {
void WireOp::build(OpBuilder &odsBuilder, OperationState &odsState,
Type elementType, StringAttr name) {
if (name)
odsState.addAttribute("name", name);
if (!name)
name = odsBuilder.getStringAttr("");
odsState.addAttribute("name", name);
odsState.addTypes(InOutType::get(elementType));
}
@ -837,7 +839,8 @@ void WireOp::build(OpBuilder &odsBuilder, OperationState &odsState,
/// attribute.
void WireOp::getAsmResultNames(OpAsmSetValueNameFn setNameFn) {
// If the wire has an optional 'name' attribute, use it.
if (auto nameAttr = (*this)->getAttrOfType<StringAttr>("name"))
auto nameAttr = (*this)->getAttrOfType<StringAttr>("name");
if (!nameAttr.getValue().empty())
setNameFn(getResult(), nameAttr.getValue());
}