Commit Graph

139 Commits

Author SHA1 Message Date
ccavazzoni 34781504de - more implicit world communicator clean-up
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10511 c92efa57-630b-4861-b058-cf58834340f0
2013-10-06 19:09:46 +00:00
giannozz 041d970f65 More minor MPI changes by Axel:
- adapt mp_abort() to have a mandatory communicator
- remove the unused err_msg string variable
- fix a compilation issue
- update dependencies



git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10501 c92efa57-630b-4861-b058-cf58834340f0
2013-10-01 20:04:21 +00:00
ccavazzoni b1fabb0fd9 - more clean-up about mp call without communicator
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10498 c92efa57-630b-4861-b058-cf58834340f0
2013-09-28 23:32:46 +00:00
ccavazzoni 68d56dfcf2 - commit of Axel patches to remove dependencies form mpi_world_comm
and to setup blacs grid accordingly



git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10480 c92efa57-630b-4861-b058-cf58834340f0
2013-09-26 15:47:31 +00:00
giannozz b76c962d0f Changes to MPI initialization suggested by Axel in order to make gluing with
QMMM easier


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10475 c92efa57-630b-4861-b058-cf58834340f0
2013-09-23 12:57:14 +00:00
giannozz ea106b8a04 More fixes for compilation trouble (Axel), make,depend updated
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10473 c92efa57-630b-4861-b058-cf58834340f0
2013-09-23 11:37:08 +00:00
giannozz 0bb7bfe79d Cleanup of reading and initialization of Environ-related variables
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10430 c92efa57-630b-4861-b058-cf58834340f0
2013-08-09 09:03:44 +00:00
giannozz a6a83aff18 Harmonization of Tkachenko-Scheffler VdW correction with existing Grimme
semiempirical correction and with general QE programming style (if any):
* there is a new variable "vdw_corr", in namelist &system (not &control)
  that can have 'TS', 'ts', 'Grimme-D2', etc values. I guess there will
  be soon 2n+1 different van der Waals semiempirical corrections, so it
  is wise to have a single variable for all of them. Related variables
  (options, cutoffs, etc) keep their current names, are read from &system.
* variables read on input are copied to internal variables, as in all
  other cases. It is clumsy and I am starting to doubt it will ever be
  useful, but it has to be done in a consistent way.
Note that this may introduce some incompatibilities, especially for users
of modified CP code. If anybody has better ideas, feel free to propose.
If something doesn't work as expected, please let me know.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10426 c92efa57-630b-4861-b058-cf58834340f0
2013-08-06 15:01:29 +00:00
giannozz 79c73ab2ee Moe occurrences of "index" as variable. Please verify if everything is
still working as expected


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10369 c92efa57-630b-4861-b058-cf58834340f0
2013-07-08 17:26:55 +00:00
giannozz 2f1d6fe097 Numeric constant given a name (ry_to_ghz) and moved to constants.f90;
make.depend updated; misc. minor things


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10015 c92efa57-630b-4861-b058-cf58834340f0
2013-02-26 10:03:47 +00:00
giannozz 1d08c091f0 Oops...leftover prints; make.depend updated; variable lxmlinput is intent(out)
since its input value is ignored (only its presence is checked)


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@9920 c92efa57-630b-4861-b058-cf58834340f0
2013-02-02 21:21:34 +00:00
giannozz c955629ae7 Cleanup of new initialization + restored missing in action ntask_group
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@9885 c92efa57-630b-4861-b058-cf58834340f0
2013-01-29 10:31:17 +00:00
giannozz aca32a501a Module mp_global split into more modules, one per parallelization level.
Module mp_global is still there for compatibility and still contains the
routine mp_startup that performs the intialization, but shouldn't be any
longer used in new developments and should be slowly replaced by specific
modules. New module containing command-line options added. Command-line
options are read at the beginning of the run and broadcast to all processors
(there is no guarantee that command-line options cam be accessed by all mpi
 processes). Nothing should be broken by these changes but please verify if
all parallelization levels work (I have limited access to parallel machines
right now)

The reason for these changes, and for those that will come soon, is to make
image parallelization easier (in particular in NEB but also for other cases). 
Right now it is a pain, in part because the initialization is inadequate,
in part because it is never clear who reads/writes what from/to where.
It will take a few weeks before everything converges to a stable state.
Meanwhile, please be patient and fix/report problems.



git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@9876 c92efa57-630b-4861-b058-cf58834340f0
2013-01-28 09:21:12 +00:00
giannozz 12fc957ee0 Minor cleanup: names in lowercase
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@9867 c92efa57-630b-4861-b058-cf58834340f0
2013-01-26 08:32:01 +00:00
giannozz 53a26ef521 Cleanup, removal of unused routines, comments added or corrected
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@9810 c92efa57-630b-4861-b058-cf58834340f0
2013-01-19 15:02:11 +00:00
spigafi b2b24dd848 ELPA library is completely detached from the main code, compiled as external library provided under ./archive/
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@9559 c92efa57-630b-4861-b058-cf58834340f0
2012-10-20 14:56:34 +00:00
giannozz b9120808a1 New variable lorbm was missing in input_parameters
make.depend updated


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@9457 c92efa57-630b-4861-b058-cf58834340f0
2012-09-29 10:57:15 +00:00
faffinito d23f5fd30c Implementation of the ELPA library for diagonalization of real matrices. To use ELPA it's necessary to link scalapack. Use with --with-scalapack --with-elpa
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@9450 c92efa57-630b-4861-b058-cf58834340f0
2012-09-26 15:05:22 +00:00
giannozz 5410de220f USEd routine cfft3d never actually used; make.depend updated
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@9407 c92efa57-630b-4861-b058-cf58834340f0
2012-08-31 17:24:49 +00:00
ccavazzoni 0b568ae27f - moving modules from PW to Modules in order to be used
in CP as well.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@9227 c92efa57-630b-4861-b058-cf58834340f0
2012-07-26 15:35:10 +00:00
giannozz ea318b85c4 Cleanup; removed useless and confusing wrapper write_upf (somebody
please check if casino3upf works properly after the change)


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@9141 c92efa57-630b-4861-b058-cf58834340f0
2012-06-29 14:24:02 +00:00
giannozz de7b82c60c makedeps.sh wasn't working as expected, make.depend updated
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@9016 c92efa57-630b-4861-b058-cf58834340f0
2012-05-20 17:34:00 +00:00
marsamos f5f506651f update make.depend
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@8851 c92efa57-630b-4861-b058-cf58834340f0
2012-04-04 12:35:19 +00:00
sbinnie da16185ebc Merged espresso-EXX into trunk from r8463 onwards. This introduces the use of Custom fft grids for EXX contributions. This is controlled by the keyword ecutfock. Documentation to follow.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@8804 c92efa57-630b-4861-b058-cf58834340f0
2012-03-19 16:37:13 +00:00
oliviero 0c7197e26a Moved compute_e_dipole from PW/src/makov_payne.f90 to Modules. The subroutine computes total charge,
dipole moment and quadrupole moment of a charge distribution on the dense real-space grid. 
The subroutine has been modified to accept any kind of density as input. PW/src/makov_payne.f90 modified accordingly. 


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@8701 c92efa57-630b-4861-b058-cf58834340f0
2012-02-21 16:33:59 +00:00
oliviero 4e195472f5 Some utilities developed for the Solvent module are moved into Modules because possibly of general interest.
In particular: 
fd_gradient.f90 contains a module to perform gradients in the real space grid using finite differences. A few
different schemes have been implemented, it is necessary to initialize the finite difference calculation by 
passing the selected scheme and order to an initialization routine. The module is parallel, but not very fancy.
generate_function.f90 contains a few subroutines that generate a specific function on the real space grid. The 
possible functions are gaussian, exponenentials, gradient of gassians and gradient of exponentials. Also in this
case the subroutines are parallel and built following the scheme in the makov_payne.f90 subroutines. 


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@8645 c92efa57-630b-4861-b058-cf58834340f0
2012-02-14 16:13:18 +00:00
giannozz ff5808d09e make.depend updated
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@8635 c92efa57-630b-4861-b058-cf58834340f0
2012-02-13 20:30:41 +00:00
giannozz 0a6fd59a4c Cleanup of input file opening: removed calls to errore that would have hanged in parallel, temporary input file removed at the end
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@8601 c92efa57-630b-4861-b058-cf58834340f0
2012-02-11 10:54:34 +00:00
marsamos 3f7a70ab9a EPW trunk set as svn:external
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@8329 c92efa57-630b-4861-b058-cf58834340f0
2011-12-14 11:32:03 +00:00
giannozz 0a30d23113 Merged a small part of the input reading between PW and CP. Beware unexpected
side efects in parallel execution (ther shouldn't be an, though, since CP does
not work with images rigth now)


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@8076 c92efa57-630b-4861-b058-cf58834340f0
2011-08-11 14:59:43 +00:00
giannozz 84b3694fdf Printout and check while reading pseudppotentials in CP re-instated
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@8060 c92efa57-630b-4861-b058-cf58834340f0
2011-08-08 08:44:31 +00:00
giannozz 8ccaa62027 Merged PW and CP versiobs of read_pseudo.f90. A few printouts and checks
previously made in CP are still missing


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@8057 c92efa57-630b-4861-b058-cf58834340f0
2011-08-07 19:37:01 +00:00
giannozz 779fad75ad Cleanup: modules energies and printout_base moved to CPV where they are used.
The only variable used in all codes, "title", moved to a new module run_info
in Modules (it may in the furture contain more stuff).


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@8044 c92efa57-630b-4861-b058-cf58834340f0
2011-08-03 19:16:03 +00:00
giannozz 5fc5af1026 First batch of changes needed for hybrid functioonals in CP using Wannier
functions - courtesy of Xifan Wu (Temple U.), Lingzhu Kong, Zhaofeng Li
(Princeton U.). There should be no effect on other functionalities.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@8029 c92efa57-630b-4861-b058-cf58834340f0
2011-07-31 12:24:24 +00:00
ccavazzoni 8040dea31d - grid data structure merged with the fft data structure.
Now all variables regarding real space grid, fft and 
  their parallelization are contained into the objects:
  dfftp (dense grid) 
  dffts (smooth grid)



git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7973 c92efa57-630b-4861-b058-cf58834340f0
2011-07-14 22:14:15 +00:00
riccardo bc21554b27 Added the non-local (nlc) flag to the dft definition. Now PP and dft
needs five interegers to be fully defined (all the back-compatibility
has been respected).

Added drivers and functions to implement new non-local functionals.

Added the vdw-DF2 (to test).

Fixed how shortnames are handled in input (funct.f90)



git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7706 c92efa57-630b-4861-b058-cf58834340f0
2011-04-27 15:18:18 +00:00
giannozz e694bbdd4e Warning message should go to stdout, not to unit 0
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7492 c92efa57-630b-4861-b058-cf58834340f0
2011-02-13 14:23:41 +00:00
giannozz 9a965ddd42 Removed redirections of stdout for first image in environment_start,
re-assignement to stdout in image_io_start. The net effect should be
that NEB works as before (stdout is re-assigned and re-directed anyway)
while PH should have image 1 write to stdout. No warranty, not tested.
string_methods.f90 renamed to neb.f90.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7488 c92efa57-630b-4861-b058-cf58834340f0
2011-02-12 21:09:52 +00:00
giannozz 89a9e6b777 All nose-related modules displaced into CPV
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7478 c92efa57-630b-4861-b058-cf58834340f0
2011-02-04 11:35:47 +00:00
giannozz f2b094c7dc Module cell_nose separated from cell_base and moved to CPV/
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7477 c92efa57-630b-4861-b058-cf58834340f0
2011-02-04 11:16:35 +00:00
marsamos e70d77757c in mp_global now two routines mp_global_startup and mp_global_startup_new.
startup_new takes root and comm as arguments. Added mp_image_global_module
that contains only image parallelization.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7444 c92efa57-630b-4861-b058-cf58834340f0
2011-01-27 10:13:23 +00:00
giannozz 096e3a5ef7 Fixed compilation problem in serial case. Not sure the fix is the good one,
though.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7440 c92efa57-630b-4861-b058-cf58834340f0
2011-01-24 07:17:46 +00:00
ccavazzoni 8fb1ad0998 - eliminated module task groups (subroutines moved to fft modules)
- added variables to fft type to store info about data distribution


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7433 c92efa57-630b-4861-b058-cf58834340f0
2011-01-22 18:57:51 +00:00
marsamos e9c58a2c23 changed all tread in read_cards by specific ttemplate, tionvel, ...
need for calling iteratively read_cards.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7405 c92efa57-630b-4861-b058-cf58834340f0
2011-01-17 16:56:19 +00:00
giannozz 59617dd793 Almost final merge of G-vector generation between PW and CP:
- Grid dimensions for both dense and smooth grids are in Modules/griddim.f90
- Variables describing  G vectors and their mapping onto FFT grids (both
  dense and smooth) are in Modules/recvec.f90
- FFT descriptors are defined in Modules/fft_types.f90
- Variables describing G-vector distribution across processors are
  contained in Modules/stick_base.f90
- Distribution across processors of G vectors in sticks and planes
  is performed in Modules/stick_set.f90, routine pstickset, which
  also initializes FFT descriptors
- G vectors and their mapping onto FFT grids are calculated in
  Modules/recvec_subs.f90 (routine ggen: a modified version of PW one,
  replacing the CP one ggencp)
Testing is very limited but given the kind of modifications there should
be no major problem, I hope.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7384 c92efa57-630b-4861-b058-cf58834340f0
2011-01-05 16:04:54 +00:00
giannozz ab864207ac a) a module displaced from Modules/ to CPV/
b) the fix I introduced some time ago to avoid keeping a large and non
distributed array mill_g wasn't very smart and likely electric fields in
CP were no longer working in CP
c) Misc. cleanup in view of some more CP-PW merge in G-vectors


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7379 c92efa57-630b-4861-b058-cf58834340f0
2011-01-04 18:45:48 +00:00
dalcorso 5aab54b1d2 Completed the substitution nrxx -> dfftp%nnr , nrxxs -> dffts%nnr in the
phonon code.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7372 c92efa57-630b-4861-b058-cf58834340f0
2010-12-31 13:18:20 +00:00
giannozz f4c60249fe More CP cleanup
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7361 c92efa57-630b-4861-b058-cf58834340f0
2010-12-28 20:25:38 +00:00
giannozz 034cd6cbe6 Misspelled variable ("i" instead of "1") caused out-of-bound error
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7293 c92efa57-630b-4861-b058-cf58834340f0
2010-12-10 13:25:23 +00:00
marsamos 602cd50081 added plugin_arguments and plugin_flags file in modules
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7263 c92efa57-630b-4861-b058-cf58834340f0
2010-11-29 15:59:30 +00:00