Commit Graph

62 Commits

Author SHA1 Message Date
giannozz f1e241876b First attempt to solve the problem of xcrysden not reading the final
coordinats in a relax calculation. I followed Tone's suggestion. The
delimiters for the final set of cordinates are just one of the possible
choiceis and can be easily changed in output_tau.f90


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@6036 c92efa57-630b-4861-b058-cf58834340f0
2009-10-17 11:19:30 +00:00
giannozz 3cd50d0257 More cleanup: spelling of Quantum ESPRESSO, CMPLX explicitly cast, f_defs.h
removed, a few REAL transformed into DBLE. Note that my previos statement
about REAL is overblown: REAl(C) is perfectly safe if C is a double precision
complex number. All changes should be safe.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5793 c92efa57-630b-4861-b058-cf58834340f0
2009-08-01 17:48:59 +00:00
giannozz c1bd349664 name redirection in moduli should be avoided unless strictly necessary
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5179 c92efa57-630b-4861-b058-cf58834340f0
2008-09-05 17:11:25 +00:00
giannozz 77e3b13d57 Minor cleanup: replicated piece of code removed
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5152 c92efa57-630b-4861-b058-cf58834340f0
2008-08-31 08:24:26 +00:00
giannozz c0ed2198e2 Call to "setup()" moved out from init_run . Nothing changes for now.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5114 c92efa57-630b-4861-b058-cf58834340f0
2008-08-08 20:40:08 +00:00
sbraccia dac184d450 Added a few more comments and references. Fixed another little bug in
the restart procedure. C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3905 c92efa57-630b-4861-b058-cf58834340f0
2007-04-10 14:11:12 +00:00
sbraccia cfdd13cf74 Routine reset_k_points updated. C.S.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3903 c92efa57-630b-4861-b058-cf58834340f0
2007-04-06 15:23:52 +00:00
sbraccia 180c6fe7a6 Yet another fix for restart procedure of NEB/SMD. Cleanup of unused variables.
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3902 c92efa57-630b-4861-b058-cf58834340f0
2007-04-05 19:53:16 +00:00
sbraccia 83a6c415c7 Fixed a bug in the restart procedure of NEB/SMD. C.S.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3900 c92efa57-630b-4861-b058-cf58834340f0
2007-04-04 16:02:12 +00:00
sbraccia ca94801130 NEB and SMD were broken by recent changes to divide_et_impera. Fixed. C.S.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3847 c92efa57-630b-4861-b058-cf58834340f0
2007-03-15 02:25:40 +00:00
sbraccia 64ee5f2ab3 Removed unnecessary call to find_alpha_and_beta. C.S.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3736 c92efa57-630b-4861-b058-cf58834340f0
2007-02-01 16:47:49 +00:00
sbraccia 99444ccf61 Fixed a bug in image-parallelization of NEB/SMD. Variable dim renamed dim1.
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3699 c92efa57-630b-4861-b058-cf58834340f0
2007-01-20 00:02:00 +00:00
sbraccia ea1f0ff124 NEB was not working properly if first_last_opt was set true and more than 2 pools
of images where used. C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3667 c92efa57-630b-4861-b058-cf58834340f0
2007-01-15 15:11:28 +00:00
giannozz 19aaac89fa More miscellanous cleanup from Axel:
- disable locales via use of LC_ALL=C in all shell scripts
   (which will hopefully make sorted lists more consistent
    between people running with different locales).
 - remove redundant files from PW, NMR_new, VdW, VIB;
   rename subroutines if their functionality is noI
   unchanged from the original source it was taken from.
 - corresponding updates to Makefiles and dependencies.
 - whitespace cleanups (eleminate remaining tabs).
 - a few more float->DBLE


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3596 c92efa57-630b-4861-b058-cf58834340f0
2006-12-12 11:02:09 +00:00
sbraccia f4171e694c Few improvments of image parallelization algorithm for NEB and SMD (both potential
energy and free-energy calculations): now it works for local file-systems also.
Variables names conflicting with  fortran keywords (target) have been changed.
Clean-up of meta-dynamics code.
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3592 c92efa57-630b-4861-b058-cf58834340f0
2006-12-11 14:51:54 +00:00
giannozz ac0034e077 charge density no longer written to file during non-scf calculation
One bad call to punch removed, one fixed


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3469 c92efa57-630b-4861-b058-cf58834340f0
2006-10-20 14:14:19 +00:00
sbraccia 5116aacd55 Clean-up of routines used for meta-dynamics and for the calculation of
free-energy barriers. C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3382 c92efa57-630b-4861-b058-cf58834340f0
2006-09-12 18:28:57 +00:00
sbraccia 6c06b0cbbc Another bug-fix related to the istep initialization. C.S.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3204 c92efa57-630b-4861-b058-cf58834340f0
2006-06-23 18:54:55 +00:00
sbraccia ea0935fb5f Fixed a bug in the definition of the diagonalization thresholds for empty
states. This bug (introduced at the end of May 2005) was responsible for
somehow wrong results in the case of calculations with many k-points.
Cleanup of diagonalization thresholds: wg_set variable removed and btype array
is now set in sum_band.
Added a logical input variable (diago_full_acc) to decide if the empty states
(defined as states with occupation < 1%) have to be converged at full accuracy
or not. Defaul is .FALSE. (I am not sure this is the best choice, comments
appreciated).
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3040 c92efa57-630b-4861-b058-cf58834340f0
2006-04-24 17:32:08 +00:00
sbraccia 798f511ab2 Fixed an error in the initialization of neb variables introduced recently. C.S
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@2968 c92efa57-630b-4861-b058-cf58834340f0
2006-03-27 22:34:53 +00:00
sbraccia 1e86d9fef7 Cleanup of unused variables. C.S.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@2881 c92efa57-630b-4861-b058-cf58834340f0
2006-03-08 04:00:02 +00:00
giannozz 8eda231bbb - Variable cell: use Cesar Da Silva's version of the damping algorithm
(he claims it is more tested); documentation updated (sort of)
- routines find_free_unit, delete_if_present, moved from 'parser'
  to 'io_files' (it is a more natural place)
- routines int_to_char moved from 'parser' to flib/ (it is quite
  unrelated with the rest of the module)
- routine trimcheck moved from flib/ to 'io_files' (more natural place)


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@2753 c92efa57-630b-4861-b058-cf58834340f0
2006-02-01 17:56:16 +00:00
giannozz 04829cc556 - Version number updated to 3.1
- Changed format when writing a copy of the UPF file: for some reason
  the free format adds an initial blank character, causing the program
  to fail when reading (in fixed format) additional info for spin-orbit.
  Format A is now used when writing, free format when reading. (AdC)
- More preprocessing cleanup and documentation: anybody having access
  to weird machines is kindly requested to verify if things work


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@2732 c92efa57-630b-4861-b058-cf58834340f0
2006-01-26 16:42:14 +00:00
sbraccia c959d3dda2 Extensive clean-up and reorganisation of the routines for the calculation
of potential energy and free-energy barriers.
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@2186 c92efa57-630b-4861-b058-cf58834340f0
2005-09-17 02:35:57 +00:00
giannozz f533b052d5 dbl => DP (defined as previously dbl was)
syntax for declarations: real(DP), without "kind="


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@2135 c92efa57-630b-4861-b058-cf58834340f0
2005-08-28 14:09:42 +00:00
sbraccia 0230fb8de4 Fixed a severe bug in the NEB restart procedure. The broyden optimiser has been made
simpler (the previous version did't work well). C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@2031 c92efa57-630b-4861-b058-cf58834340f0
2005-07-16 15:15:33 +00:00
degironc 285119fa34 seqopn.f90 and diropn.f90 modified in such a way that the name of
all files open by seqopn.f90 and diropn.f90 in the TMP_DIR have the
general form "prefix"."extension" where extension is the only part of
the filename passed as an argument. This should avoid conflicts between
different jobs running at the same time and sharing the same TMP_DIR
(provided they have different prefixes ...)

All examples (from 1 to 26) give the same output as before on my pc.
Please let me know if you notice unexpected behaviours.

stefano

PS: example26 apparently does nothing (even giving the command run_example 7)..
As it uses cp.x which does not use seqopn/diropn routines this behaviour
cannot be due to the present changes.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1963 c92efa57-630b-4861-b058-cf58834340f0
2005-06-17 13:27:38 +00:00
sbraccia 249168882f Fixed some bugs in the code for the computation of free energy barriers.
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1958 c92efa57-630b-4861-b058-cf58834340f0
2005-06-13 16:36:29 +00:00
sbraccia cb6c7438d1 Added new methods and variables for the calculation of potential-energy and free-energy barriers
using neb or smd in a coarse-grained space (as in metadynamics). Still under development.
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1933 c92efa57-630b-4861-b058-cf58834340f0
2005-06-06 17:53:32 +00:00
sbraccia 8d44a2a8fd The new subroutine flush_unit() is used everywhere. C.S.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1904 c92efa57-630b-4861-b058-cf58834340f0
2005-05-25 02:58:35 +00:00
sbraccia 08bedf5dc0 write_save option was not working in parallel (punch() was called by ionode only).
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1756 c92efa57-630b-4861-b058-cf58834340f0
2005-03-25 09:29:23 +00:00
giannozz 28d4c570b4 Compilation problems with SGI (Pascal Thibaudeau)
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1703 c92efa57-630b-4861-b058-cf58834340f0
2005-03-11 14:23:37 +00:00
sbraccia 83d7f3a5e2 Fixed a bug in the way wg_set variable was initialised (problem affecting parallel NEB calculations).
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1698 c92efa57-630b-4861-b058-cf58834340f0
2005-03-09 17:54:38 +00:00
sbraccia 198649869c Fixed other problems related to the image-parallelisation of NEB and SMD.
Documentation updated.
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1616 c92efa57-630b-4861-b058-cf58834340f0
2005-02-06 11:04:03 +00:00
sbraccia 5f87767056 Fixed some bugs in path_base. image-parallelisation of NEB and SMD modified in order
to be compatible with global filesystems exported via NFS (needed by N.Marzari's group).
NEB and SMD still require a global filesystem.
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1611 c92efa57-630b-4861-b058-cf58834340f0
2005-02-01 16:59:22 +00:00
sbraccia c9f34109db The code which implements the zero temperature string dynamics in pwscf has been rewritten.
Added The Broyden acceleration scheme for path optimisations (not yet tested).
Finite temperature string dynamics (langevin dynamics) fully implemented (for the moment only in pwscf).
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1603 c92efa57-630b-4861-b058-cf58834340f0
2005-02-01 10:36:23 +00:00
sbraccia 7b022ce276 Order in wavefunctions extrapolation made independent from the order in potential extrapolation.
The input keyword "potential_extrapolation" has been substituted by two separate keywords "pot_extrapolation" and "wfc_extrapolation".
Default values are still 'atomic' for the former and 'none' for the latter. Documentation updated.
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1551 c92efa57-630b-4861-b058-cf58834340f0
2005-01-10 06:56:14 +00:00
sbraccia e5724fd85c Fixed a bug in the potential-extrapolation occurring in the case of
path-optimizations (neb and smd). Some cleanup.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1520 c92efa57-630b-4861-b058-cf58834340f0
2004-12-21 15:28:30 +00:00
sbraccia 01023df017 path optimization:
1) cleanup of the output format (more informative)
   2) some cleanup of internal routines
   3) added a couple of input variables and changed the default value
      of ds from 1.5 to 1.0.
BFGS optimization:
   1) implemented a mixed BFGS + Murtag-Sargent update of the inverse
      hessian which is generally faster than the pure BFGS
   2) trust_radius_max increased to 0.8 bohr
   3) some cleanup of internal routines
(C.S.)


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1414 c92efa57-630b-4861-b058-cf58834340f0
2004-11-03 09:53:12 +00:00
giannozz 1648ab6bf2 Patches from Axel Kohlmayer:
- iotk_scan in iotk_module had a mixed up 'intent' statement.
- sun ultra fire 3 compiler warnings
- cleanup in filename length (brought to 256)
- cleanup in include files


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1399 c92efa57-630b-4861-b058-cf58834340f0
2004-10-26 09:32:48 +00:00
sbraccia dddea80703 Fixed an error in the output style.
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1377 c92efa57-630b-4861-b058-cf58834340f0
2004-10-13 17:23:01 +00:00
sbraccia 48343531bd Fixed a bug in get_new_image spotted by Axel Kohlmeyer.
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1346 c92efa57-630b-4861-b058-cf58834340f0
2004-09-27 14:49:26 +00:00
sbraccia f50f901233 path optimizations: added the possibility to write the prefix.save file (logical varible write_save) relative to each
image (needed for post-processing). C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1290 c92efa57-630b-4861-b058-cf58834340f0
2004-09-15 12:35:54 +00:00
sbraccia d111847365 The wrong unit was flushed. C.S.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1153 c92efa57-630b-4861-b058-cf58834340f0
2004-08-23 08:41:36 +00:00
sbraccia 35889dacc2 "#include "f_defs.h"" was missing. C.S.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1152 c92efa57-630b-4861-b058-cf58834340f0
2004-08-23 07:13:30 +00:00
sbraccia 30f8c1fea0 Fixed several bugs in the routines for "path-optimization":
"reset_vel" input variable was read but not used
parallelization on images was not properly working
clueanup in the way ATOMIC_POSITIONS card is read.
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1151 c92efa57-630b-4861-b058-cf58834340f0
2004-08-23 06:51:19 +00:00
sbraccia 71f59fbcb2 NEB code reorganization. All the routines involved in "path" optimization
are grouped into modules starting with "path_". The output has been slightly
restyled. In the pwscf code (only) has been implemented a version of the string
method (calculation='smd') in which the path is represented in Fourier components
and the optimization procedure is done on these components (still to be
optimized, but working).
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1119 c92efa57-630b-4861-b058-cf58834340f0
2004-08-18 15:53:01 +00:00
deinzer 3ac7daa2ee Calculation of the dynamical matrices for the dispersion
is now within ph.x possible.
New input variables:
lnscf: if .true. the nscf and phonon run are done in one single run

ldisp: if .true. calculation of dyn. matrices for dispersion
nq1, nq2, nq3: q-point mesh


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1017 c92efa57-630b-4861-b058-cf58834340f0
2004-06-28 10:08:53 +00:00
sbraccia 2058195fda Cleanup of the molecular dynamics routines. Some debug messages removed. Some duplicated variables (fixatom and if_pos) removed from pwcom (already present in ions_base). A logical variable lfixatom added in control_flags. The output of a molecular dynamics run has been slightlychanged to be (hopefully) clearer.
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@951 c92efa57-630b-4861-b058-cf58834340f0
2004-06-11 16:53:16 +00:00
sbraccia 84b9de5210 Some bugs fixed in NEB
1) Modules/neb_base.f90: the neb error is computed as done in structural
optimizations (convergence when the largest component of the force vector is
less than a threshold).  The rescaling of the elstic constants has been
modified so that they can not be smaller than a minimum value (set to 0.05).
2) PW/compute_scf.f90: a bug in the way startingpot and startingwfc were used
inside neb has been fixed (now scf should be faster).
3) PW/pwscf.f90: cleanup of module-dependencies.
4) pwdocs/INPUT_PW: documentation updated (a detailed explanation of how to
specify initial configurations has been added).
5) PW/neb_routines.f90: file no longer needed


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@943 c92efa57-630b-4861-b058-cf58834340f0
2004-06-07 07:43:53 +00:00