Commit Graph

18 Commits

Author SHA1 Message Date
giannozz 7059811a79 There isn't any good reason to keep including f_defs.h in fortran files:
preprocessing of cmplx is not really needed; preprocessing of blas and
lapack routine names is no longer complete (there are lowercase blas and
lapack) and no longer needed anyway (no more old-stile cray and nec, no
more problems on PCs with underscores)


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5788 c92efa57-630b-4861-b058-cf58834340f0
2009-08-01 13:41:56 +00:00
giannozz 8f4019172a The Ylm used in Berry's phase calculation were inconsistent with the
Clebsh-Gordan coefficients, calculated for a different set of Ylm.
Moreover the call to the routine calculating Ylm was incorrect.
The error was small (it affected only the US part with l>0) but not
negligible. I don't know if it is fixed now, but it wasn't correct
before for sure. Berry's phase calculation extended to L=3.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@4376 c92efa57-630b-4861-b058-cf58834340f0
2007-10-30 08:18:46 +00:00
giannozz 617347620a Spherical Bessel functions j_l(x) are evaluated using the analytical form
for x > xseries, a series expansion for x < xseries. The original value
of xseries, 0.01, was apparently too small and was causing loss of
precision and trouble in pseudopotential generation. xseries is now
increased to 0.05, close to what was used by the no longer existing
routine "sph_besr".


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3929 c92efa57-630b-4861-b058-cf58834340f0
2007-05-03 08:38:01 +00:00
giannozz 8ed4b6b4b6 Yet another glitch in the spherical bessel functions: if l==0, there can
be a 0^0 situation if r(1) = 0 - Thanks to Givanni Cantele and his alphas
to point out this problem


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3547 c92efa57-630b-4861-b058-cf58834340f0
2006-11-20 10:28:59 +00:00
giannozz 7acde7f821 Bug fixed in the new routine for spherical bessel function calculation
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3318 c92efa57-630b-4861-b058-cf58834340f0
2006-08-09 16:01:03 +00:00
giannozz 144e14503a Minor fix to spherical bessel functions (again)
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3300 c92efa57-630b-4861-b058-cf58834340f0
2006-07-28 13:00:51 +00:00
cavazzon 5708020451 - bug fix, variable ir0 was used before its definition.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3298 c92efa57-630b-4861-b058-cf58834340f0
2006-07-28 10:38:23 +00:00
giannozz 737ce089cf More spherical bessel cleanup
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3297 c92efa57-630b-4861-b058-cf58834340f0
2006-07-27 17:06:26 +00:00
giannozz aca4bd5e82 Calculation of spherical bessel functions now uses a series expansion
for small values of the arguments - it should be numericaly more stable
especially for high l - PLEASE CHECK
 CVS: ----------------------------------------------------------------------


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3287 c92efa57-630b-4861-b058-cf58834340f0
2006-07-26 13:22:14 +00:00
giannozz f533b052d5 dbl => DP (defined as previously dbl was)
syntax for declarations: real(DP), without "kind="


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@2135 c92efa57-630b-4861-b058-cf58834340f0
2005-08-28 14:09:42 +00:00
cavazzon 856d5ced1f - fpmd2upf made more user friendly
- sph_bes, check on small G changed to avoid
  problems with log. atomic grid , that are dense near 0


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1921 c92efa57-630b-4861-b058-cf58834340f0
2005-05-27 13:49:19 +00:00
degironc 5c5a3b4826 13 Dec 2004 sph_bes.f90 in flib was incorrect for some high value of l (SdG)
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1505 c92efa57-630b-4861-b058-cf58834340f0
2004-12-13 13:11:22 +00:00
cavazzon 95be051359 - sph_bes.f90 fix for parallel compilation
- input.f90 workaround for xlf internal compiler error


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1470 c92efa57-630b-4861-b058-cf58834340f0
2004-11-24 12:01:21 +00:00
sbraccia d073595767 Further cleanup of bessel functions. sph_besr moved from atomic to flib.
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1453 c92efa57-630b-4861-b058-cf58834340f0
2004-11-17 13:35:03 +00:00
sbraccia 36c6f48b0f Cleanup of spherical bessel functions.
Added a routine to compute the derivativs of spherical bessel functions (used by calc_btq).
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1450 c92efa57-630b-4861-b058-cf58834340f0
2004-11-17 12:05:53 +00:00
giannozz 0b1a5c9fd8 Extensive module cleanup: DP moved from wrong place (parameters) to the
correct place (kinds); module "varie" replaced by "control_flags" (not
yet in pwcom, though) - many many files changed.
64-bit cpus (Opteron, maybe Itanium) should now work if __LINUX64 is defined


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@513 c92efa57-630b-4861-b058-cf58834340f0
2004-01-23 15:08:03 +00:00
cavazzon 6ef446e00d - forgotten enddo when __MASS is undefined
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@116 c92efa57-630b-4861-b058-cf58834340f0
2003-03-08 11:06:20 +00:00
cavazzon 762fc21160 - bessel functions subroutine sph_bes.f moved to flib and updated
with a vector mass interface.
- lapack_ibm.f updated to be used with PW


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@115 c92efa57-630b-4861-b058-cf58834340f0
2003-03-07 17:22:36 +00:00