Commit Graph

27 Commits

Author SHA1 Message Date
giannozz 2c33624a94 Unneeded PAW initialization for non-PAW atoms could lead to crashes
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@10803 c92efa57-630b-4861-b058-cf58834340f0
2014-03-15 14:46:02 +00:00
kucukben 5927a3f961 Bug fix for NC pseudos w GIPAW info, for upf version 2 only.
Pseudo local potential was written/read wrong. 
Many thanks to Andrea Dal Corso for reporting!


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@9675 c92efa57-630b-4861-b058-cf58834340f0
2012-11-27 13:57:46 +00:00
kucukben bd4de04b64 Thanks to Andrea Dal Corso, a harmless bug is fixed.
vlocal_ae and _ps were swapped in read-in, 
but they are only used for EPR calculations, 
which cannot be performed for paw_as_gipaw=.true. anyways.



git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@9673 c92efa57-630b-4861-b058-cf58834340f0
2012-11-27 11:39:10 +00:00
giannozz e2a842f39a Internal routines read_something renamed read_upf_something to avoid confusion
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@8634 c92efa57-630b-4861-b058-cf58834340f0
2012-02-13 20:29:47 +00:00
kucukben b4cd2c9e41 bug fixes:
- code was not stopping anymore when two inconsistent dft were given
 - default for non-local correlation is set to "   " AND upf%dft is trimmed 
   before being written by write_upf_v2.f90. Therefore older versions of pw
   will still work if no vdW is present
 - inlc label for vdw-df is set as VDW1, consistently with the comment and 
   needed to avoid matching conflict with VDW2

ekb+sdg



git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7822 c92efa57-630b-4861-b058-cf58834340f0
2011-05-26 11:53:24 +00:00
dalcorso ba2d1dea99 Bug fix: a recent change in a upf v2 tag was not made in the PP reader.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7575 c92efa57-630b-4861-b058-cf58834340f0
2011-03-15 13:42:15 +00:00
giannozz e81eaafb98 Added the possibility to save into the UPF file pseudopotential in
semilocal form (if existing). Nonrelativistic case only, no idea whether
ld1 does the correct thing: anyway there is no code reading the new field.
Version number of UPF moved to 2.1.0, just in case.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7516 c92efa57-630b-4861-b058-cf58834340f0
2011-02-22 18:38:13 +00:00
giannozz 32e0af51be Several '' (nonstandard) replaced with ' ' (standard), or with "
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7288 c92efa57-630b-4861-b058-cf58834340f0
2010-12-07 16:17:49 +00:00
marsamos 09470669bd add gipaw part with paw_as_gipaw. Thank's to Emine Kucukbenli.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@6885 c92efa57-630b-4861-b058-cf58834340f0
2010-07-06 12:04:34 +00:00
giannozz cbc0b94c86 two bugs triggered by setting initial values different from zero to integer:
1) read_upf_v2 returns an unset error code, 2) variables meta_ionode,
meta_ionode_id are set in an absurd way


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@6554 c92efa57-630b-4861-b058-cf58834340f0
2010-03-27 10:46:09 +00:00
dalcorso bac79d8452 Improved generation of FR PAW dataset.
Modification to the UPF format: the small components of the all-electron
partial waves exported and imported in the FR case.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@6487 c92efa57-630b-4861-b058-cf58834340f0
2010-03-13 10:45:42 +00:00
giannozz a3a39fc998 Cleanup: uniform spelling for "Quantum ESPRESSO", removal of f_defs.h,
CMPLX is explicitly typed, blas/lapack are lowercase (consistently with
the convention: FORTRAN COMMANDS = uppercase, all the rest lowercase)


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5789 c92efa57-630b-4861-b058-cf58834340f0
2009-08-01 14:26:46 +00:00
giannozz 4e27791b59 Bug fix: Coulomb PP in UPF v.2 format was not working (courtesy of
Andrea Ferretti)


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5550 c92efa57-630b-4861-b058-cf58834340f0
2009-05-05 07:11:40 +00:00
giannozz 3497eb0a49 Nonstandard line continuantions again
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5521 c92efa57-630b-4861-b058-cf58834340f0
2009-04-15 07:11:00 +00:00
paulatto 8140bf6589 UPFv2.0.1 introduced with a check for bug reported by ADC on 2009/03/16
(In the new UPF-PP format some components of qrad were not written in the
UPF file) in order to force re-generation of bad pseudos.
LP


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5495 c92efa57-630b-4861-b058-cf58834340f0
2009-04-02 16:11:13 +00:00
paulatto c6b7fadf58 Added PAW (and UPF with l-dependent augmentation) support for real-space
augmentation. Fixed an harmless but annoying bug that caused the coed to
access upf%qfcoef even when they were not used.
LP


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5403 c92efa57-630b-4861-b058-cf58834340f0
2009-02-12 14:53:45 +00:00
dalcorso b8a15de5be Bug fix: some variables were allocated twice in the reader of the new pp
format.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5351 c92efa57-630b-4861-b058-cf58834340f0
2009-01-15 16:34:59 +00:00
cavazzon 1ddc5f0539 - pseudo_type/grid nullification still was giving problem (gfortran).
- Logic now changed, variables are nullified as soon as they are
  instantiated. radial_grid rgrid made allocatable
- all tests passed with ifort. xlf, pgi, gfortran will follow


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@4838 c92efa57-630b-4861-b058-cf58834340f0
2008-04-27 08:58:55 +00:00
paulatto cf72423040 nullify_pseudo_upf: modified according to advice from Nathalie, plus added a few missing "nullify"
fixed a few overflows in atomic (atomic/atomic_paw.f90, atomic/partial_wave_expansion.f90)
fixed a few wrong format specifiers (Modules/write_upf_v2.f90)
try to make error messages from self-consistency in atomic easier to interpret and fix
    (atomic/ascheqps.f90)
added a mechanism to save the configuration used to generate it in the INFO section of
a pseudopotential.

LP


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@4836 c92efa57-630b-4861-b058-cf58834340f0
2008-04-24 15:26:26 +00:00
paulatto ccb9711221 bugfix, thanks to GS
LP


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@4815 c92efa57-630b-4861-b058-cf58834340f0
2008-04-16 13:33:43 +00:00
paulatto 651f6ec9c3 On popular request: added the possibility to save all-electron and pseudo
wavefunctions in the UPF (only v2) file. Pseudopotential and documentation
changed accordingly.
LP


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@4811 c92efa57-630b-4861-b058-cf58834340f0
2008-04-16 10:12:11 +00:00
paulatto 15d12e7963 Bugfixes, Oxygen PAW pseudopotential replaced with more usable ones.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@4790 c92efa57-630b-4861-b058-cf58834340f0
2008-04-11 12:32:27 +00:00
paulatto 9e54c7448f Some more bugfixes and updates in UPF file formats, now it should be almost
finished.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@4787 c92efa57-630b-4861-b058-cf58834340f0
2008-04-09 14:51:58 +00:00
giannozz d268e2b83a Apparently there are compilers that accept the syntax a**-1, a**-2, a**-3,
but this is not standard as far as I know!


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@4776 c92efa57-630b-4861-b058-cf58834340f0
2008-04-06 14:50:21 +00:00
paulatto 49e4c0ad23 More bugfixes and pseudos updated accordingly. Paw tests updated again to reduce time a bit..
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@4773 c92efa57-630b-4861-b058-cf58834340f0
2008-04-04 14:01:35 +00:00
paulatto 3fd2de8d61 Bugfixes, removed unnecessary pseudo-upf_meta_info type, paw tests and datasets updated
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@4771 c92efa57-630b-4861-b058-cf58834340f0
2008-04-04 09:12:30 +00:00
paulatto ba4e005094 This is a quite complex check-in, but actually not very much is done. Changelog follows.
LP

UPF file format updated completely, UPFv2 introduced:
* ld1.x can still produce old format, with the switch upf_v1_format=.true. in inputp
  this is disabled by default, but we can discuss if it should be the opposite.
* pw.x cp.x and all utilities should notice no difference
* some utilities in upftools still need to be updated, anyway conversion UPFv1 to UPFv2
  is very easy, so this should be no big issue
* starting from now to produce an UPF file you need to fill the pseudo_upf derivedd type
  and feed it to write_upf woutine in upf_module (Modules/upf.f90)
* extensive use of iotk

I have tried to make the new format as self contained as possible, e.g. there should be
minimal need for post-processing after the data is read, no more reconstruction of known
quantities, and no more odd syntax to save negligible quantity of space. Also the human
readable section is a bit richer, all the rest is more machine readable.

I hope this will not cause any throuble, and tried really hard to, all examples and all
tests works as fine as before and gives (what really looks like) the same results.

Other changes that I needed to make:
* radial grids are now allocatable, they management is a bit less of a hack too
* paw and uspp augmentation are stored in the same place
* paw print total all-electron energy if all atoms are paw, not very useful, but nice
* most of the pseudopotential-writing reading files have been renamed to  some more
  logical name, I spare you the list. E.g. read_oldpseudo -> read_pseudo_rrkj3
* paw_t derived type was only used in atomic, so I have put it there (as the pseudo_type
  module take ages to recompile it was awkward to leave it there).

PAW tests inserted in test/ there are 6 of them, as a consequence I have also put 5 paw
pseudopotentials in the pseudo/ directory.

I will update the PAW scf examples soon, by deleting them (as running a pw with a PAW
pseudopotential requires no option at all). PAW generation examples should be updated.

A lot of small bugfixes here & there mostly uninitialized variables or unallocated
pointers used as subrotuine arguments.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@4769 c92efa57-630b-4861-b058-cf58834340f0
2008-04-03 15:50:43 +00:00