Commit Graph

25 Commits

Author SHA1 Message Date
giannozz 3ee0e520b6 More variable unification: module gvecs and gsmooth merged (new name: gvecs),
module gvect, gvecp, reciprocal_vectors merged (new name: gvect)


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7348 c92efa57-630b-4861-b058-cf58834340f0
2010-12-24 10:19:22 +00:00
giannozz 77648909ed Variable nrxxs removed from module gvect. Either the value in module
smooth_grid_dimensions or in dffts%nnr is used instead. Lots of changes
but nothing substantial. Beware unintended side effects


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7164 c92efa57-630b-4861-b058-cf58834340f0
2010-10-24 08:05:12 +00:00
degironc ab22d62203 Hidden dependency of incdrhoscf_nc.f90 on dpsi (passed through a module) is
made explicit passing it as an argument.
Calling routines modified accordingly.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7088 c92efa57-630b-4861-b058-cf58834340f0
2010-09-14 14:07:21 +00:00
degironc 1ec328bfe4 Hidden dependency of incdrhoscf.f90 on dpsi (passed through a module) is
made explicit passing it as an argument.
Calling routines modified accordingly.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7087 c92efa57-630b-4861-b058-cf58834340f0
2010-09-14 13:42:51 +00:00
giannozz 022b4ecc24 More cft3/cft3s => fwfft/invfft conversion
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@7026 c92efa57-630b-4861-b058-cf58834340f0
2010-08-28 13:48:36 +00:00
giannozz afec752184 End of this set of not-so-fundamental changes. Summary:
1) no more f_defs.h file to be included in fortran files
2) all CMPLX explicitly defined as CMPLX(...,KIND=dp)
3) blas/lapack names in lowercase (not all of them, actually)
4) documentation accordingly updated (plus unrelated changes to user_guide)


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5805 c92efa57-630b-4861-b058-cf58834340f0
2009-08-03 09:19:02 +00:00
dalcorso a2b5ab5e50 Minor partial cleanup. Many routines declared unused variables. Many others
could be cleaned.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5445 c92efa57-630b-4861-b058-cf58834340f0
2009-02-25 15:58:53 +00:00
dalcorso c2bdfb0086 Further cleanup of the phonon code. The indeces of k and k+q are no more
recalculated in every routine.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5371 c92efa57-630b-4861-b058-cf58834340f0
2009-02-04 10:25:03 +00:00
dalcorso 1d2ceae531 Minor cleanup of the phonon code (part 2). USE phcom and USE pwcom
substituted by multiple USE statements.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5368 c92efa57-630b-4861-b058-cf58834340f0
2009-02-04 08:28:27 +00:00
giannozz 1404b5f8cd More pwcom splitting into modules
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5211 c92efa57-630b-4861-b058-cf58834340f0
2008-09-24 11:50:31 +00:00
dalcorso 0f789e0289 Clean up.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@5137 c92efa57-630b-4861-b058-cf58834340f0
2008-08-27 16:45:56 +00:00
dalcorso 337c243906 In the routine incdrhoscf the variable mode is not used.
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@3753 c92efa57-630b-4861-b058-cf58834340f0
2007-02-06 15:46:49 +00:00
giannozz f533b052d5 dbl => DP (defined as previously dbl was)
syntax for declarations: real(DP), without "kind="


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@2135 c92efa57-630b-4861-b058-cf58834340f0
2005-08-28 14:09:42 +00:00
giannozz bf4bfe222f General cleanup of intrinsic functions:
conversion to real    => DBLE
(including real part of a complex number)
conversion to complex => CMPLX
complex conjugate     => CONJG
imaginary part        => AIMAG

All functions are uppercase.
CMPLX is preprocessed by f_defs.h and performs an explicit cast:
#define CMPLX(a,b)  cmplx(a,b,kind=DP)
This implies that 1) f_defs.h must be included whenever a CMPLX is present,
2) CMPLX should stay in a single line, 3) DP must be defined.

All occurrences of real, float, dreal, dfloat, dconjg, dimag, dcmplx
removed - please do not reintroduce any of them.
Tested only with ifc7 and g95 - beware unintended side effects

Maybe not the best solution (explicit casts everywhere would be better)
but it can be easily changed with a script if the need arises.
The following code might be used to test for possible trouble:

program test_intrinsic

  implicit none
  integer, parameter :: dp = selected_real_kind(14,200)
  real (kind=dp) :: a = 0.123456789012345_dp
  real (kind=dp) :: b = 0.987654321098765_dp
  complex (kind=dp) :: c = ( 0.123456789012345_dp, 0.987654321098765_dp)

  print *, '      A = ', a
  print *, ' DBLE(A)= ', DBLE(a)
  print *, '      C = ', c
  print *, 'CONJG(C)= ', CONJG(c)
  print *, 'DBLE(c),AIMAG(C)  = ', DBLE(c), AIMAG(c)
  print *, 'CMPLX(A,B,kind=dp)= ', CMPLX( a, b, kind=dp)

end program test_intrinsic

Note that CMPLX and REAL without a cast yield single precision numbers on
ifc7 and g95 !!!


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@2133 c92efa57-630b-4861-b058-cf58834340f0
2005-08-26 17:44:42 +00:00
sbraccia 0caeadbd7b Machine-dependent definitions are now contained in two different files (both in /include):
1) f_defs.h  for definitions to be included in FORTRAN files ONLY
   2) c_defs.h  for definitions to be included in C       files ONLY

C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@1012 c92efa57-630b-4861-b058-cf58834340f0
2004-06-25 17:25:37 +00:00
sbraccia d1579c66ec Removed references (not yet everywhere) to module basis for those variables already in module ions_base.
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@953 c92efa57-630b-4861-b058-cf58834340f0
2004-06-12 13:44:18 +00:00
giannozz 47c5de62f8 More USPP_related variables moved to Modules/uspp.f90
Note that lqx => lmaxq for consistency with other names
(those ending in x are static dimensioning)
Beware unexpected side effects (PG)


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@933 c92efa57-630b-4861-b058-cf58834340f0
2004-05-31 17:55:33 +00:00
giannozz 509459fc93 Cleanup in PH/ and D3/, setv removed (please verify collateral damages!)
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@698 c92efa57-630b-4861-b058-cf58834340f0
2004-03-07 13:47:42 +00:00
giannozz 0b1a5c9fd8 Extensive module cleanup: DP moved from wrong place (parameters) to the
correct place (kinds); module "varie" replaced by "control_flags" (not
yet in pwcom, though) - many many files changed.
64-bit cpus (Opteron, maybe Itanium) should now work if __LINUX64 is defined


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@513 c92efa57-630b-4861-b058-cf58834340f0
2004-01-23 15:08:03 +00:00
cavazzon c5d8ff2f66 - unit 6 replaced by stdout in CPV
- ^M removed from pseudo files
- wavefunctions arrais moved to module
  wavefunctions_module, common to all codes
  this is required to reduce duplicated subroutine
- new lapack subroutine, called from PWCOND,
  added to lib/lapack.f lib/lapack_ibm.f


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@381 c92efa57-630b-4861-b058-cf58834340f0
2003-11-09 10:42:50 +00:00
sbraccia 871e3677b3 Unit stdout (set in Modules/io_global.f90) is used to write on standard output
instead of 6 or *.
C.S.


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@374 c92efa57-630b-4861-b058-cf58834340f0
2003-11-05 19:01:20 +00:00
cavazzon 1d34b5c0a8 non collinear spin version of PW,
contributed by Adriano Mosca Conte,
added to the repository.
The non collinear code has required
a new module "wavefunctions" containing
"psic" and "evc", that no longer belong
to pwcom.

use: cvs update -d

there's a new example (example13), that is not
yet complete, I'm waiting for the appropriate
pseudopotential from Adriano


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@322 c92efa57-630b-4861-b058-cf58834340f0
2003-10-03 14:01:11 +00:00
degironc c830a68c37 22 apr 2003 All setv statements in PW repalaced by f90 constructs.
Minor changes in PW & PH (code readability).


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@178 c92efa57-630b-4861-b058-cf58834340f0
2003-04-22 16:03:45 +00:00
giannozz d852392cab module allocate, calls to mallocate, mfree removed
pointers replaced by allocatable whenever possible


git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@56 c92efa57-630b-4861-b058-cf58834340f0
2003-02-07 16:04:36 +00:00
giannozz ac9f2144c0 O-sesame
git-svn-id: http://qeforge.qe-forge.org/svn/q-e/trunk/espresso@2 c92efa57-630b-4861-b058-cf58834340f0
2003-01-19 21:58:50 +00:00