mirror of https://github.com/Qiskit/qiskit.git
e17af6a56a
* WIP * Add try_const to lift. * Try multiple singletons, new one for const. * Revert "Try multiple singletons, new one for const." This reverts commit e2b32212533a52b30fecb700ed36a7f9e93a19a6. * Remove Bool singleton test. * Add const handling for stores, fix test bugs. * Fix formatting. * Remove Duration and Stretch for now. * Cleanup, fix const bug in index. * Fix ordering issue for types with differing const-ness. Types that have some natural order no longer have an ordering when one of them is strictly greater but has an incompatible const-ness (i.e. when the greater type is const but the other type is not). * Fix QPY serialization. We need to reject types with const=True in QPY until it supports them. For now, I've also made the Index and shift operator constructors lift their RHS to the same const-ness as the target to make it less likely that existing users of expr run into issues when serializing to older QPY versions. * Make expr.Lift default to non-const. This is probably a better default in general, since we don't really have much use for const except for timing stuff. * Revert to old test_expr_constructors.py. * Make binary_logical lift independent again. Since we're going for using a Cast node when const-ness differs, this will be fine. * Update tests, handle a few edge cases. * Fix docstring. * Remove now redundant arg from tests. * Add const testing for ordering. * Add const tests for shifts. * Add release note. * Add const store tests. * Address lint, minor cleanup. * Add Float type to classical expressions. * Allow DANGEROUS conversion from Float to Bool. I wasn't going to have this, but since we have DANGEROUS Float => Int, and we have Int => Bool, I think this makes the most sense. * Test Float ordering. * Improve error messages for using Float with logical operators. * Float tests for constructors. * Add release note. * Add Duration and Stretch classical types. A Stretch can always represent a Duration (it's just an expression without any unresolved stretch variables, in this case), so we allow implicit conversion from Duration => Stretch. The reason for a separate Duration type is to support things like Duration / Duration => Float. This is not valid for stretches in OpenQASM (to my knowledge). * Add Duration type to qiskit.circuit. Also adds support to expr.lift to create a value expression of type types.Duration from an instance of qiskit.circuit.Duration. * Block Stretch from use in binary relations. * Add type ordering tests for Duration and Stretch. Also improves testing for other types. * Test expr constructors for Duration and Stretch. * Fix lint. * Implement operators +, -, *, /. * Add expression tests for arithmetic ops. * Implement stretch support for circuit. * Initial support for writing QASM3. * Support duration and stretch expressions in Delay. * Reject const vars in add_var and add_input. Also removes the assumption that a const-type can never be an l-value in favor of just restricting l-values with const types from being added to circuits for now. We will (in a separate PR) add support for adding stretch variables to circuits, which are const. However, we may track those differently, or at least not report them as variable when users query the circuit for variables. * Implement QPY support for const-typed expressions. * Remove invalid test. This one I'd added thinking I ought to block store from using a const var target. But since I figured it's better to just restrict adding vars to the circuit that are const (and leave the decision of whether or not a const var can be an l-value till later), this test no longer makes sense. * Update QPY version 14 desc. * Fix lint. * Add serialization testing. * Test pre-v14 QPY rejects const-typed exprs. * QASM export for floats. * QPY support for floats. * Fix lint. * Settle on Duration circuit core type. * QPY serialization for durations and stretches. * Add QPY testing. I can't really test Stretch yet since we can't add them to circuits until a later PR. * QASM support for stretch and duration. The best I can do to test these right now (before Delay is made to accept timing expressions) is to use them in comparison operations (will be in a follow up commit). * Fix lint. * Add arithmetic operators to QASM. * QPY testing for arithmetic operations. * QASM testing for arithmetic operations. * Update tests for blocked const vars. We decided to punt on the idea of assigning const-typed variables, so we don't support declaring stretch expressions via add_var or the 'declarations' argument to QuantumCircuit. We also don't allow const 'inputs'. * Only test declare stretch QASM; fix lint. * Special case for stretch in add_uninitialized_var. At the moment, we track stretches as variables, but these will eventually make their way here during circuit copy etc., so we need to support them even though they're const. * Remove outdated docstring comment. * Remove outdated comment. * Support Delay duration expression in transpiler. * Improve docstring for Delay. * Error when stretch is used in a circuit during scheduling. * Don't use match since we still support Python 3.9. * Block const stores. * Fix enum match. * Fix bad merge. * Add a few more serialization tests. * Fix lint. * Add additional testing for Duration expression eval. * Fix missing round when converting expr to 'dt'. * Revert visitors.py. * Address review comments. * Improve type docs. * Revert QPY, since the old format can support constexprs. By making const-ness a property of expressions, we don't need any special serialization in QPY. That's because we assume that all `Var` expressions are non-const, and all `Value` expressions are const. And the const-ness of any expression is defined by the const-ness of its operands, e.g. when QPY reconstructs a binary operand, the constructed expression's `const` attribute gets set to `True` if both of the operands are `const`, which ultimately flows bottom-up from the `Var` and `Value` leaf nodes. * Move const-ness from Type to Expr. * Revert QPY testing, no longer needed. * Add explicit validation of const expr. * Revert stuff I didn't need to touch. * Update release note. * A few finishing touches. * Fix-up after merge. * Fix-ups after merge. * Fix lint. * Fix comment and release note. * Fixes after merge. * Fix test. * Fix lint. * Special-case Var const-ness for Stretch type. This feels like a bit of a hack, but the idea is to override a Var to report itself as a constant expression only in the case that its type is Stretch. I would argue that it's not quite as hack-y as it appears, since Stretch is probably the only kind of constant we'll ever allow in Qiskit without an in-line initializer. If ever we want to support declaring other kinds of constants (e.g. Uint), we'll probably want to introduce a `expr.Const` type whose constructor requires a const initializer expression. * Address review comments. * Update release note. * Update docs. * Add release notes and doc link. * Address review comments. * Remove Stretch type. * Remove a few more mentions of the binned stretch type. * Add docstring for Duration. * Remove Stretch type stuff. * WIP * Track stretch variables throughout circuits. * Update QASM exporter. * Fix existing tests and found bugs. * Fix format. * Simplify structural eq visitor. * Add num_identifiers. * Support QPY. * Implement QASM visit for stretch expr. * Track stretches through DAGCircuit. * Add visit_stretch to classical resource map. * Fix lint. * Some merge fixes. * Address review comments. * Remove unused import. * Represent stretch with StretchDeclaration in QASM AST. Previously, we used StretchType within a ClassicalDeclaration, but this wasn't the best fit. * Remove visitor short circuit. * Address review comments. * Address review comments. * Support division by Uint. * Add release note. * Fix lint. * Add test for QASM example. * Add missing DAG stretch plumbing. * Fix test. * Fix QPY serialization bug. * Fix lint. * Add qpy test. * Support remapping for stretch variables in compose. * Fix qpy compat test. * Add negative test for QPY stretch expr. * Add more circuit testing. * Fix tests after merge. * Add control flow builder tests. * Add circuit equality testing for stretch. * Refer to 'stretches' instead of 'stretch variables'. * Remove | None for Stretch.name * Address review comments. * Update QPY desc. * Fix num_identifiers. * Fix merge for control flow tests. * Address review comments. * Fix docstrings. * Use Union instead of | for QC delay. Python 3.9 might not define the | operator for ParameterValueType since it's an alias. * Update tests for deprecation (sorry!) * Trigger CI. |
||
|---|---|---|
| .. | ||
| __init__.py | ||
| test_export.py | ||
| test_import.py | ||