* Added classical_predecessors method
* add accesed method
* Added classsical_successor method
* Added classical predecessors and successors method
* added tol command
* successors method
* add test classical_successor method
* changed DagOutNode
* Apply suggestions from code review from @atharva-satpute. Thanks!
Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com>
* add assertRaises on test methods
* correct typo variable name
* change the descrption
* change the text on the example
* change the format of yaml
* new example
* new suggestions
* fix test
* new test example and change the release note
* Fixup release note
* Fix typo
---------
Co-authored-by: Maldoalberto <amaldonador1300@alumno.ipn.mx>
Co-authored-by: Maldoalberto <Alberto.Maldonado.Romo@ibm.com>
Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
Co-authored-by: atharva-satpute <55058959+atharva-satpute@users.noreply.github.com>
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
This commit removes the deprecated circuit_cregs argument from the
InstructionSet class. This argument was deprecated in the 0.19.0
release and has been supersceded by the resource_requester.
* Add standard 1q Pauli equivalences to standard library
This makes `transpile` a little more reliable in cases where people are
trying to use it to convert to a constrained basis. We can't
necessarily recognise _all_ possible transformations into an incomplete
basis, but simple Pauli relations are things people may well expect.
* Fix test setup
* added test for inner sequencial custom gates
* fixed quantum circuit qasm test
* fixed qasm method
* added a function to rename the operation
* updated test docstring
* updated recheck operation.name comment
* eblack fix test
* added docs
* lint test
* updated test string format
* Fixup release note
---------
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
The primitives still need to support the legacy
`qiskit.opflow.PauliSumOp` while that object is deprecated but not
removed. However, we do not want the import of `qiskit.primitives` to
need to import `opflow` to do that, since that will cause the
deprecation warnings emitted by the import of `opflow` to be hidden
(they'll be blamed on Qiskit library code, so hidden by default).
All type-hint usage we can hide behind the `TYPE_CHECKING` static
analysis gate. For cases where we were actively runtime type-checking
an object, we can gate the `isinstance` check behind a check that
`qiskit.opflow` is already imported; the object cannot be a `PauliSumOp`
if the module isn't initialised.
* Improve casting and error message for `ParameterExpression`
Previously, we assumed that the only reason a cast of
`ParameterExpression` to `complex`/`float`/`int` could fail was because
of unbound parameters, and emitted an error accordingly. This is not
the case; a fully bound complex value will still fail to convert to
`float`.
This PR improves the error messages in these cases, and works around a
difference of Sympy and Symengine, where the latter will fail to convert
real-valued expressions that were symbollically complex at some point in
their binding history to `float`. Sympy more reliably reduces values
down to real-only values when the imaginary part is exactly cancelled,
which is a use-case our users tend to expect.
* Fix typo in test
* Update releasenotes/notes/parameter-float-cast-48f3731fec5e47cd.yaml
Co-authored-by: Kevin Hartman <kevin@hart.mn>
---------
Co-authored-by: Kevin Hartman <kevin@hart.mn>
* fix measure_v2
* modify measure_all
* dispatch backend
* add test of the builder with backendV2
* reconfigure test codes and some func
* refactoring
* add reno
* fix _measure_v2
* fix backend.meas_map in measure_v2
* fix reno
* delete get_qubit_channels from utils
* add get_qubits_channels in qubit_channels
* recostruct test about the builder with backendV2
* fix descriptions of test_macros
* fix descriptions of test_macros again
* delete import of backendV2 in utils
* revert no need to modify code
* Update releasenotes/notes/fix-dispatching-backends-28aff96f726ca9c5.yaml
Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
* Update a commnet in qiskit/pulse/builder.py
Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
* remove import TYPE_CHECKING
* removed test_builder.py utils.py and test_analyzation.py from pull request
---------
Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
* Use stable Python C API for building Rust extension
This commit tweaks the rust extension code to start using the PyO3 abi3
flag to build binaries that are compatible with all python versions, not
just a single release. Previously, we were building against the version
specific C API and that resulted in needing abinary file for each
supported python version on each supported platform/architecture. By
using the abi3 feature flag and marking the wheels as being built with
the limited api we can reduce our packaging overhead to just having one
wheel file per supported platform/architecture.
The only real code change needed here was to update the memory
marginalization function. PyO3's abi3 feature is incompatible with
returning a big int object from rust (the C API they use for that
conversion isn't part of the stable C API). So this commit updates the
function to convert to create a python int manually using the PyO3 api
where that was being done before.
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
* Set minimum version on abi3 flag to Python 3.8
* Fix lint
* Use py_limited_api="auto" on RustExtension
According to the docs for the setuptools-rust RustExtension class:
https://setuptools-rust.readthedocs.io/en/latest/reference.html#setuptools_rust.RustExtension
The best setting to use for the py_limited_api argument is `"auto"` as
this will use the setting in the PyO3 module to determine the correct
value to set. This commit updates the setup.py to follow the
recommendation in the docs.
* Update handling of phase input to expval rust calls
The pauli_expval module in Rust that Statevector and DensityMatrix
leverage when computing defines the input type of the phase argument as
Complex64. Previously, the quantum info code in the Statevector and
DensityMatrix classes were passing in a 1 element ndarray for this
parameter. When using the the version specific Python C API in pyo3 it
would convert the single element array to a scalar value. However when
using abi3 this handling was not done (or was not done correctly) and
this caused the tests to fail. This commit updates the quantum info
module to pass the phase as a complex value instead of a 1 element numpy
array to bypass this behavior change in PyO3 when using abi3.
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
* Set py_limited_api explicitly to True
* DNM: Test cibuildwheel works with abi3
* Add abi3audit to cibuildwheel repair step
* Force setuptools to use abi3 tag
* Add wheel to sdist build
* Workaround abiaudit3 not moving wheels and windows not having a default repair command
* Add source of setup.py hack
* Add comment about pending pyo3 abi3 bigint support
* Revert "DNM: Test cibuildwheel works with abi3"
This reverts commit 8ca24cf1e4.
* Add release note
* Simplify setting abi3 tag in built wheels
* Update releasenotes/notes/use-abi3-4a935e0557d3833b.yaml
Co-authored-by: Jake Lishman <jake@binhbar.com>
* Update release note
* Update releasenotes/notes/use-abi3-4a935e0557d3833b.yaml
---------
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
Co-authored-by: Jake Lishman <jake@binhbar.com>
* * Added support for targets without a coupling map.
* * Removed restrictive raise.
* * Changed order of target and coupling map
* Apply suggestions from code review
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
---------
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
* activate filter method in ScheduleBlock class
* use functools.singledispatch
* add tests for filter method in ScheduleBlock class
* filter out empty schedule_blocks
* update doc
* rm logical_and
* add catch-TypeError functions decorated with singledispatch
* use pulse builder in test
* make another test function for nested block
* add a release note
* Rm optional args
Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
* add warning
Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
* update the release note
Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
* activate exclude method in ScheduleBlock class
---------
Co-authored-by: Naoki Kanazawa <nkanazawa1989@gmail.com>
* Fix QuantumCircuit.draw() not outputting pdf in latex mode
* Added bugfix release note; moved import to the top
* Fixup release note
---------
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
* Assign circuit parameters as int/float to instructions
* Do not test that fully bound parameters are still ParameterExpressions
* Change int to float in qasm output
pi_check casts integers to floats but not integers inside
ParameterExpressions.
* Workaround symengine ComplexDouble not supporting float
* black
* Update releasenotes/notes/circuit-assign-parameter-to-concrete-value-7cad75c97183257f.yaml
Co-authored-by: Jake Lishman <jake@binhbar.com>
* Update releasenotes/notes/circuit-assign-parameter-to-concrete-value-7cad75c97183257f.yaml
Co-authored-by: Jake Lishman <jake@binhbar.com>
* Restore assigned parameter value type check to tests
* Add test to check type and value of simple circuit parameter assignment
* Add consistency check between assigned instruction data and calibrations dict keys
* Add regression test
* Add upgrade note
* Remove support for complex instruction parameter assignment
* Restore complex assignment
Complex assignment maybe not be supported but allowing it in the
parameter assignment step lets validate_parameters get the value and
raise an appropriate exception.
* black
* More specific assertion methods
* Use exact floating-point check
---------
Co-authored-by: Jake Lishman <jake@binhbar.com>
Co-authored-by: John Lapeyre <jlapeyre@users.noreply.github.com>
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
* Fix unitary synthesis for parameterized basis gates in Target
Replace parameterized RXX with RXX(pi / 2) and parameterized RZX with RZX(pi / 4).
* Run black
* Fix dict ordering problem between linux and windows
* Remove unused import
* Try using seed in call to transpile to fix CI fail
Linux and MacOS give one result and Windows another
* Add comments explaining no symbolic gates can be sent to 2q decomposers
* Make test for synthesis in with parameterized basis gate less strict
Windows on the one hand, and MacOS and Linux on other give different circuits
in a simple test of synthesis. Both are correct. This commit makes the test less strict.
* Add release note for fix-issue-10082
* Fix PassManagerConfig.from_backend with BackendV1 and no CouplingMap
This commit fixes an issue in the PassManagerConfig.from_backend
constructor method when using BackendV1 based simulator backends. The
pass was incorrectly handling the case when the backend configuration
didn't have a coupling map defined and incorrectly creating a coupling
map with 0 qubits instead of using None to indicate the lack of
connectivity. This has been fixed so the coupling map creation is
skipped if there is no coupling map attribute in the backend's
configuration.
Fixes#10171
* Fix tests
* Fix top-level `switch` statements in `QuantumCircuit.compose`
The register-mapping code was not being applied to `SwitchCaseOp.target`
in the same way that it is for conditions. This commit does not change
any behaviour about recursing into _nested_ control-flow blocks, which
still likely have problems with composition.
* Apply suggestions from review
The previous logic around building a `Layout` object from an
`initial_layout` was still couched in the "registers own bits" model, so
could not cope with loose bits. It's most convenient to just build the
mapping ourselves during the parsing, since the logic is quite specific
to the form of the `initial_layout` argument, rather than being
something that's inherently tied to the `Layout` class.
This commit fixes an oversight in the 0.24.0 release that caused an
accidental change in the exception raised when attempting to use
BooleanExpression.from_dimacs_file without having tweedledum installed.
In #9754 the detection of tweedledum was updated to avoid import time
detection so that the module can be imported even if tweedledum isn't
installed. This was done through the use of the optionals decorators
so that tweedledum is only attempted to be imported when the
classicalfunction modules is used. However, the decorators don't wrap
classmethod constructors by default and this caused the incorrect
exception type to be raised. This commit fixes this by doing the runtime
checking manually inside the from_dimacs_file constructor.
* fix issue 8687 by moving history attribute tu public by a getter
* callback function
* tests
* add test and reno
* lint
---------
Co-authored-by: Julien Gacon <gaconju@gmail.com>
* added abs method to parameterexpression
* fixed wrong call in abs function
* changed definition of abs to __abs__
* additionally implemented __le__, __ge__, __lt__, __gt__ operators
* fixed requested features and implemented more tests for __lt__, __gt__
* fixed lint errors in parameterexpression and its tests
* fixed formatting error in docstrings
* removed __lt__ and friends, fixed recommendations
* added more tests for abs function
* fixed lint
* added a releasenote to document change
* mod function & add more tests
* add new line at the end of file
* fix lint
* add alias of __abs__ for doc
* mod test_compile_with_ufunc
* add test
* fix test
* fix test
* fix test
* fix test
* fix test
* Update test_parameters.py
* Update releasenotes/notes/add-abs-to-parameterexpression-347ffef62946b38b.yaml
Co-authored-by: Julien Gacon <gaconju@gmail.com>
---------
Co-authored-by: Christopher Zachow <christopher.zachow@sva.de>
Co-authored-by: Julien Gacon <gaconju@gmail.com>
* Deprecate circuit-library Jupyter magic
This has not been used since the switch away from using
`jupyter-execute` in gh-9346, so is neither maintained nor necessary.
Any improvements to styling should be made to the new paths, not to
these. These objects were originally intended only for the
documentation so we expect user impact to be minimal, and the objects
are not maintained anyway.
* Correct versions for deprecation
* Add missing import
This uses the extensibility and the legacy compatiblity data in the new
Rust OpenQASM 2 parser to switch over the old `QuantumCircuit`
constructor methods to the new parser. This gives users of these
methods large speedups while maintaining the same feature set (and
fixing a long-standing bug surrounding `U` and `CX`!).
One test is removed for the circuit methods; the circuit methods are set
to use `strict=False` mode of the new parser, which is more permissive,
including making the empty string an allowable program. The alternative
was to set `strict=True`, which would have made an unrelated test in
`SabreLayout` fail instead due to its slightly improper use of
floating-point values in OpenQASM 2 (the OQ2 spec technically requires
decimal points even in constructs like `1e3`, unlike other languages).
Given that the previously OQ2 importer allowed these floats, it seemed
safer to use `strict=False` mode, which is also generally more
convenient for users.
The tests for the old paths are copied, to ensure they continue working
during their potential deprecation and removal.
* Fix interaction graph vf2 scoring to include 1q component
In #9148 a bug was introduced into the vf2 scoring code. In that PR the
vf2 passes were changed to treat standalone qubits as a special case to
improve the algorithmic efficiency of the pass. However, that PR
broke the scoring algorithm so that it was no longer factoring in the 1q
component of the interaction graph when scoring a layout. This meant
that when scoring a potential layout only the 2q error rates were been
factored into the score and the pass was potentially selecting worse
performing qubits. This commit fixes this error and ensures the scoring
is looking at all the error rates.
* Update qiskit/transpiler/passes/layout/vf2_utils.py
* Drop support for Python 3.7
This updates our documentation and build processes to set Python 3.8 as
the oldest support version of Python, consistent with our policy on
Python support.
This commit also removes remaining Python-version gating, since we were
principally using this to account for differences between 3.7 and 3.8.
Several backport packages are no longer required for any suppported
Python version, because of this change.
* Remove test for multiprocessing on Mac
With Python 3.7 support now dropped, there are no versions of Python on
macOS that we expect to support with multiprocessing again. There's no
guarantee that the hypothetical Python 10.11 (???) that this test was
previously checking would be any more valid than existing versions.
---------
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
* Undo breaking API change in unitary synthesis plugin interface
This commit reverts an unecessary breaking API change that was
introduced in #9175. In that PR the data type for two arguments,
gate_lengths and gate_errors, that was potentially passed to
plugins was changed. This change was well intentioned as it was
used by the default plugin as part of the changes to the default
plugin made in that PR. But this neglected the downstream effects
for any existing plugin interface users relying on the input to
those fields. Making this change to existing fields would break
any plugins that were using the old data format and is a violation
of the Qiskit stability and deprecation policy. This commit reverts
that change so that gate_lengths and gate_errors contain the same data
format as in previous releases. Instead to facilitate the new
workflow a new fields, gate_lengths_by_qubit and gate_errors_by_qubit,
were added that leverage the new format introduced by #9175. By adding
this as new optional fields existing users can continue to work as
before, but the default plugin which requires the different data
format can use the new data type.
* Update docstring
* Fix copy paste error
* Set max_trials for VF2Layout in preset pass managers.
By setting max_trials, we limit the number of layouts
enumerated and scored when iterating through vf2_mapping().
This is necessary for scoring to complete in a reasonable
amount of time for circuits with many connected components
on larger (e.g. 400 qubit) devices.
These limits were chosen using a fake 400 qubit device,
using 200 connected components, where each component is
a single CX gate.
Because layout scoring scales linearly
with the number of qubits in the circuit, 250,000 (O3)
takes abount a minute, 25,000 (O2) takes about 6 seconds,
and 2,500 (O1) takes less than a second.
* Address review comments.
* Return tuple of None instead for finer control and a better interface.
* Add deprecation notice to release note.
* Remove deprecation until 0.25.0.
* Remove unused import.
The root of the problem was the `OpShape` producing a "vector-like"
shape if it detected that "input size" was 1. If both the input and
output dimension are 1, it is instead a 0q operator (scalar).
* Fix decompose with a lable or name
* Finish tests and reno
* Lint
* Remove gate arg and fix parens
* Update QuantumCircuit.decompose doc string
* Unused imports
For the 0.24.0 release we're going to push release candidates
prior to the release to enable testing before we cut the final release.
In preparation for tagging the first release candidate this commit
updates the version string to indicate it's a release candidate. This
commit should be what gets tagged as 0.24.0rc1.
* adding apply_permutation method to Operator class
* modify from_circuit to use apply_permutation
* declaration fix
* reimplementing based on review suggestions, but missing inversion
* fixing inversion
* fixing front vs back
* adding test for reverse_qargs
* Fixing operator dimensions and adding tests
* Fixing operator dimensions and adding tests
Co-authored-by: Gadi Aleksandrowicz <gadial@gmail.com>
* pylint
* adding tests for one-sided permutations on heterogenous qudit spaces
* improving tests following review
* using ddt
* applying suggestions from review
* applying suggestions from review
---------
Co-authored-by: Gadi Aleksandrowicz <gadial@gmail.com>
* create measuregrouping class
* add meas_map.setter in MeasureGrouping class
* macros.measure
* get_qubit_groups
* generate_schedule
* target.add_measuregrouping in backend_compat
* target.add_measuregrouping in backend_converter
* reformat and add docs
* on the way of working on generate_schedule_in_measure
* split measure into measure_v1 and measure_v2
macros.py
target
delete raise statement in measure_v2
modify instructions.Acquire to Acquire
* macros.py
* test_measuregrouping
* bug fix schedule with backendV2 for 0.25.0
* modify comments
* fix name of schedule in test_macros
* delete meas_map as a Target attribute
* minor changes in macros.py
* add test to test_macros.py
* make schedule_remapping_memory_slot private
* delete since field from deprecate_arg
* delete deprecate depcorator
* black macros.py
* revert about target
* modify implementation of qubit_mem_slots
* change the definition of meas_group_set
* black macros.py
* fix meas_group_set
* fix qubit_mem_slots
* reno
* modify unassigned_qubit_indices
* remove list() from unassigned_qubit_indices and unassigned_reg_indices
* fix: modify get_param_str to prevent circuit drawer from displaying params of type QuantumCircuit
* fix lint errors
* test: add circuit drawer test for instructions with parameters of type QuantumCircuit
* test: add circuit drawer tests for no parameters and params of type ndarray
* fix lint errors
* remove variable to fix lint error
* add reno
* update releasenotes/notes/fix-circuit-drawer-for-qc-params
Abby Mitchell