From ef04325d17603c7f300d6d9a3f20fd7f6e4ab15e Mon Sep 17 00:00:00 2001 From: Lev Bishop <18673315+levbishop@users.noreply.github.com> Date: Fri, 10 May 2019 16:52:08 -0400 Subject: [PATCH] Remove useless pylint suppressions (#2365) * Remove useless pylint suppressions * some of them are necesary --- qiskit/circuit/compositegate.py | 2 +- qiskit/circuit/instruction.py | 1 - qiskit/converters/ast_to_dag.py | 1 - qiskit/extensions/standard/cxbase.py | 2 +- qiskit/extensions/standard/iden.py | 2 -- qiskit/extensions/standard/s.py | 2 +- qiskit/extensions/standard/swap.py | 2 -- qiskit/extensions/standard/t.py | 2 +- qiskit/extensions/standard/ubase.py | 4 +--- qiskit/extensions/standard/x.py | 2 -- qiskit/extensions/standard/y.py | 2 -- qiskit/extensions/standard/z.py | 2 -- qiskit/extensions/unitary.py | 1 - qiskit/providers/baseprovider.py | 2 -- qiskit/providers/basicaer/basicaertools.py | 2 -- qiskit/providers/basicaer/qasm_simulator.py | 1 - qiskit/providers/basicaer/statevector_simulator.py | 2 -- qiskit/providers/models/backendconfiguration.py | 1 - qiskit/pulse/channels/device_specification.py | 1 - qiskit/qasm/node/external.py | 2 -- qiskit/qobj/models/pulse.py | 1 - qiskit/quantum_info/operators/measures.py | 2 +- qiskit/quantum_info/operators/quaternion.py | 6 +++--- qiskit/quantum_info/random/utils.py | 3 +-- qiskit/quantum_info/states/measures.py | 2 +- qiskit/quantum_info/states/states.py | 2 -- qiskit/quantum_info/synthesis/two_qubit_decompose.py | 3 +-- qiskit/test/mock.py | 2 -- qiskit/tools/jupyter/backend_monitor.py | 2 +- qiskit/tools/jupyter/jupyter_magics.py | 2 +- qiskit/tools/monitor/job_monitor.py | 2 +- qiskit/tools/qi/qi.py | 6 ++---- qiskit/transpiler/coupling.py | 2 -- qiskit/transpiler/passes/mapping/stochastic_swap.py | 4 ++-- qiskit/transpiler/preset_passmanagers/level0.py | 2 -- qiskit/transpiler/preset_passmanagers/level1.py | 2 -- qiskit/validation/fields/custom.py | 3 --- qiskit/visualization/__init__.py | 1 - qiskit/visualization/circuit_visualization.py | 1 - qiskit/visualization/counts_visualization.py | 2 +- qiskit/visualization/latex.py | 3 +-- qiskit/visualization/matplotlib.py | 2 +- qiskit/visualization/qcstyle.py | 2 +- qiskit/visualization/state_visualization.py | 2 +- qiskit/visualization/text.py | 3 +-- test/python/circuit/test_initializer.py | 2 -- test/python/circuit/test_unitary.py | 2 -- test/python/providers/test_jobmethods.py | 2 -- test/python/pulse/test_continuous_pulses.py | 2 +- test/python/pulse/test_discrete_pulses.py | 2 -- test/python/pulse/test_samplers.py | 1 - .../quantum_info/operators/channel/channel_test_case.py | 2 +- test/python/quantum_info/operators/channel/test_adjoint.py | 1 - test/python/quantum_info/operators/channel/test_chi.py | 1 - test/python/quantum_info/operators/channel/test_choi.py | 2 +- test/python/quantum_info/operators/channel/test_evolve.py | 2 +- test/python/quantum_info/operators/channel/test_kraus.py | 1 - .../python/quantum_info/operators/channel/test_linearops.py | 1 - test/python/quantum_info/operators/channel/test_ptm.py | 1 - .../quantum_info/operators/channel/test_stinespring.py | 1 - test/python/quantum_info/operators/channel/test_superop.py | 1 - .../quantum_info/operators/channel/test_tensor_compose.py | 1 - .../quantum_info/operators/channel/test_transformations.py | 2 +- test/python/quantum_info/operators/test_operator.py | 2 +- test/python/test_qi.py | 2 +- test/python/transpiler/test_generic_pass.py | 2 -- test/python/transpiler/test_pass_scheduler.py | 2 +- test/python/visualization/test_circuit_drawer.py | 2 +- test/python/visualization/test_circuit_text_drawer.py | 2 -- 69 files changed, 34 insertions(+), 103 deletions(-) diff --git a/qiskit/circuit/compositegate.py b/qiskit/circuit/compositegate.py index 567f9e5c89..c7a0cc120b 100644 --- a/qiskit/circuit/compositegate.py +++ b/qiskit/circuit/compositegate.py @@ -20,7 +20,7 @@ from qiskit.exceptions import QiskitError from .gate import Gate -class CompositeGate(Gate): # pylint: disable=abstract-method +class CompositeGate(Gate): """Composite gate, a sequence of unitary gates.""" def __init__(self, name, params, inverse_name=None): diff --git a/qiskit/circuit/instruction.py b/qiskit/circuit/instruction.py index 83482887f6..4b41568171 100644 --- a/qiskit/circuit/instruction.py +++ b/qiskit/circuit/instruction.py @@ -12,7 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=too-many-boolean-expressions """ A generic quantum instruction. diff --git a/qiskit/converters/ast_to_dag.py b/qiskit/converters/ast_to_dag.py index 1ed3107955..318ff980eb 100644 --- a/qiskit/converters/ast_to_dag.py +++ b/qiskit/converters/ast_to_dag.py @@ -125,7 +125,6 @@ class AstInterpreter: Return a list of tuples (Register,index). """ - # pylint: disable=inconsistent-return-statements reg = None if node.name in self.dag.qregs: reg = self.dag.qregs[node.name] diff --git a/qiskit/extensions/standard/cxbase.py b/qiskit/extensions/standard/cxbase.py index a7285f9ea0..81402a27c5 100644 --- a/qiskit/extensions/standard/cxbase.py +++ b/qiskit/extensions/standard/cxbase.py @@ -20,7 +20,7 @@ from qiskit.circuit import Gate from qiskit.circuit import QuantumCircuit -class CXBase(Gate): # pylint: disable=abstract-method +class CXBase(Gate): """Fundamental controlled-NOT gate.""" def __init__(self): diff --git a/qiskit/extensions/standard/iden.py b/qiskit/extensions/standard/iden.py index 6a083fcf2a..8bfe500a76 100644 --- a/qiskit/extensions/standard/iden.py +++ b/qiskit/extensions/standard/iden.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name - """ Identity gate. """ diff --git a/qiskit/extensions/standard/s.py b/qiskit/extensions/standard/s.py index 5b6178cc21..3fdd8fa87b 100644 --- a/qiskit/extensions/standard/s.py +++ b/qiskit/extensions/standard/s.py @@ -12,7 +12,7 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name,arguments-differ +# pylint: disable=invalid-name """ S=diag(1,i) Clifford phase gate or its inverse. diff --git a/qiskit/extensions/standard/swap.py b/qiskit/extensions/standard/swap.py index 4942880d7c..f9fe80da1e 100644 --- a/qiskit/extensions/standard/swap.py +++ b/qiskit/extensions/standard/swap.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name - """ SWAP gate. """ diff --git a/qiskit/extensions/standard/t.py b/qiskit/extensions/standard/t.py index 76a0f7bc8f..67986e49d2 100644 --- a/qiskit/extensions/standard/t.py +++ b/qiskit/extensions/standard/t.py @@ -12,7 +12,7 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name,arguments-differ +# pylint: disable=invalid-name """ T=sqrt(S) phase gate or its inverse. diff --git a/qiskit/extensions/standard/ubase.py b/qiskit/extensions/standard/ubase.py index 6e358b196c..59dccca51e 100644 --- a/qiskit/extensions/standard/ubase.py +++ b/qiskit/extensions/standard/ubase.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name - """ Element of SU(2). """ @@ -23,7 +21,7 @@ from qiskit.circuit import Gate from qiskit.circuit import QuantumCircuit -class UBase(Gate): # pylint: disable=abstract-method +class UBase(Gate): """Element of SU(2).""" def __init__(self, theta, phi, lam): diff --git a/qiskit/extensions/standard/x.py b/qiskit/extensions/standard/x.py index 3689ab690d..78fd615083 100644 --- a/qiskit/extensions/standard/x.py +++ b/qiskit/extensions/standard/x.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name - """ Pauli X (bit-flip) gate. """ diff --git a/qiskit/extensions/standard/y.py b/qiskit/extensions/standard/y.py index 415f848fe2..b58a324b85 100644 --- a/qiskit/extensions/standard/y.py +++ b/qiskit/extensions/standard/y.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name - """ Pauli Y (bit-phase-flip) gate. """ diff --git a/qiskit/extensions/standard/z.py b/qiskit/extensions/standard/z.py index 4fab45665b..6e01f40db7 100644 --- a/qiskit/extensions/standard/z.py +++ b/qiskit/extensions/standard/z.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name - """ Pauli Z (phase-flip) gate. """ diff --git a/qiskit/extensions/unitary.py b/qiskit/extensions/unitary.py index 4bd9525f2e..a55d91b2a7 100644 --- a/qiskit/extensions/unitary.py +++ b/qiskit/extensions/unitary.py @@ -12,7 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name,assignment-from-no-return """ Arbitrary unitary circuit instruction. """ diff --git a/qiskit/providers/baseprovider.py b/qiskit/providers/baseprovider.py index c9faa88559..da78459f73 100644 --- a/qiskit/providers/baseprovider.py +++ b/qiskit/providers/baseprovider.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=redundant-returns-doc,missing-raises-doc - """Base class for a backend provider.""" from abc import ABC, abstractmethod diff --git a/qiskit/providers/basicaer/basicaertools.py b/qiskit/providers/basicaer/basicaertools.py index 8b4fac0ce0..eab9f268ef 100644 --- a/qiskit/providers/basicaer/basicaertools.py +++ b/qiskit/providers/basicaer/basicaertools.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name - """Contains functions used by the basic aer simulators. """ diff --git a/qiskit/providers/basicaer/qasm_simulator.py b/qiskit/providers/basicaer/qasm_simulator.py index 465d880435..a93459e48f 100644 --- a/qiskit/providers/basicaer/qasm_simulator.py +++ b/qiskit/providers/basicaer/qasm_simulator.py @@ -12,7 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name # pylint: disable=arguments-differ """Contains a (slow) python simulator. diff --git a/qiskit/providers/basicaer/statevector_simulator.py b/qiskit/providers/basicaer/statevector_simulator.py index 8344366c08..f720d64ceb 100644 --- a/qiskit/providers/basicaer/statevector_simulator.py +++ b/qiskit/providers/basicaer/statevector_simulator.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name -# pylint: disable=arguments-differ """Contains a (slow) python statevector simulator. diff --git a/qiskit/providers/models/backendconfiguration.py b/qiskit/providers/models/backendconfiguration.py index a57a77ffc2..75b9e11193 100644 --- a/qiskit/providers/models/backendconfiguration.py +++ b/qiskit/providers/models/backendconfiguration.py @@ -53,7 +53,6 @@ class UchannelLOSchema(BaseSchema): class PulseHamiltonianSchema(BaseSchema): """Schema for PulseHamiltonian.""" - # pylint: disable=redefined-builtin # Required properties. h_str = List(String(), validate=Length(min=1), required=True) diff --git a/qiskit/pulse/channels/device_specification.py b/qiskit/pulse/channels/device_specification.py index 0344ab0a15..6df81f5b9f 100644 --- a/qiskit/pulse/channels/device_specification.py +++ b/qiskit/pulse/channels/device_specification.py @@ -105,7 +105,6 @@ class DeviceSpecification: """Return qubits in this device.""" return self._qubits - # pylint: disable=invalid-name @property def c(self) -> List[RegisterSlot]: """Return register slots in this device.""" diff --git a/qiskit/qasm/node/external.py b/qiskit/qasm/node/external.py index fdeed94821..bc14c1f49f 100644 --- a/qiskit/qasm/node/external.py +++ b/qiskit/qasm/node/external.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name - """Node for an OPENQASM external function.""" import sympy diff --git a/qiskit/qobj/models/pulse.py b/qiskit/qobj/models/pulse.py index d100ce7bd4..e8a174d821 100644 --- a/qiskit/qobj/models/pulse.py +++ b/qiskit/qobj/models/pulse.py @@ -78,7 +78,6 @@ class PulseQobjExperimentSchema(QobjExperimentSchema): class PulseQobjConfigSchema(QobjConfigSchema): """Schema for PulseQobjConfig of device backend.""" - # pylint: disable=invalid-name # Required properties. meas_level = Integer(required=True, validate=Range(min=0, max=2)) diff --git a/qiskit/quantum_info/operators/measures.py b/qiskit/quantum_info/operators/measures.py index 38f7396c3b..9d7a9d2b59 100644 --- a/qiskit/quantum_info/operators/measures.py +++ b/qiskit/quantum_info/operators/measures.py @@ -12,7 +12,7 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name,anomalous-backslash-in-string +# pylint: disable=invalid-name """ A collection of useful quantum information functions for operators. diff --git a/qiskit/quantum_info/operators/quaternion.py b/qiskit/quantum_info/operators/quaternion.py index ccd306275f..5658c27ce2 100644 --- a/qiskit/quantum_info/operators/quaternion.py +++ b/qiskit/quantum_info/operators/quaternion.py @@ -36,9 +36,9 @@ class Quaternion: def __str__(self): return np.array_str(self.data) - def __mul__(self, r): # pylint: disable=C0103 + def __mul__(self, r): if isinstance(r, Quaternion): - q = self # pylint: disable=C0103 + q = self out_data = np.zeros(4, dtype=float) out_data[0] = r(0)*q(0) - r(1)*q(1) - r(2)*q(2) - r(3)*q(3) out_data[1] = r(0)*q(1) + r(1)*q(0) - r(2)*q(3) + r(3)*q(2) @@ -78,7 +78,7 @@ class Quaternion: Returns: ndarray: Rotation matrix. """ - w, x, y, z = self.normalize().data # pylint: disable=C0103 + w, x, y, z = self.normalize().data mat = np.array([ [1-2*y**2-2*z**2, 2*x*y-2*z*w, 2*x*z+2*y*w], [2*x*y+2*z*w, 1-2*x**2-2*z**2, 2*y*z-2*x*w], diff --git a/qiskit/quantum_info/random/utils.py b/qiskit/quantum_info/random/utils.py index b661eae3ab..5efb94e332 100644 --- a/qiskit/quantum_info/random/utils.py +++ b/qiskit/quantum_info/random/utils.py @@ -5,8 +5,7 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name,invalid-sequence-index -# pylint: disable=unsupported-assignment-operation +# pylint: disable=invalid-name """ Methods to create random unitaries, states, etc. diff --git a/qiskit/quantum_info/states/measures.py b/qiskit/quantum_info/states/measures.py index befd88e99f..04214770a8 100644 --- a/qiskit/quantum_info/states/measures.py +++ b/qiskit/quantum_info/states/measures.py @@ -12,7 +12,7 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name,anomalous-backslash-in-string +# pylint: disable=invalid-name """ A collection of useful quantum information functions for states. diff --git a/qiskit/quantum_info/states/states.py b/qiskit/quantum_info/states/states.py index 866294a3c6..31d03b36d0 100644 --- a/qiskit/quantum_info/states/states.py +++ b/qiskit/quantum_info/states/states.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name,anomalous-backslash-in-string - """ A collection of useful quantum information functions for states. diff --git a/qiskit/quantum_info/synthesis/two_qubit_decompose.py b/qiskit/quantum_info/synthesis/two_qubit_decompose.py index 0d9aefc56a..32eeacb3e9 100644 --- a/qiskit/quantum_info/synthesis/two_qubit_decompose.py +++ b/qiskit/quantum_info/synthesis/two_qubit_decompose.py @@ -5,8 +5,7 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name,invalid-sequence-index -# pylint: disable=unsupported-assignment-operation +# pylint: disable=invalid-name """ Expand 2-qubit Unitary operators into an equivalent diff --git a/qiskit/test/mock.py b/qiskit/test/mock.py index 59e860041e..ecd6bdb138 100644 --- a/qiskit/test/mock.py +++ b/qiskit/test/mock.py @@ -55,10 +55,8 @@ class FakeProvider(BaseProvider): def get_backend(self, name=None, **kwargs): backend = self._backends[0] if name: - # pylint: disable=no-member filtered_backends = [backend for backend in self._backends if backend.name() == name] - # pylint: enable=no-member if not filtered_backends: raise QiskitBackendNotFoundError() diff --git a/qiskit/tools/jupyter/backend_monitor.py b/qiskit/tools/jupyter/backend_monitor.py index 2feb055465..11af55a88e 100644 --- a/qiskit/tools/jupyter/backend_monitor.py +++ b/qiskit/tools/jupyter/backend_monitor.py @@ -29,7 +29,7 @@ from qiskit.exceptions import QiskitError from qiskit.visualization.gate_map import plot_gate_map try: - # pylint: disable=import-error,no-name-in-module + # pylint: disable=import-error from qiskit.providers.ibmq import IBMQ, IBMQBackend except ImportError: pass diff --git a/qiskit/tools/jupyter/jupyter_magics.py b/qiskit/tools/jupyter/jupyter_magics.py index c59066435e..0cbc83ab9a 100644 --- a/qiskit/tools/jupyter/jupyter_magics.py +++ b/qiskit/tools/jupyter/jupyter_magics.py @@ -171,7 +171,7 @@ class ProgressBarMagic(Magics): default='html', help="Type of progress bar, 'html' or 'text'." ) - def qiskit_progress_bar(self, line='', cell=None): # pylint: disable=W0613 + def qiskit_progress_bar(self, line='', cell=None): """A Jupyter magic function to generate progressbar. """ args = magic_arguments.parse_argstring(self.qiskit_progress_bar, line) diff --git a/qiskit/tools/monitor/job_monitor.py b/qiskit/tools/monitor/job_monitor.py index 690309ce51..3642fa2806 100644 --- a/qiskit/tools/monitor/job_monitor.py +++ b/qiskit/tools/monitor/job_monitor.py @@ -98,7 +98,7 @@ def job_monitor(job, interval=None, monitor_async=False, quiet=False, output=sys except ImportError: raise ImportError('These functions need ipywidgets. ' 'Run "pip install ipywidgets" before.') - from qiskit.tools.jupyter.jupyter_magics import _html_checker # pylint: disable=C0412 + from qiskit.tools.jupyter.jupyter_magics import _html_checker style = "font-size:16px;" header = "

Job Status: %s

".format( diff --git a/qiskit/tools/qi/qi.py b/qiskit/tools/qi/qi.py index d0272396d7..999d003af3 100644 --- a/qiskit/tools/qi/qi.py +++ b/qiskit/tools/qi/qi.py @@ -12,9 +12,7 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name,anomalous-backslash-in-string -# pylint: disable=assignment-from-no-return - +# pylint: disable=invalid-name """ A collection of useful quantum information functions. @@ -419,7 +417,6 @@ def shannon_entropy(pvec, base=2): Returns: float: The Shannon entropy H(pvec). """ - # pylint: disable=missing-docstring if base == 2: def logfn(x): return - x * np.log2(x) @@ -447,6 +444,7 @@ def entropy(state): Returns: float: The von-Neumann entropy S(rho). """ + # pylint: disable=assignment-from-no-return rho = np.array(state) if rho.ndim == 1: diff --git a/qiskit/transpiler/coupling.py b/qiskit/transpiler/coupling.py index 2f25d7210c..505282a35b 100644 --- a/qiskit/transpiler/coupling.py +++ b/qiskit/transpiler/coupling.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=no-member - """ Directed graph object for representing coupling between physical qubits. diff --git a/qiskit/transpiler/passes/mapping/stochastic_swap.py b/qiskit/transpiler/passes/mapping/stochastic_swap.py index 3c2eb2ea60..2cef8af8f3 100644 --- a/qiskit/transpiler/passes/mapping/stochastic_swap.py +++ b/qiskit/transpiler/passes/mapping/stochastic_swap.py @@ -26,9 +26,9 @@ from qiskit.transpiler.exceptions import TranspilerError from qiskit.dagcircuit import DAGCircuit from qiskit.extensions.standard import SwapGate from qiskit.transpiler import Layout -# pylint: disable=no-name-in-module, import-error +# pylint: disable=no-name-in-module from .cython.stochastic_swap.utils import nlayout_from_layout -# pylint: disable=no-name-in-module, import-error +# pylint: disable=no-name-in-module from .cython.stochastic_swap.swap_trial import swap_trial logger = getLogger(__name__) diff --git a/qiskit/transpiler/preset_passmanagers/level0.py b/qiskit/transpiler/preset_passmanagers/level0.py index f5f277f9c8..015c09ab74 100644 --- a/qiskit/transpiler/preset_passmanagers/level0.py +++ b/qiskit/transpiler/preset_passmanagers/level0.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=unused-variable - """ Level 0 pass manager: no optimization, just conforming to basis and coupling map diff --git a/qiskit/transpiler/preset_passmanagers/level1.py b/qiskit/transpiler/preset_passmanagers/level1.py index e7793d2d0b..57a8184470 100644 --- a/qiskit/transpiler/preset_passmanagers/level1.py +++ b/qiskit/transpiler/preset_passmanagers/level1.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=unused-variable - """ Level 1 pass manager: mapping in addition to light optimization via adjacent gate collapse diff --git a/qiskit/validation/fields/custom.py b/qiskit/validation/fields/custom.py index 658943d686..32dcef1aad 100644 --- a/qiskit/validation/fields/custom.py +++ b/qiskit/validation/fields/custom.py @@ -174,7 +174,6 @@ class DictParameters(ModelTypeValidator): return value def _validate_values(self, value): - # pylint: disable=too-many-return-statements if value is None: return None if isinstance(value, self.valid_value_types): @@ -187,7 +186,6 @@ class DictParameters(ModelTypeValidator): return self.fail('invalid', input=value) def _serialize(self, value, attr, obj): - # pylint: disable=too-many-return-statements if value is None: return None if isinstance(value, Mapping): @@ -196,7 +194,6 @@ class DictParameters(ModelTypeValidator): return self.fail('invalid_mapping') def _deserialize(self, value, attr, data): - # pylint: disable=too-many-return-statements if value is None: return None if isinstance(value, Mapping): diff --git a/qiskit/visualization/__init__.py b/qiskit/visualization/__init__.py index e43f93950f..49f555f4f4 100644 --- a/qiskit/visualization/__init__.py +++ b/qiskit/visualization/__init__.py @@ -11,7 +11,6 @@ # Any modifications or derivative works of this code must retain this # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name """Main Qiskit visualization methods.""" diff --git a/qiskit/visualization/circuit_visualization.py b/qiskit/visualization/circuit_visualization.py index 831598b23c..812d396837 100644 --- a/qiskit/visualization/circuit_visualization.py +++ b/qiskit/visualization/circuit_visualization.py @@ -13,7 +13,6 @@ # that they have been altered from the originals. # TODO: Remove after 0.7 and the deprecated methods are removed -# pylint: disable=unused-argument """ diff --git a/qiskit/visualization/counts_visualization.py b/qiskit/visualization/counts_visualization.py index f849738712..4f0b4fc02a 100644 --- a/qiskit/visualization/counts_visualization.py +++ b/qiskit/visualization/counts_visualization.py @@ -12,7 +12,7 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name,missing-docstring,import-error +# pylint: disable=invalid-name,import-error """ Visualization functions for measurement counts. diff --git a/qiskit/visualization/latex.py b/qiskit/visualization/latex.py index 65b89d3410..cc3d983acb 100644 --- a/qiskit/visualization/latex.py +++ b/qiskit/visualization/latex.py @@ -12,8 +12,7 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name,anomalous-backslash-in-string,missing-docstring -# pylint: disable=consider-using-enumerate +# pylint: disable=invalid-name """latex circuit visualization backends.""" diff --git a/qiskit/visualization/matplotlib.py b/qiskit/visualization/matplotlib.py index 7c39bcc595..d02ac8be0a 100644 --- a/qiskit/visualization/matplotlib.py +++ b/qiskit/visualization/matplotlib.py @@ -12,7 +12,7 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name,anomalous-backslash-in-string,missing-docstring +# pylint: disable=invalid-name,missing-docstring """mpl circuit visualization backend.""" diff --git a/qiskit/visualization/qcstyle.py b/qiskit/visualization/qcstyle.py index fed5a51a58..ff8b9b5201 100644 --- a/qiskit/visualization/qcstyle.py +++ b/qiskit/visualization/qcstyle.py @@ -12,7 +12,7 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name,anomalous-backslash-in-string,missing-docstring +# pylint: disable=invalid-name,missing-docstring class DefaultStyle: diff --git a/qiskit/visualization/state_visualization.py b/qiskit/visualization/state_visualization.py index 860878f0a4..104dcecd57 100644 --- a/qiskit/visualization/state_visualization.py +++ b/qiskit/visualization/state_visualization.py @@ -12,7 +12,7 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name,anomalous-backslash-in-string,ungrouped-imports,import-error +# pylint: disable=invalid-name,ungrouped-imports,import-error """ Visualization functions for quantum states. diff --git a/qiskit/visualization/text.py b/qiskit/visualization/text.py index 5f01601f56..a250debc34 100644 --- a/qiskit/visualization/text.py +++ b/qiskit/visualization/text.py @@ -420,7 +420,7 @@ class InputWire(DrawElement): super().__init__(label) @staticmethod - def fillup_layer(names): # pylint: disable=arguments-differ + def fillup_layer(names): """ Creates a layer with InputWire elements. Args: @@ -897,7 +897,6 @@ class Layer: self.clbit_layer[self.cregs.index(clbit)] = element def _set_multibox(self, wire_type, bits, label, top_connect=None): - # pylint: disable=invalid-name bits = list(bits) if wire_type == "cl": bit_index = sorted([i for i, x in enumerate(self.cregs) if x in bits]) diff --git a/test/python/circuit/test_initializer.py b/test/python/circuit/test_initializer.py index 4ad5d3d9f6..49a3d77602 100644 --- a/test/python/circuit/test_initializer.py +++ b/test/python/circuit/test_initializer.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=missing-docstring - """ Initialize test. """ diff --git a/test/python/circuit/test_unitary.py b/test/python/circuit/test_unitary.py index 3614c1236e..faaa2f5d38 100644 --- a/test/python/circuit/test_unitary.py +++ b/test/python/circuit/test_unitary.py @@ -5,8 +5,6 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name - """Quick program to test the qi tools modules.""" import json diff --git a/test/python/providers/test_jobmethods.py b/test/python/providers/test_jobmethods.py index 292c1326ef..0a11d27832 100644 --- a/test/python/providers/test_jobmethods.py +++ b/test/python/providers/test_jobmethods.py @@ -39,7 +39,6 @@ class TestSimulatorsJob(QiskitTestCase): job_id = str(uuid.uuid4()) backend = FakeRueschlikon() - # pylint: disable=invalid-name,redefined-outer-name with mocked_executor() as (SimulatorJob, executor): for index in range(taskcount): job = SimulatorJob(backend, job_id, target_tasks[index], new_fake_qobj()) @@ -59,7 +58,6 @@ class TestSimulatorsJob(QiskitTestCase): job_id = str(uuid.uuid4()) backend = FakeRueschlikon() - # pylint: disable=invalid-name,redefined-outer-name with mocked_executor() as (BasicAerJob, executor): job = BasicAerJob(backend, job_id, lambda: None, new_fake_qobj()) job.submit() diff --git a/test/python/pulse/test_continuous_pulses.py b/test/python/pulse/test_continuous_pulses.py index 66e10381ae..bac8cc5ead 100644 --- a/test/python/pulse/test_continuous_pulses.py +++ b/test/python/pulse/test_continuous_pulses.py @@ -5,7 +5,7 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name, unexpected-keyword-arg, no-value-for-parameter +# pylint: disable=invalid-name """Tests continuous pulse functions.""" diff --git a/test/python/pulse/test_discrete_pulses.py b/test/python/pulse/test_discrete_pulses.py index e4ddbf1aa0..70e6d6cba3 100644 --- a/test/python/pulse/test_discrete_pulses.py +++ b/test/python/pulse/test_discrete_pulses.py @@ -5,8 +5,6 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name, unexpected-keyword-arg, no-value-for-parameter - """Tests discrete sampled pulse functions.""" import numpy as np diff --git a/test/python/pulse/test_samplers.py b/test/python/pulse/test_samplers.py index e1fd56ec0c..3261ffbc2f 100644 --- a/test/python/pulse/test_samplers.py +++ b/test/python/pulse/test_samplers.py @@ -5,7 +5,6 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name, unexpected-keyword-arg, no-value-for-parameter """Tests pulse function samplers.""" diff --git a/test/python/quantum_info/operators/channel/channel_test_case.py b/test/python/quantum_info/operators/channel/channel_test_case.py index 3fc16b0d39..7113874854 100644 --- a/test/python/quantum_info/operators/channel/channel_test_case.py +++ b/test/python/quantum_info/operators/channel/channel_test_case.py @@ -5,7 +5,7 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name,missing-docstring +# pylint: disable=invalid-name """Tests for quantum channel representation class.""" import numpy as np diff --git a/test/python/quantum_info/operators/channel/test_adjoint.py b/test/python/quantum_info/operators/channel/test_adjoint.py index 051e968c1a..48c16b2629 100644 --- a/test/python/quantum_info/operators/channel/test_adjoint.py +++ b/test/python/quantum_info/operators/channel/test_adjoint.py @@ -5,7 +5,6 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name,missing-docstring """Equivalence tests for quantum channel methods.""" import unittest diff --git a/test/python/quantum_info/operators/channel/test_chi.py b/test/python/quantum_info/operators/channel/test_chi.py index eec7390015..93369ea507 100644 --- a/test/python/quantum_info/operators/channel/test_chi.py +++ b/test/python/quantum_info/operators/channel/test_chi.py @@ -5,7 +5,6 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name,missing-docstring """Tests for Chi quantum channel representation class.""" import unittest diff --git a/test/python/quantum_info/operators/channel/test_choi.py b/test/python/quantum_info/operators/channel/test_choi.py index 7aa0add9b7..82e4dd4ae9 100644 --- a/test/python/quantum_info/operators/channel/test_choi.py +++ b/test/python/quantum_info/operators/channel/test_choi.py @@ -5,7 +5,7 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name,missing-docstring +# pylint: disable=invalid-name """Tests for Choi quantum channel representation class.""" import unittest diff --git a/test/python/quantum_info/operators/channel/test_evolve.py b/test/python/quantum_info/operators/channel/test_evolve.py index a40c642e5e..9f5df88d7c 100644 --- a/test/python/quantum_info/operators/channel/test_evolve.py +++ b/test/python/quantum_info/operators/channel/test_evolve.py @@ -5,7 +5,7 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name,missing-docstring +# pylint: disable=invalid-name """Tests for quantum channel representation transformations.""" import unittest diff --git a/test/python/quantum_info/operators/channel/test_kraus.py b/test/python/quantum_info/operators/channel/test_kraus.py index b2cd194edd..534a418ba4 100644 --- a/test/python/quantum_info/operators/channel/test_kraus.py +++ b/test/python/quantum_info/operators/channel/test_kraus.py @@ -5,7 +5,6 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name,missing-docstring """Tests for Kraus quantum channel representation class.""" import unittest diff --git a/test/python/quantum_info/operators/channel/test_linearops.py b/test/python/quantum_info/operators/channel/test_linearops.py index cb76a98cc3..bef2483f47 100644 --- a/test/python/quantum_info/operators/channel/test_linearops.py +++ b/test/python/quantum_info/operators/channel/test_linearops.py @@ -5,7 +5,6 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name,missing-docstring """Equivalence tests for quantum channel methods.""" import unittest diff --git a/test/python/quantum_info/operators/channel/test_ptm.py b/test/python/quantum_info/operators/channel/test_ptm.py index 89e7890652..0e4814ac18 100644 --- a/test/python/quantum_info/operators/channel/test_ptm.py +++ b/test/python/quantum_info/operators/channel/test_ptm.py @@ -5,7 +5,6 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name,missing-docstring """Tests for PTM quantum channel representation class.""" import unittest diff --git a/test/python/quantum_info/operators/channel/test_stinespring.py b/test/python/quantum_info/operators/channel/test_stinespring.py index fb267f9ffa..dafe674167 100644 --- a/test/python/quantum_info/operators/channel/test_stinespring.py +++ b/test/python/quantum_info/operators/channel/test_stinespring.py @@ -5,7 +5,6 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name,missing-docstring """Tests for Stinespring quantum channel representation class.""" import unittest diff --git a/test/python/quantum_info/operators/channel/test_superop.py b/test/python/quantum_info/operators/channel/test_superop.py index 62c3482dd7..a1258e81a5 100644 --- a/test/python/quantum_info/operators/channel/test_superop.py +++ b/test/python/quantum_info/operators/channel/test_superop.py @@ -5,7 +5,6 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name,missing-docstring """Tests for SuperOp quantum channel representation class.""" import unittest diff --git a/test/python/quantum_info/operators/channel/test_tensor_compose.py b/test/python/quantum_info/operators/channel/test_tensor_compose.py index 271e5006fc..77de33d71a 100644 --- a/test/python/quantum_info/operators/channel/test_tensor_compose.py +++ b/test/python/quantum_info/operators/channel/test_tensor_compose.py @@ -5,7 +5,6 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name,missing-docstring """Equivalence tests for quantum channel methods.""" import unittest diff --git a/test/python/quantum_info/operators/channel/test_transformations.py b/test/python/quantum_info/operators/channel/test_transformations.py index a0d88fe336..d51c09bd5e 100644 --- a/test/python/quantum_info/operators/channel/test_transformations.py +++ b/test/python/quantum_info/operators/channel/test_transformations.py @@ -5,7 +5,7 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name,missing-docstring +# pylint: disable=invalid-name """Tests for quantum channel representation transformations.""" import unittest diff --git a/test/python/quantum_info/operators/test_operator.py b/test/python/quantum_info/operators/test_operator.py index 2f2f4baaa5..f6f2e0a70b 100644 --- a/test/python/quantum_info/operators/test_operator.py +++ b/test/python/quantum_info/operators/test_operator.py @@ -5,7 +5,7 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=invalid-name,missing-docstring +# pylint: disable=invalid-name """Tests for Operator matrix linear operator class.""" import unittest diff --git a/test/python/test_qi.py b/test/python/test_qi.py index 5266736a79..ca6edd4d92 100644 --- a/test/python/test_qi.py +++ b/test/python/test_qi.py @@ -12,7 +12,7 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name,missing-docstring +# pylint: disable=missing-docstring """Quick program to test the qi tools modules.""" diff --git a/test/python/transpiler/test_generic_pass.py b/test/python/transpiler/test_generic_pass.py index a935e67ad1..3008d05c12 100644 --- a/test/python/transpiler/test_generic_pass.py +++ b/test/python/transpiler/test_generic_pass.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable=invalid-name - """BasePass and generic pass testing""" import unittest.mock diff --git a/test/python/transpiler/test_pass_scheduler.py b/test/python/transpiler/test_pass_scheduler.py index 1b288ecfdb..0379a9857a 100644 --- a/test/python/transpiler/test_pass_scheduler.py +++ b/test/python/transpiler/test_pass_scheduler.py @@ -470,7 +470,7 @@ class TestUseCases(SchedulerTestCase): class DoXTimesController(FlowController): """ A control-flow plugin for running a set of passes an X amount of times.""" - def __init__(self, passes, options, do_x_times=0, **_): # pylint: disable=super-init-not-called + def __init__(self, passes, options, do_x_times=0, **_): self.do_x_times = do_x_times() super().__init__(passes, options) diff --git a/test/python/visualization/test_circuit_drawer.py b/test/python/visualization/test_circuit_drawer.py index 672480ce9c..2cd6744805 100644 --- a/test/python/visualization/test_circuit_drawer.py +++ b/test/python/visualization/test_circuit_drawer.py @@ -5,7 +5,7 @@ # This source code is licensed under the Apache License, Version 2.0 found in # the LICENSE.txt file in the root directory of this source tree. -# pylint: disable=no-member,invalid-name,missing-docstring +# pylint: disable=missing-docstring import unittest diff --git a/test/python/visualization/test_circuit_text_drawer.py b/test/python/visualization/test_circuit_text_drawer.py index 6a355d8d50..1cceafb626 100644 --- a/test/python/visualization/test_circuit_text_drawer.py +++ b/test/python/visualization/test_circuit_text_drawer.py @@ -12,8 +12,6 @@ # copyright notice, and modified files need to carry a notice indicating # that they have been altered from the originals. -# pylint: disable = no-member - """ `_text_circuit_drawer` "draws" a circuit in "ascii art" """ from codecs import encode