Add ResetAfterMeasureSimplification transpiler pass (#8330)

* Add ResetAfterMeasureSimplification transpiler pass

This commit adds a new transpiler pass to simplify resets after a
measurement. This pass when run will replace any reset after a
measurement with a conditional X gate. This is because the reset
operation on IBM backends is implemented by performing a conditional x
gate after a reset. So doing this simplification will improve the
fidelity of the circuit because we're removing a duplicate measurement
which was implicit in the reset. This pass is based on the marz library:
https://github.com/Qiskit-Partners/marz which did the same thing but at
the QuantumCircuit level.

One note is that this pass is basically specific to IBM backends so it's
not added to the preset pass managers. Ideally we'd be able to have the
IBM backends run this as part of the init stage or something to do the
logical transformation early in the compilation. But right now there is
no mechanism to do this (see #8329), so for now having the pass and
letting users specify it in the pass manager directly is the best
option. After #8329 is implemented we can look at adding this pass to
that hook interface in the ibm provider's backends directly so that they
can leverage this optimization whenever they're the compilation target.

* Fix lint

* Tweak wording on release note

* Remove stray debug draw() call

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>

qiskit/transpiler/passes/__init__.py

@@ -85,6 +85,7 @@ Optimizations
    HoareOptimizer
    TemplateOptimization
    EchoRZXWeylDecomposition
+   ResetAfterMeasureSimplification
    OptimizeCliffords
 
 Calibration
@@ -222,6 +223,7 @@ from .optimization import TemplateOptimization
 from .optimization import InverseCancellation
 from .optimization import EchoRZXWeylDecomposition
 from .optimization import CollectLinearFunctions
+from .optimization import ResetAfterMeasureSimplification
 from .optimization import OptimizeCliffords
 
 # circuit analysis

qiskit/transpiler/passes/optimization/__init__.py

@@ -32,4 +32,5 @@ from .inverse_cancellation import InverseCancellation
 from .collect_1q_runs import Collect1qRuns
 from .echo_rzx_weyl_decomposition import EchoRZXWeylDecomposition
 from .collect_linear_functions import CollectLinearFunctions
+from .reset_after_measure_simplification import ResetAfterMeasureSimplification
 from .optimize_cliffords import OptimizeCliffords

qiskit/transpiler/passes/optimization/reset_after_measure_simplification.py

@@ -0,0 +1,46 @@
+# This code is part of Qiskit.
+#
+# (C) Copyright IBM 2017, 2021.
+#
+# This code is licensed under the Apache License, Version 2.0. You may
+# obtain a copy of this license in the LICENSE.txt file in the root directory
+# of this source tree or at http://www.apache.org/licenses/LICENSE-2.0.
+#
+# Any modifications or derivative works of this code must retain this
+# copyright notice, and modified files need to carry a notice indicating
+# that they have been altered from the originals.
+
+"""Replace resets after measure with a conditional XGate."""
+
+from qiskit.transpiler.basepasses import TransformationPass
+from qiskit.circuit.library.standard_gates.x import XGate
+from qiskit.circuit.reset import Reset
+from qiskit.circuit.measure import Measure
+from qiskit.dagcircuit.dagcircuit import DAGCircuit
+from qiskit.dagcircuit.dagnode import DAGOpNode
+
+
+class ResetAfterMeasureSimplification(TransformationPass):
+    """This pass replaces reset after measure with a conditional X gate.
+
+    This optimization is suitable for use on IBM Quantum systems where the
+    reset operation is performed by a measurement followed by a conditional
+    x-gate. It might not be desireable on other backends if reset is implemented
+    differently.
+    """
+
+    def run(self, dag):
+        """Run the pass on a dag."""
+        for node in dag.op_nodes(Measure):
+            succ = next(dag.quantum_successors(node))
+            if isinstance(succ, DAGOpNode) and isinstance(succ.op, Reset):
+                new_x = XGate()
+                new_x.condition = (node.cargs[0], 1)
+                new_dag = DAGCircuit()
+                new_dag.add_qubits(node.qargs)
+                new_dag.add_clbits(node.cargs)
+                new_dag.apply_operation_back(node.op, node.qargs, node.cargs)
+                new_dag.apply_operation_back(new_x, node.qargs)
+                dag.remove_op_node(succ)
+                dag.substitute_node_with_dag(node, new_dag)
+        return dag

releasenotes/notes/add-reset-simplification-pass-82377d80dd0081fd.yaml

@@ -0,0 +1,10 @@
+---
+features:
+  - |
+    Added a new transpiler pass, :class:`~ResetAfterMeasureSimplification`,
+    which is used to replace a :class:`~.Reset` operation after a
+    :class:`~.Measure` with a conditional :class:`~.XGate`. This pass can
+    be used on backends where a :class:`~.Reset` operation is performed by
+    doing a measurement and then a conditional X gate so that this will
+    remove the duplicate implicit :class:`~.Measure` from the :class:`~.Reset`
+    operation.

test/python/transpiler/test_reset_after_measure_simplification.py

@@ -0,0 +1,140 @@
+# This code is part of Qiskit.
+#
+# (C) Copyright IBM 2022.
+#
+# This code is licensed under the Apache License, Version 2.0. You may
+# obtain a copy of this license in the LICENSE.txt file in the root directory
+# of this source tree or at http://www.apache.org/licenses/LICENSE-2.0.
+#
+# Any modifications or derivative works of this code must retain this
+# copyright notice, and modified files need to carry a notice indicating
+# that they have been altered from the originals.
+
+"""Test the ResetAfterMeasureSimplification pass"""
+
+from qiskit import QuantumCircuit, ClassicalRegister, QuantumRegister
+from qiskit.circuit.classicalregister import Clbit
+from qiskit.transpiler.passes.optimization import ResetAfterMeasureSimplification
+from qiskit.test import QiskitTestCase
+
+
+class TestResetAfterMeasureSimplificationt(QiskitTestCase):
+    """Test ResetAfterMeasureSimplification transpiler pass."""
+
+    def test_simple(self):
+        """Test simple"""
+        qc = QuantumCircuit(1, 1)
+        qc.measure(0, 0)
+        qc.reset(0)
+
+        new_qc = ResetAfterMeasureSimplification()(qc)
+
+        ans_qc = QuantumCircuit(1, 1)
+        ans_qc.measure(0, 0)
+        ans_qc.x(0).c_if(ans_qc.clbits[0], 1)
+        self.assertEqual(new_qc, ans_qc)
+
+    def test_simple_null(self):
+        """Test simple no change in circuit"""
+        qc = QuantumCircuit(1, 1)
+        qc.measure(0, 0)
+        qc.x(0)
+        qc.reset(0)
+        new_qc = ResetAfterMeasureSimplification()(qc)
+
+        self.assertEqual(new_qc, qc)
+
+    def test_simple_multi_reg(self):
+        """Test simple, multiple registers"""
+        cr1 = ClassicalRegister(1, "c1")
+        cr2 = ClassicalRegister(1, "c2")
+        qr = QuantumRegister(1, "q")
+        qc = QuantumCircuit(qr, cr1, cr2)
+        qc.measure(0, 1)
+        qc.reset(0)
+
+        new_qc = ResetAfterMeasureSimplification()(qc)
+
+        ans_qc = QuantumCircuit(qr, cr1, cr2)
+        ans_qc.measure(0, 1)
+        ans_qc.x(0).c_if(cr2[0], 1)
+
+        self.assertEqual(new_qc, ans_qc)
+
+    def test_simple_multi_reg_null(self):
+        """Test simple, multiple registers, null change"""
+        cr1 = ClassicalRegister(1, "c1")
+        cr2 = ClassicalRegister(1, "c2")
+        qr = QuantumRegister(2, "q")
+        qc = QuantumCircuit(qr, cr1, cr2)
+        qc.measure(0, 1)
+        qc.reset(1)  # reset not on same qubit as meas
+
+        new_qc = ResetAfterMeasureSimplification()(qc)
+        self.assertEqual(new_qc, qc)
+
+    def test_simple_multi_resets(self):
+        """Only first reset is collapsed"""
+        qc = QuantumCircuit(1, 2)
+        qc.measure(0, 0)
+        qc.reset(0)
+        qc.reset(0)
+
+        new_qc = ResetAfterMeasureSimplification()(qc)
+
+        ans_qc = QuantumCircuit(1, 2)
+        ans_qc.measure(0, 0)
+        ans_qc.x(0).c_if(ans_qc.clbits[0], 1)
+        ans_qc.reset(0)
+        self.assertEqual(new_qc, ans_qc)
+
+    def test_simple_multi_resets_with_resets_before_measure(self):
+        """Reset BEFORE measurement not collapsed"""
+        qc = QuantumCircuit(2, 2)
+        qc.measure(0, 0)
+        qc.reset(0)
+        qc.reset(1)
+        qc.measure(1, 1)
+
+        new_qc = ResetAfterMeasureSimplification()(qc)
+
+        ans_qc = QuantumCircuit(2, 2)
+        ans_qc.measure(0, 0)
+        ans_qc.x(0).c_if(Clbit(ClassicalRegister(2, "c"), 0), 1)
+        ans_qc.reset(1)
+        ans_qc.measure(1, 1)
+
+        self.assertEqual(new_qc, ans_qc)
+
+    def test_barriers_work(self):
+        """Test that barriers block consolidation"""
+        qc = QuantumCircuit(1, 1)
+        qc.measure(0, 0)
+        qc.barrier(0)
+        qc.reset(0)
+
+        new_qc = ResetAfterMeasureSimplification()(qc)
+        self.assertEqual(new_qc, qc)
+
+    def test_bv_circuit(self):
+        """Test Bernstein Vazirani circuit with midcircuit measurement."""
+        bitstring = "11111"
+        qc = QuantumCircuit(2, len(bitstring))
+        qc.x(1)
+        qc.h(1)
+        for idx, bit in enumerate(bitstring[::-1]):
+            qc.h(0)
+            if int(bit):
+                qc.cx(0, 1)
+            qc.h(0)
+            qc.measure(0, idx)
+            if idx != len(bitstring) - 1:
+                qc.reset(0)
+                # reset control
+                qc.reset(1)
+                qc.x(1)
+                qc.h(1)
+        new_qc = ResetAfterMeasureSimplification()(qc)
+        for op in new_qc.data:
+            if op.operation.name == "reset":
+                self.assertEqual(op.qubits[0], new_qc.qubits[1])