From 05a9b55db9e0a4909bd6e2cad0750a29beb3bb60 Mon Sep 17 00:00:00 2001
From: Jake Lishman <jake.lishman@ibm.com>
Date: Fri, 30 Aug 2024 15:25:27 +0100
Subject: [PATCH] Remove legacy-editable option from setuptools builds (#13059)

We needed this back when `setuptools` first introduced the new editable
installations, but at this point it should work more correctly without
it; our non-CI configurations haven't included it for some time.
---
 .azure/test-linux.yml          | 4 ----
 .azure/test-macos.yml          | 2 --
 .azure/test-windows.yml        | 2 --
 .github/workflows/coverage.yml | 1 -
 .github/workflows/slow.yml     | 2 --
 5 files changed, 11 deletions(-)

diff --git a/.azure/test-linux.yml b/.azure/test-linux.yml
index a773c15add..a641ae215e 100644
--- a/.azure/test-linux.yml
+++ b/.azure/test-linux.yml
@@ -92,8 +92,6 @@ jobs:
             # Build and install both qiskit and qiskit-terra so that any optionals
             # depending on `qiskit` will resolve correctly.
           displayName: "Install Terra directly"
-          env:
-            SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"
 
       - ${{ if eq(parameters.installOptionals, true) }}:
         - bash: |
@@ -178,8 +176,6 @@ jobs:
             sudo apt-get install -y graphviz pandoc
             image_tests/bin/pip check
           displayName: 'Install dependencies'
-          env:
-            SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"
 
         - bash: |
             echo "##vso[task.setvariable variable=HAVE_VISUAL_TESTS_RUN;]true"
diff --git a/.azure/test-macos.yml b/.azure/test-macos.yml
index b167df3f1c..9e9620e8ec 100644
--- a/.azure/test-macos.yml
+++ b/.azure/test-macos.yml
@@ -48,8 +48,6 @@ jobs:
             # depending on `qiskit` will resolve correctly.
           pip check
         displayName: 'Install dependencies'
-        env:
-          SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"
 
       - ${{ if eq(parameters.installOptionals, true) }}:
         - bash: |
diff --git a/.azure/test-windows.yml b/.azure/test-windows.yml
index eed1ef3eb6..8d86456bd7 100644
--- a/.azure/test-windows.yml
+++ b/.azure/test-windows.yml
@@ -47,8 +47,6 @@ jobs:
           # depending on `qiskit` will resolve correctly.
           pip check
         displayName: 'Install dependencies'
-        env:
-          SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"
 
       - ${{ if eq(parameters.installOptionals, true) }}:
         - bash: |
diff --git a/.github/workflows/coverage.yml b/.github/workflows/coverage.yml
index 33dc654801..95a0bda5d4 100644
--- a/.github/workflows/coverage.yml
+++ b/.github/workflows/coverage.yml
@@ -47,7 +47,6 @@ jobs:
           CARGO_INCREMENTAL: 0
           RUSTFLAGS: "-Cinstrument-coverage"
           LLVM_PROFILE_FILE: "qiskit-%p-%m.profraw"
-          SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"
 
       - name: Generate unittest coverage report
         run: |
diff --git a/.github/workflows/slow.yml b/.github/workflows/slow.yml
index 7f503b7de7..0207b1ec51 100644
--- a/.github/workflows/slow.yml
+++ b/.github/workflows/slow.yml
@@ -21,8 +21,6 @@ jobs:
           python -m pip install -U -r requirements-dev.txt -c constraints.txt
           python -m pip install -c constraints.txt -e .
           python -m pip install "qiskit-aer" "z3-solver" "cplex" -c constraints.txt
-        env:
-          SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"
       - name: Run all tests including slow
         run: stestr run
         env: