Merge pull request #2788 from Qiskit/fix/2746-ongoing-events

fix(events): add ongoing events in "future events"
This commit is contained in:
Randy 2022-09-14 12:48:02 -07:00 committed by GitHub
commit 3d6555186f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 19 additions and 1 deletions

View File

@ -74,11 +74,14 @@ function isEventInDateRange (
const eventStartDate: Date = new Date(startDate)
const eventEndDate: Date = new Date(endDate)
const isFutureRange: boolean = days > 0
const isOngoingEvent: boolean = eventStartDate <= today && today <= eventEndDate
let eventDateToCheck: Date
// Determine which date to check based on the days parameter and checking if
// the event's dates are valid.
if (!isFutureRange && !isNaN(eventEndDate.getTime())) {
if (isFutureRange && isOngoingEvent) {
return true
} else if (!isFutureRange && !isNaN(eventEndDate.getTime())) {
eventDateToCheck = eventEndDate
} else if (!isNaN(eventStartDate.getTime())) {
eventDateToCheck = eventStartDate

View File

@ -106,6 +106,13 @@ describe('isEventInDateRange', () => {
endDate: ''
}
expect(isEventInDateRange(mockEvent, days)).toBe(true)
// Event started 100 days ago and end in 100 days (ongoing event)
mockEvent = {
...mockEventBase,
startDate: getFormattedDate(-100),
endDate: getFormattedDate(100)
}
expect(isEventInDateRange(mockEvent, days)).toBe(true)
})
it('returns true if the event happened within the last 15 days', () => {
@ -134,6 +141,14 @@ describe('isEventInDateRange', () => {
endDate: ''
}
expect(isEventInDateRange(mockEvent, days)).toBe(false)
// Event started 100 days ago and end in 100 days (ongoing event)
mockEvent = {
...mockEventBase,
startDate: getFormattedDate(-100),
endDate: getFormattedDate(100)
}
expect(isEventInDateRange(mockEvent, days)).toBe(false)
})
})