Complete guides reorg To-Do (#1653)

This PR finishes with all the To-Do we had from the guides reorg

.github/workflows/notebook-test.yml

@@ -61,12 +61,6 @@ jobs:
             docs/guides/transpiler-stages.ipynb
             docs/guides/represent-quantum-computers.ipynb
             docs/guides/common-parameters.ipynb
-            docs/build/circuit-visualization.ipynb
-            docs/build-new/circuit-visualization.ipynb
-            docs/transpile/common-parameters.ipynb
-            docs/transpile/representing_quantum_computers.ipynb
-            docs/transpile/transpiler-stages.ipynb
-            docs/transpile/custom-backend.ipynb
 
       - name: Setup environment
         uses: ./.github/actions/set-up-notebook-testing

scripts/commands/checkPatternsIndex.ts

@@ -164,15 +164,6 @@ function maybePrintErrorsAndFail(
 }
 
 async function main() {
-  // Todo: Remove this conditional once the migration is done. This is used only to avoid
-  // the script crashing if the file's structure doesn't exist.
-  if (!(await pathExists(TOC_PATH))) {
-    console.log(
-      `🚧 Check skipped because the migration hasn't been completed.\n`,
-    );
-    process.exit(0);
-  }
-
   const toolsAllEntries = await getToolsTocEntriesToCheck();
   let [toolsEntries, duplicatesErrors] = await deduplicateEntries(
     TOC_PATH,

scripts/nb-tester/notebooks.toml

@@ -31,36 +31,6 @@ notebooks_normal_test = [
     "docs/guides/operator-class.ipynb",
     "docs/guides/error-mitigation-and-suppression-techniques.ipynb",
     "tutorials/explore-composer/explore-composer.ipynb",
-    # Todo: remove old notebooks
-    "docs/build/circuit-construction.ipynb",
-    "docs/build/circuit-library.ipynb",
-    "docs/build/circuit-visualization.ipynb",
-    "docs/build/classical-feedforward-and-control-flow.ipynb",
-    "docs/build/operator-class.ipynb",
-    "docs/build/operators-overview.ipynb",
-    "docs/build/pulse.ipynb",
-    "docs/build/save-circuits.ipynb",
-    "docs/run/dynamic-circuits-considerations.ipynb",
-    "docs/run/error-mitigation-explanation.ipynb",
-    "docs/run/get-backend-information.ipynb",
-    "docs/run/save-jobs.ipynb",
-    "docs/run/visualize-results.ipynb",
-    "docs/transpile/common-parameters.ipynb",
-    "docs/transpile/create-a-transpiler-plugin.ipynb",
-    "docs/transpile/custom-backend.ipynb",
-    "docs/transpile/custom-transpiler-pass.ipynb",
-    "docs/transpile/defaults-and-configuration-options.ipynb",
-    "docs/transpile/dynamical-decoupling-pass-manager.ipynb",
-    "docs/transpile/representing_quantum_computers.ipynb",
-    "docs/transpile/set-optimization.ipynb",
-    "docs/transpile/transpile-with-pass-managers.ipynb",
-    "docs/transpile/transpiler-plugins.ipynb",
-    "docs/transpile/transpiler-stages.ipynb",
-    "docs/verify/building_noise_models.ipynb",
-    "docs/verify/local-testing-mode.ipynb",
-    "docs/verify/plot-quantum-states.ipynb",
-    "docs/verify/simulate-with-qiskit-aer.ipynb",
-    "docs/verify/stabilizer-circuit-simulation.ipynb",
 ]
 
 # Don't test the following notebooks (this section can include glob patterns)
@@ -87,6 +57,4 @@ notebooks_no_mock = [
     "tutorials/combine-error-mitigation-options-with-the-estimator-primitive/combine-error-mitigation-options-with-the-estimator-primitive.ipynb",
     "tutorials/repeat-until-success/repeat-until-success.ipynb",
     "tutorials/build-repetition-codes/build-repetition-codes.ipynb",
-    # Todo: remove old notebook
-    "docs/start/hello-world.ipynb",
 ]