1.8 KiB
1.8 KiB
-
A brief but clear description of the issues/features
-
The brief description of the solution
-
The list of (newly) created test cases and test reports
-
Is necessary update is done on documents/reports?
-
Is user interface changed? Has the change updated in the history document? Has notice email sent to compiler team, CE/QA head and Peichen?
-
Is infrastructure APIs (codegen/program_analysis.c/h) changed? If so, did change history commented
-
Are other modules (owners) related to this PR? Need to approve as well
-
Any other information/note needed in the code review and sign-off ?
-
Have you run "make check" before final push for coding style check?
Python code check list|Dev(Y/N)|Rev1(Y/N)|Rev2(Y/N)|...
- Python lint 10 points------------------------|
- Code coverage: 100%--------------------------|
- ZeroDivisionError----------------------------|
- OverflowError: exp usage---------------------|
- KeyError-------------------------------------|
- IndexError-----------------------------------|
- ValueError: int(x)---------------------------|
- StopIteration: iterator larger than loop tc--|
- If logic can be replaced by built-in function| 10.If have global variable, remove it-----------| 11.If open file with "with open" API------------| 12.If duplicate logic can merge to one method---| 13.If enough comments for complicate code-------| 14.If enough info print to log for quick debug--| 15.If each method have clear input and output---| 16.If method and class argument can be fewer----| 17.If avoid mock in testing---------------------| 18.If have negative test cases------------------|