c65f966d76
The way address space declarations for builtins currently work is nearly useless. The code assumes the address spaces used for builtins is a confusingly named "target address space" from user code using __attribute__((address_space(N))) that matches the builtin declaration. There's no way to use this to declare a builtin that returns a language specific address space. The terminology used is highly cofusing since it has nothing to do with the the address space selected by the target to use for a language address space. This feature is essentially unused as-is. AMDGPU and NVPTX are the only in-tree targets attempting to use this. The AMDGPU builtins certainly do not behave as intended (i.e. all of the builtins returning pointers can never compile because the numbered address space never matches the expected named address space). The NVPTX builtins are missing tests for some, and the others seem to rely on an implicit addrspacecast. Change the used address space for builtins based on a target hook to allow using a language address space for a builtin. This allows the same builtin declaration to be used for multiple languages with similarly purposed address spaces (e.g. the same AMDGPU builtin can be used in OpenCL and CUDA even though the constant address spaces are arbitarily different). This breaks the possibility of using arbitrary numbered address spaces alongside the named address spaces for builtins. If this is an issue we probably need to introduce another builtin declaration character to distinguish language address spaces from so-called "target address spaces". llvm-svn: 338707 |
||
|---|---|---|
| .. | ||
| Inputs | ||
| address-spaces.cu | ||
| alias.cu | ||
| amdgpu-kernel-attrs.cu | ||
| builtins-amdgcn.cu | ||
| convergent.cu | ||
| cuda-builtin-vars.cu | ||
| device-stub.cu | ||
| device-var-init.cu | ||
| device-vtable.cu | ||
| filter-decl.cu | ||
| flush-denormals.cu | ||
| fp-contract.cu | ||
| function-overload.cu | ||
| kernel-amdgcn.cu | ||
| kernel-args-alignment.cu | ||
| kernel-args.cu | ||
| kernel-call.cu | ||
| launch-bounds.cu | ||
| library-builtin.cu | ||
| link-device-bitcode.cu | ||
| llvm-used.cu | ||
| nothrow.cu | ||
| printf-aggregate.cu | ||
| printf.cu | ||
| propagate-metadata.cu | ||
| ptx-kernels.cu | ||