hanchenye-llvm-project/lldb/tools
Jordan Rupprecht ad865d9d10 [lldb-vscode] Allow an empty 'breakpoints' field to clear breakpoints.
Per the DAP spec for SetBreakpoints [1], the way to clear breakpoints is: `To clear all breakpoint for a source, specify an empty array.`

However, leaving the breakpoints field unset is also a well formed request (note the `breakpoints?:` in the `SetBreakpointsArguments` definition). If it's unset, we have a couple choices:

1. Crash (current behavior)
2. Clear breakpoints
3. Return an error response that the breakpoints field is missing.

I propose we do (2) instead of (1), and treat an unset breakpoints field the same as an empty breakpoints field.

[1] https://microsoft.github.io/debug-adapter-protocol/specification#Requests_SetBreakpoints

Reviewed By: wallace, labath

Differential Revision: https://reviews.llvm.org/D88513
2020-09-30 11:32:06 -07:00
..
argdumper [lldb] Make lldb-argdumper a dependency of liblldb 2020-08-27 09:31:02 -07:00
compact-unwind
darwin-debug
darwin-threads
debugserver [debugserver] Extract function for default launch flavor 2020-09-09 11:35:44 -07:00
driver [lldb] Add reproducer verifier 2020-09-02 22:00:00 -07:00
intel-features [lldb] Get rid of LLDB_LIB_DIR and LLDB_IMPLIB_DIR in dotest 2020-08-28 15:45:54 -07:00
lldb-instr
lldb-server [lldb/ipv6] Support running lldb tests in an ipv6-only environment. 2020-09-30 11:08:41 -07:00
lldb-test [lldb] Get rid of helper CMake variables for Python 2020-08-17 08:47:52 -07:00
lldb-vscode [lldb-vscode] Allow an empty 'breakpoints' field to clear breakpoints. 2020-09-30 11:32:06 -07:00
CMakeLists.txt