hanchenye-llvm-project/clang
Alexey Bataev 7e6803e07b Incorrect implicit data-sharing for nested tasks
Summary:
There is a minor issue in how the implicit data-sharings for nested tasks are computed.

For the following example:
```
int x;
#pragma omp task shared(x)
#pragma omp task
x++;
```
We compute an implicit data-sharing of shared for `x` in the second task although I think that it should be firstprivate. Below you can find the part of the OpenMP spec that covers this example:
- // In a task generating construct, if no default clause is present, a variable for which the data-sharing attribute is not determined by the rules above and that in the enclosing context is determined to be shared by all implicit tasks bound to the current team is shared.//
- //In a task generating construct, if no default clause is present, a variable for which the data-sharing attribute is not determined by the rules above is firstprivate.//

Since each implicit-task has its own copy of `x`, we shouldn't apply the first rule.

Reviewers: ABataev

Reviewed By: ABataev

Subscribers: cfe-commits, rogfer01

Tags: #openmp

Differential Revision: https://reviews.llvm.org/D56430

llvm-svn: 350734
2019-01-09 15:58:05 +00:00
..
INPUTS
bindings [python] Make the collections import future-proof 2019-01-05 12:07:36 +00:00
cmake [CMake] Use hidden visibility for static libc++ in Fuchsia 2019-01-06 08:23:56 +00:00
docs __has_feature(pragma_clang_attribute_namespaces) should be __has_extension 2019-01-08 18:24:39 +00:00
examples cmake: Remove uses of add_llvm_loadable_module macro 2018-12-20 22:04:36 +00:00
include [AST] Store the results in OverloadExpr in a trailing array 2019-01-09 15:43:19 +00:00
lib Incorrect implicit data-sharing for nested tasks 2019-01-09 15:58:05 +00:00
runtime Fix check-hwasan with LLVM_BUILD_EXTERNAL_COMPILER_RT=ON 2019-01-03 22:50:45 +00:00
test Incorrect implicit data-sharing for nested tasks 2019-01-09 15:58:05 +00:00
tools Remove dependency-related arguments in clang-check. 2019-01-09 15:00:06 +00:00
unittests [libclang] Recommit r336590 with a fix for the memory leak in the test 2019-01-08 22:32:51 +00:00
utils Have MSVC Visualizer for DeducedTemplateSpecializationType show both the original template and deduced specialization 2019-01-06 04:58:48 +00:00
www DR674, PR38883, PR40238: Qualified friend lookup should look for a 2019-01-07 06:00:46 +00:00
.arcconfig
.clang-format
.clang-tidy
.gitignore NFC: Add .vscode to .gitignore 2018-12-03 22:51:07 +00:00
CMakeLists.txt inhereit LLVM_ENABLE_LIBXML2 2018-11-29 14:57:14 +00:00
CODE_OWNERS.TXT Add myself as code owner for OpenBSD driver 2018-11-30 21:42:34 +00:00
INSTALL.txt
LICENSE.TXT
ModuleInfo.txt
NOTES.txt PTH-- Remove feature entirely- 2018-12-04 14:34:09 +00:00
README.txt

README.txt

//===----------------------------------------------------------------------===//
// C Language Family Front-end
//===----------------------------------------------------------------------===//

Welcome to Clang.  This is a compiler front-end for the C family of languages
(C, C++, Objective-C, and Objective-C++) which is built as part of the LLVM
compiler infrastructure project.

Unlike many other compiler frontends, Clang is useful for a number of things
beyond just compiling code: we intend for Clang to be host to a number of
different source-level tools.  One example of this is the Clang Static Analyzer.

If you're interested in more (including how to build Clang) it is best to read
the relevant web sites.  Here are some pointers:

Information on Clang:             http://clang.llvm.org/
Building and using Clang:         http://clang.llvm.org/get_started.html
Clang Static Analyzer:            http://clang-analyzer.llvm.org/
Information on the LLVM project:  http://llvm.org/

If you have questions or comments about Clang, a great place to discuss them is
on the Clang development mailing list:
  http://lists.llvm.org/mailman/listinfo/cfe-dev

If you find a bug in Clang, please file it in the LLVM bug tracker:
  http://llvm.org/bugs/