48 lines
1.7 KiB
C++
48 lines
1.7 KiB
C++
//===--- ElseAfterReturnCheck.cpp - clang-tidy-----------------------------===//
|
|
//
|
|
// The LLVM Compiler Infrastructure
|
|
//
|
|
// This file is distributed under the University of Illinois Open Source
|
|
// License. See LICENSE.TXT for details.
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
#include "ElseAfterReturnCheck.h"
|
|
#include "clang/AST/ASTContext.h"
|
|
#include "clang/ASTMatchers/ASTMatchFinder.h"
|
|
#include "clang/Tooling/FixIt.h"
|
|
|
|
using namespace clang::ast_matchers;
|
|
|
|
namespace clang {
|
|
namespace tidy {
|
|
namespace readability {
|
|
|
|
void ElseAfterReturnCheck::registerMatchers(MatchFinder *Finder) {
|
|
// FIXME: Support continue, break and throw.
|
|
Finder->addMatcher(
|
|
compoundStmt(
|
|
forEach(ifStmt(hasThen(stmt(anyOf(returnStmt(),
|
|
compoundStmt(has(returnStmt()))))),
|
|
hasElse(stmt().bind("else")))
|
|
.bind("if"))),
|
|
this);
|
|
}
|
|
|
|
void ElseAfterReturnCheck::check(const MatchFinder::MatchResult &Result) {
|
|
const auto *If = Result.Nodes.getNodeAs<IfStmt>("if");
|
|
SourceLocation ElseLoc = If->getElseLoc();
|
|
DiagnosticBuilder Diag = diag(ElseLoc, "don't use else after return");
|
|
Diag << tooling::fixit::createRemoval(ElseLoc);
|
|
|
|
// FIXME: Removing the braces isn't always safe. Do a more careful analysis.
|
|
// FIXME: Change clang-format to correctly un-indent the code.
|
|
if (const auto *CS = Result.Nodes.getNodeAs<CompoundStmt>("else"))
|
|
Diag << tooling::fixit::createRemoval(CS->getLBracLoc())
|
|
<< tooling::fixit::createRemoval(CS->getRBracLoc());
|
|
}
|
|
|
|
} // namespace readability
|
|
} // namespace tidy
|
|
} // namespace clang
|