4d37af003f
Summary: Pretty straight-forward, just count all the variable declarations in the function's body, and if more than the configured threshold - do complain. Note that this continues perverse practice of disabling the new option by default. I'm not certain where is the balance point between not being too noisy, and actually enforcing the good practice. If we really want to not disable this by default, but also to not cause too many new warnings, we could default to 50 or so. But that is a lot of variables too... I was able to find one coding style referencing variable count: - https://www.kernel.org/doc/html/v4.15/process/coding-style.html#functions > Another measure of the function is the number of local variables. They shouldn’t exceed 5-10, or you’re doing something wrong. Reviewers: hokein, xazax.hun, JonasToth, aaron.ballman, alexfh Reviewed By: aaron.ballman Subscribers: kimgr, Eugene.Zelenko, rnkovacs, cfe-commits Tags: #clang-tools-extra Differential Revision: https://reviews.llvm.org/D44602 llvm-svn: 329902 |
||
|---|---|---|
| .. | ||
| clang-tidy | ||
| CMakeLists.txt | ||
| Doxyfile | ||
| ModularizeUsage.rst | ||
| README.txt | ||
| ReleaseNotes.rst | ||
| clang-doc.rst | ||
| clang-modernize.rst | ||
| clang-rename.rst | ||
| clang-tidy.rst | ||
| clangd.rst | ||
| conf.py | ||
| cpp11-migrate.rst | ||
| doxygen-mainpage.dox | ||
| doxygen.cfg.in | ||
| include-fixer.rst | ||
| index.rst | ||
| make.bat | ||
| modularize.rst | ||
| pp-trace.rst | ||
README.txt
------------------------------------------------------------- Documentation for the tools of clang-tools-extra repo project ------------------------------------------------------------- Sphinx and doxygen documentation is generated by executing make. Sphinx html files can be generated separately using make html. Doxygen html files can also be generated using make doxygen. The generated documentation will be placed in _build/html.