12a8b90a36
[analyzer] Malloc should assume that ownership is transfered when
...
calling an ObjC method ending with 'NoCopy'.
llvm-svn: 152037
2012-03-05 17:42:10 +00:00
15d48ec46f
Properly handle non-canonical underlying types in
...
ASTContext::getUnaryTransformType. This can happen if, for example,
an enumeration's underlying type is a typedef.
llvm-svn: 152031
2012-03-05 16:02:06 +00:00
189fa748ec
Fix a small difference in sema and codegen views of what needs to be output.
...
In the included testcase, soma thinks that we already have a definition after we
see the out of line decl. Codegen puts it in a deferred list, to be output if
a use is seen. This would break when we saw an explicit template instantiation
definition, since codegen would not be notified.
This patch adds a method to the consumer interface so that soma can notify
codegen that this decl is now required.
llvm-svn: 152024
2012-03-05 10:54:55 +00:00
7583ccdc1f
Fix a bug in the mangler where in 'namespace std { extern "C" {X;} }', X would not be seen to be in ::std::.
...
Migrate two other places where the same logic is used to use the helper function that already exists.
llvm-svn: 152022
2012-03-05 09:59:43 +00:00
afdc66f4fa
[arcmt]
...
-Make sure we don't change to '__weak' a __block variable used as output.
-Make sure we don't apply __weak twice.
Fixes rdar://10520757&10521362
llvm-svn: 152020
2012-03-05 08:46:24 +00:00
2a1b1c68f3
More tests for r152012.
...
llvm-svn: 152013
2012-03-05 04:06:25 +00:00
e18f0faff2
Lexing support for user-defined literals. Currently these lex as the same token
...
kinds as the underlying string literals, and we silently drop the ud-suffix;
those issues will be fixed by subsequent patches.
llvm-svn: 152012
2012-03-05 04:02:15 +00:00
8c738bc98a
Remove a recursive visitation in ExprEngine that is no longer needed because the CFG is fully linearized.
...
llvm-svn: 152007
2012-03-04 18:12:21 +00:00
72eebee0cb
Add tests for [over.literal]. Fix a few bugs which were exposed by the tests.
...
llvm-svn: 151997
2012-03-04 09:41:16 +00:00
332673d39d
From his comment in PR12168, Eli seems confused about the alignment assumptions
...
we're making. We only ignore implicit casts. Add a testcase showing that
we get the right behavior with explicit casts.
llvm-svn: 151994
2012-03-04 00:56:24 +00:00
aaa18fad7d
add a testcase for PR12094 and fix a crash on pointer to incomplete type,
...
reported by Richard Smith.
llvm-svn: 151993
2012-03-04 00:52:12 +00:00
522fa53703
Add a pile of tests for unrestricted unions, and advertise support for them.
...
llvm-svn: 151992
2012-03-03 23:51:05 +00:00
868dbda367
[analyzer] do not warn about returning stack-allocated memory when it comes from an ancestor stack frame.
...
llvm-svn: 151964
2012-03-03 01:22:03 +00:00
e2a3f75a12
Thread safety analysis: expand set of expressions that can be used to denote locks.
...
llvm-svn: 151956
2012-03-02 23:36:05 +00:00
bc638767f8
Reinstate r151879, r151880, reverted in r151922, along with a bugfix for
...
scalar emission of DeclRefExprs to const bools: emit scalar bools as i1,
not as i8.
In addition to the extra unit testing, this has successfully bootstrapped.
llvm-svn: 151955
2012-03-02 23:27:11 +00:00
9b9ebfc090
Add a test for the -Wstring-plus-int fixit note.
...
llvm-svn: 151951
2012-03-02 23:01:20 +00:00
611306eae6
Adding support for #pragma include_alias in MS compatibility mode. This implements PR 10705.
...
llvm-svn: 151949
2012-03-02 22:51:54 +00:00
71d6103295
Issue warning when late-parsed attributes have no declaration.
...
llvm-svn: 151947
2012-03-02 22:29:50 +00:00
bd2ee13e78
Make late-parsed attributes follow the conventions of ordinary
...
GNU attributes to a better extent, by allowing them in more
places on a declator.
llvm-svn: 151945
2012-03-02 22:12:59 +00:00
a2587ef26d
Thread safety analysis: handle CFG blocks which call functions marked as noreturn.
...
llvm-svn: 151944
2012-03-02 22:02:58 +00:00
ccec40d9b7
Add -Wstring-plus-int, which warns on "str" + int and int + "str".
...
It doesn't warn if the integer is known at compile time and within
the bounds of the string.
Discussion: http://comments.gmane.org/gmane.comp.compilers.clang.scm/47203
llvm-svn: 151943
2012-03-02 22:01:22 +00:00
7923ef41e1
objc: When issue diagnostic about deprecated method, also
...
issue the note if it is because message is sent to a forward class
declaration in delayed diagnostic. // rdar://10290322
llvm-svn: 151942
2012-03-02 21:50:02 +00:00
aa1f96add5
[analyzer diagnostics] flush locations *before* popping the current path when visiting a CallEnter.
...
Fixes <rdar://problem/10967815>
llvm-svn: 151938
2012-03-02 21:16:22 +00:00
2690838227
Fix an ABI problem with ptrdiff_t and intptr_t on PPC32
...
ptrdiff_t on PPC32 on Linux, etc. should be int not long.
This does not matter for C, but it does matter for C++ because of
name mangling.
The preprocessor test has been changed accordingly.
llvm-svn: 151935
2012-03-02 20:54:36 +00:00
99c07bc822
Move int<->pointer conversion warnings behind -Wint-conversions.
...
This is consistent with -Wbool-conversion. Let me know if you prefer
a different flag name.
llvm-svn: 151934
2012-03-02 20:23:08 +00:00
4af2cb3355
[Sema] Fix crash-on-invalid-code issue:
...
@class I;
@implementation I(cat) // crashes here
@end
rdar://10968158
llvm-svn: 151931
2012-03-02 19:14:29 +00:00
265087721a
[analyzer] Bound the size of the functions being inlined + provide
...
command line options for inlining tuning.
This adds the option for stack depth bound as well as function size
bound.
+ minor doxygenification
llvm-svn: 151930
2012-03-02 19:05:03 +00:00
bf48281c25
Change diagnostic test for my last patch.
...
// rdar://10961370
llvm-svn: 151923
2012-03-02 17:05:03 +00:00
d01281fe0d
Revert r151879, r151880, "PR12145: Avoid emitting loads of constexpr variables in contexts where there" and "Fix buildbot: make this test less dependent on the value names in the produced IR."
...
They broke bootstrap.
llvm-svn: 151922
2012-03-02 16:24:25 +00:00
35ecb36fcd
Ensure that we instantiate static reference data members of class templates
...
early, since their values can be used in constant expressions in C++11. For
odr-use checking, the opposite change is required, since references are
odr-used whether or not they satisfy the requirements for appearing in a
constant expression.
llvm-svn: 151881
2012-03-02 04:14:40 +00:00
545f38c3d2
Fix buildbot: make this test less dependent on the value names in the produced IR.
...
llvm-svn: 151880
2012-03-02 03:22:38 +00:00
a541a3bbee
PR12145: Avoid emitting loads of constexpr variables in contexts where there
...
is no odr-use of the variable. Go slightly beyond what the standard requires
for variables of reference type.
llvm-svn: 151879
2012-03-02 03:16:32 +00:00
f9e9d33019
[analyzer diagnostics] Change CompactPathDiagnostic to recursively compact diagnostics in calls into macro pieces.
...
Also fix handling of macros within calls in the HTMLDiagnostics.
This also adds a test case for r151774.
llvm-svn: 151872
2012-03-02 01:27:31 +00:00
3854a55a17
c/objc: problem originally reported as an objective-c bug.
...
But it is in the underlying c part of clang. clang crashes
in IRGen when passing an incomplete type argument to
variadic function (instead of diagnosing the bug).
// rdar://10961370
llvm-svn: 151862
2012-03-01 23:42:00 +00:00
c4e5d0ccda
Make CodeGenFunction::EmitBlockCopyAndAutorelease actually do what its name says.
...
llvm-svn: 151853
2012-03-01 22:52:28 +00:00
5bc1f47b00
Update test for llvm assembly output change. Also add a fixme that this
...
shouldn't be relying on assembly emission.
For the record we should check the metadata output from the front
end and then check in the backend that such a thing emits a pubtypes
entry.
llvm-svn: 151851
2012-03-01 22:49:10 +00:00
d5c3027473
[analyzer] Turn inlining on by default for better testing exposure.
...
Fix a test, which was most likely an unintended recursive call.
llvm-svn: 151848
2012-03-01 22:37:46 +00:00
28a7a1198b
Add a flag -fthread-sanitizer.
...
This flag enables ThreadSanitizer instrumentation committed to llvm as r150423.
The patch includes one test for -fthread-sanitizer and one similar test for -faddress-sanitizer.
This patch does not modify the linker flags (as we do it for -faddress-sanitizer) because the run-time library is not yet
committed and it's structure in compiler-rt is not 100% clear.
The users manual wil be changed in a separate commit.
llvm-svn: 151846
2012-03-01 22:27:08 +00:00
c1e4dd0e8e
Change @import to @__experimental_modules_import. We are not ready to commit to a particular syntax for modules,
...
and don't have time to push it forward in the near future.
llvm-svn: 151841
2012-03-01 22:07:04 +00:00
8dc53af5dc
[analyzer] Fix a regression introduced in malloc with
...
attributes, introduced in r151188.
+ the test to catch it.
Thanks to Ahmed Charles for pointing this out.
llvm-svn: 151840
2012-03-01 22:06:06 +00:00
4b6753cf10
Reapply r151702 with a small fix for a failure to cut and paste
...
correctly.
Still rdar://10900684
llvm-svn: 151838
2012-03-01 21:36:52 +00:00
23b1be991e
Fix the isReferenced bit on parameters in a couple of edge cases. PR12153.
...
llvm-svn: 151837
2012-03-01 21:32:56 +00:00
888d4a62fa
Remove test/Sema/many-logical-ops.c since it fails in linux variants.
...
Will bring it up once the issue is fixed properely.
llvm-svn: 151830
2012-03-01 19:47:26 +00:00
7598fadd78
Merge __has_attribute tests. Patch by Jonathan Sauer!
...
llvm-svn: 151819
2012-03-01 17:45:53 +00:00
cdb9f302d0
StmtProfiler: Add a null check for child statements.
...
llvm-svn: 151812
2012-03-01 16:34:31 +00:00
908f130d58
Implement double underscore names support in __has_attribute
...
llvm-svn: 151809
2012-03-01 14:53:16 +00:00
ead9a05596
Revert r151800, which was committed without review and has correctness issues.
...
llvm-svn: 151804
2012-03-01 06:49:39 +00:00
cd5092dfba
Implements support for #pragma include_alias in ms compatibility mode. Fixes PR10705.
...
llvm-svn: 151800
2012-03-01 04:18:49 +00:00
9ecff02a45
Added support for parsing declspecs on enumerations. Fixes PR8783
...
llvm-svn: 151798
2012-03-01 04:09:28 +00:00
98b01edc8c
Implement "optimization" for lambda-to-block conversion which inlines the generated block literal for lambdas which are immediately converted to block pointer type. This simplifies the AST, avoids an unnecessary copy of the lambda and makes it much easier to avoid copying the result onto the heap.
...
Note that this transformation has a substantial semantic effect outside of ARC: it gives the converted lambda lifetime semantics similar to a block literal. With ARC, the effect is much less obvious because the lifetime of blocks is already managed.
llvm-svn: 151797
2012-03-01 04:01:32 +00:00
5e0cac784a
Reject 'a = {0} = {0}' rather than parsing it as '(a = {0}) = {0}'. Also
...
improve the diagnostics for some attempts to use initializer lists in
expressions.
llvm-svn: 151794
2012-03-01 02:59:17 +00:00
05e916bc95
Fix regression from llvm-gcc where we should NOT emit a warning about __attribute__((NSObject)) on a property declaration. This is needed to have retain properties for non-object pointers. Fixes <rdar://problem/10930507>.
...
llvm-svn: 151786
2012-03-01 01:40:32 +00:00
2c21c449d9
Move suport for redefining operator keywords from -fms-extensions to -fms-compatibility.
...
llvm-svn: 151776
2012-03-01 00:13:46 +00:00
2e686205e8
Allow operator keywords to be #defined in ms-ext mode.
...
Fixes PR10606.
I'm not sure if this is the best way to go about it, but
I locally enabled this code path without the msext conditional,
and all tests pass, except for test/Preprocessor/cxx_oper_keyword.cpp
which explicitly checks that operator keywords can't be redefined.
I also parsed chromium/win with a clang with and without this patch.
It introduced no new errors, but removes 43 existing errors.
llvm-svn: 151768
2012-02-29 22:54:43 +00:00
203ea38085
Test for my last patch. // rdar://10267155.
...
llvm-svn: 151767
2012-02-29 22:21:36 +00:00
86c2f5cc70
objective-c: provide fixit hint when atomic property does not
...
have matching user defined setter/getter and a warning is issued.
In this case, a fixit note is displayed. // rdar://10267155
llvm-svn: 151766
2012-02-29 22:18:55 +00:00
ff3f99bf0a
I referenced the incorrect rdar in my previous commit (r151745). Add the
...
correct radar number to the test case for tracking purposes.
rdar://10551066
llvm-svn: 151746
2012-02-29 20:18:57 +00:00
b1cfc6864f
Allocate TargetLibraryInfo for the CodeGen passes. Otherwise, it's instantiated
...
by the BAA pass, which uses the default TargetLibraryInfo constructor.
Unfortunately, the default TargetLibraryInfo constructor assumes all library
calls are available and thus ignores -fno-builtin.
rdar://10947759
llvm-svn: 151745
2012-02-29 20:14:59 +00:00
e0c03cab58
[analyzer] Malloc: A pointer might escape through CFContainers APIs,
...
funopen, setvbuf.
Teach the checker and the engine about these APIs to resolve malloc
false positives. As I am adding more of these APIs, it is clear that all
this should be factored out into a separate callback (for example,
region escapes). Malloc, KeyChainAPI and RetainRelease checkers could
all use it.
llvm-svn: 151737
2012-02-29 18:42:47 +00:00
c2f9dc91c1
Revert r151702, "Add support for handling captured variables in lambda debug
...
info.", which broke some -O0 -g tests.
llvm-svn: 151730
2012-02-29 16:28:29 +00:00
c7b718eb53
Tentatively fix PR12117. The test case from the bug now passes, and all existing tests still pass, but there may still be corner cases.
...
llvm-svn: 151716
2012-02-29 12:47:43 +00:00
6f8780bed1
Reapply r151638 and r151641.
...
The bug that was caught by Apple's internal buildbots was valid and also showed another bug in my implementation.
These are now fixed, with regression tests added to catch them both (not Darwin-specific).
Original log:
====================
Revert r151638 because it causes assertion hit on PCH creation for Cocoa.h
Original log:
---------------------
Correctly track tags and enum members defined in the prototype of a function, and ensure they are properly scoped.
This fixes code such as:
enum e {x, y};
int f(enum {y, x} n) {
return 0;
}
This finally fixes PR5464 and PR5477.
---------------------
I also reverted r151641 which was enhancement on top of r151638.
====================
llvm-svn: 151712
2012-02-29 10:24:19 +00:00
64aea6524d
Remove a recursive visitiation in ExprEngine that is no longer needed
...
because the CFG is fully linearized.
llvm-svn: 151711
2012-02-29 08:42:57 +00:00
ef5c554df4
[analyzer] Tweak the UnreachableCode checker to not warning about unreachable default blocks. Patch by Cyril Roelandt!
...
llvm-svn: 151709
2012-02-29 06:05:28 +00:00
e4f22dfa95
A couple minor bug-fixes for template instantiation for expressions which are sometimes potentially evaluated.
...
llvm-svn: 151707
2012-02-29 04:03:55 +00:00
3dbeb55874
[driver] Emit an error when trying to use ARC on macosx earlier than 10.6
...
rdar://10459258
llvm-svn: 151706
2012-02-29 03:43:52 +00:00
3203f6b9da
Add support for handling captured variables in lambda debug info.
...
This currently doesn't handle capturing the 'this' pointer for any
enclosing class.
Steal the lambda-expressions.cpp testcase and debugify it and try
to use more variables to proof it against random changes.
Part of rdar://10900684
llvm-svn: 151702
2012-02-29 03:25:30 +00:00
c6237c6e05
Make the odr-use logic work correctly for constant-expressions. PR12006.
...
llvm-svn: 151699
2012-02-29 03:16:56 +00:00
10cea170d2
clang/test/Analysis/stats.c: Fix up r151656.
...
llvm-svn: 151695
2012-02-29 02:04:39 +00:00
f1801d65e7
clang/test/Analysis/stats.c: Mark this as XFAIL: mingw32.
...
FIXME: Could we guarantee not to get stack overflow also on mingw?
llvm-svn: 151692
2012-02-29 01:50:38 +00:00
576cbd03b4
Make sure list-initialization of arrays works correctly in explicit type conversions. PR12121.
...
llvm-svn: 151674
2012-02-29 00:00:28 +00:00
fcbfdee5df
[libclang] Add a test I forgot to commit.
...
llvm-svn: 151669
2012-02-28 23:39:24 +00:00
5cb4760aed
[PCH] Include a darwin-only PCH test on Cocoa.h.
...
llvm-svn: 151668
2012-02-28 23:39:20 +00:00
5929ef2ee7
Revert r151638 because it causes assertion hit on PCH creation for Cocoa.h
...
Original log:
---------------------
Correctly track tags and enum members defined in the prototype of a function, and ensure they are properly scoped.
This fixes code such as:
enum e {x, y};
int f(enum {y, x} n) {
return 0;
}
This finally fixes PR5464 and PR5477.
---------------------
I also reverted r151641 which was enhancement on top of r151638.
llvm-svn: 151667
2012-02-28 23:39:14 +00:00
12edeb0899
Single- and zero-element initializer lists to scalars are list-initializations. Fixes PR12118.
...
llvm-svn: 151666
2012-02-28 23:36:38 +00:00
265a421dd9
Modern objective-c translator. rewriting ivars of aggregate type.
...
llvm-svn: 151662
2012-02-28 22:45:07 +00:00
75de32322a
[analyzer] Leaks should be uniqued by the allocation point in the
...
closest function context (RetainCountChecker).
llvm-svn: 151661
2012-02-28 22:39:22 +00:00
16f3831064
[analyzer] Retain release: drop the line number info from the leak
...
message.
llvm-svn: 151657
2012-02-28 21:49:08 +00:00
b6e2854f68
[analyzer] Stats: Add the stats about remove dead bindings, correct the
...
test.
llvm-svn: 151656
2012-02-28 21:49:04 +00:00
2ad368fce3
[driver] Add support for -g2 and -ggdb debug flags.
...
rdar://10947759
llvm-svn: 151654
2012-02-28 20:49:04 +00:00
051390fffa
Correctly track tags and enum members defined in the prototype of a function, and ensure they are properly scoped.
...
This fixes code such as:
enum e {x, y};
int f(enum {y, x} n) {
return 0;
}
This finally fixes PR5464 and PR5477.
llvm-svn: 151638
2012-02-28 18:12:11 +00:00
7dff8a68df
Basic coverage test for conversion-to-block-pointer for lambda expressions.
...
llvm-svn: 151616
2012-02-28 03:32:48 +00:00
6ca4fd5b88
[analyzer] Leaks should be uniqued by the allocation point in the
...
closest function context (Keychain API).
llvm-svn: 151613
2012-02-28 03:07:06 +00:00
06a77fc1b9
[analyzer] Fix Malloc False Positive (PR 12100)
...
When allocated buffer is passed to CF/NS..NoCopy functions, the
ownership is transfered unless the deallocator argument is set to
'kCFAllocatorNull'.
llvm-svn: 151608
2012-02-28 01:54:22 +00:00
3bc5372fae
[analyzer] teach analyzer about ObjC literals, thus trimming out a false positive with the malloc() checker involving
...
comparing literal addresses to nil.
Fixes <rdar://problem/10579586>
llvm-svn: 151602
2012-02-28 00:56:05 +00:00
43ffba2676
[analyzer] Leaks should be uniqued by the allocation point in the
...
closest function context.
This prevents us from uniqueing all leaks from the same allocation
helper. radar://10932226
llvm-svn: 151592
2012-02-27 23:40:55 +00:00
9cd797aa3e
Fix a test case that was added in r151570. The redirect of output was broken
...
so no testing was actually done. Further, the commands produce no output.
The redirection has been fixed and the test has been disabled.
llvm-svn: 151591
2012-02-27 23:40:41 +00:00
a235e2d8ad
Hack in a loud error for PR12086. Better than a silent miscompile.
...
llvm-svn: 151586
2012-02-27 23:20:01 +00:00
465e137558
When evaluating integer expressions include a check for sub-expressions
...
depth and error if we exceed a max value, to make sure we avoid a stack overflow.
This is a hacky temporary fix. rdar://10913206.
llvm-svn: 151585
2012-02-27 23:18:37 +00:00
59b10db2bc
After numerous requests, have Objective-C 'method declared here' notes mention the actual method. This looks better within an IDE, where text isn't always regurgitated in the presentation of a warning. Fixes radar 10914035.
...
llvm-svn: 151579
2012-02-27 22:55:11 +00:00
aa6feaa7ea
Implement a FIXME for conversion sequence distinction. Should fix PR12092.
...
llvm-svn: 151577
2012-02-27 22:38:26 +00:00
b028654031
[analyzer] Add -analyzer-stats, which hooks up LLVM stats tracking.
...
As in http://llvm.org/docs/ProgrammersManual.html#Statistic
llvm-svn: 151570
2012-02-27 21:33:16 +00:00
84e6e5cd1a
Fix a couple bugs in the way we handle array indexes in array bounds checking. Specifically, make sure we don't ignore explicit casts in indexes, and make sure we use unsigned extension/comparisons on indexes. Fixes <rdar://problem/10916006>.
...
llvm-svn: 151569
2012-02-27 21:21:40 +00:00
6776673f09
Convert initializer lists to temporaries in CreateBuiltinBinOp. Allows assignment of init lists to built-in types and resolves PR12088.
...
llvm-svn: 151551
2012-02-27 20:34:02 +00:00
afa84ae85b
Add missing code for compound literals of complex type. <rdar://problem/10938628>
...
llvm-svn: 151549
2012-02-27 20:26:13 +00:00
d6a56db7b6
Test case for r151429/r151430, which ensures llvm.lifetime intrinsics are not
...
being emitted at -O0, but are emitted when optimizations are enabled.
llvm-svn: 151533
2012-02-27 18:45:03 +00:00
5bd52c1b3e
Make this test a bit more robust for debug info changes.
...
llvm-svn: 151518
2012-02-27 08:22:57 +00:00
619ecdc80f
Ensure that we delete default constructors in the right cases. Don't delete the
...
default constructor of a union if it has a const member with no user-provided
default constructor.
llvm-svn: 151516
2012-02-27 06:07:25 +00:00
fa933d1225
Fix decltype crash-on-invalid, if we don't find a matching ')' for an ill-formed
...
decltype expression.
llvm-svn: 151515
2012-02-27 05:24:00 +00:00
2fbb3d84a2
Tests for r151508.
...
llvm-svn: 151509
2012-02-26 23:49:01 +00:00
Anna Zaks