[mips] Correct size_t and ptrdiff_t for N32.

Summary:
Correct size_t to be unsigned int and ptrdiff_t to be signed long. The types were the correct size before this change but
the exact type matters for name mangling and exception handling in C++.

Reviewers: atanasyan

Reviewed By: atanasyan

Differential Revision: http://reviews.llvm.org/D3470

llvm-svn: 207093
This commit is contained in:
Daniel Sanders 2014-04-24 09:58:52 +00:00
parent b6c47a5bd2
commit ff1c044ada
2 changed files with 71 additions and 10 deletions

View File

@ -5777,32 +5777,44 @@ class Mips64TargetInfoBase : public MipsTargetInfoBase {
public: public:
Mips64TargetInfoBase(const llvm::Triple &Triple) Mips64TargetInfoBase(const llvm::Triple &Triple)
: MipsTargetInfoBase(Triple, "n64", "mips64r2") { : MipsTargetInfoBase(Triple, "n64", "mips64r2") {
LongWidth = LongAlign = 64;
PointerWidth = PointerAlign = 64;
LongDoubleWidth = LongDoubleAlign = 128; LongDoubleWidth = LongDoubleAlign = 128;
LongDoubleFormat = &llvm::APFloat::IEEEquad; LongDoubleFormat = &llvm::APFloat::IEEEquad;
if (getTriple().getOS() == llvm::Triple::FreeBSD) { if (getTriple().getOS() == llvm::Triple::FreeBSD) {
LongDoubleWidth = LongDoubleAlign = 64; LongDoubleWidth = LongDoubleAlign = 64;
LongDoubleFormat = &llvm::APFloat::IEEEdouble; LongDoubleFormat = &llvm::APFloat::IEEEdouble;
} }
setN64ABITypes();
SuitableAlign = 128; SuitableAlign = 128;
MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64; MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64;
} }
void setN64ABITypes() {
LongWidth = LongAlign = 64;
PointerWidth = PointerAlign = 64;
SizeType = UnsignedLong;
PtrDiffType = SignedLong;
}
void setN32ABITypes() {
LongWidth = LongAlign = 32;
PointerWidth = PointerAlign = 32;
SizeType = UnsignedInt;
PtrDiffType = SignedInt;
}
bool setABI(const std::string &Name) override { bool setABI(const std::string &Name) override {
if (Name == "n32") { if (Name == "n32") {
LongWidth = LongAlign = 32; setN32ABITypes();
PointerWidth = PointerAlign = 32;
ABI = Name; ABI = Name;
return true; return true;
} else if (Name == "n64") { } else if (Name == "n64" || Name == "64") {
ABI = Name; setN64ABITypes();
return true;
} else if (Name == "64") {
ABI = "n64"; ABI = "n64";
return true; return true;
} else }
return false; return false;
} }
void getTargetDefines(const LangOptions &Opts, void getTargetDefines(const LangOptions &Opts,
MacroBuilder &Builder) const override { MacroBuilder &Builder) const override {
MipsTargetInfoBase::getTargetDefines(Opts, Builder); MipsTargetInfoBase::getTargetDefines(Opts, Builder);

View File

@ -0,0 +1,49 @@
// RUN: %clang_cc1 -x c++ -emit-llvm -triple=mips-unknown-linux-gnu < %s | FileCheck --check-prefix=O32 %s
// RUN: %clang_cc1 -x c++ -emit-llvm -triple=mips64-unknown-linux-gnu -target-abi n32 < %s | FileCheck --check-prefix=N32 %s
// RUN: %clang_cc1 -x c++ -emit-llvm -triple=mips64-unknown-linux-gnu -target-abi 64 < %s | FileCheck --check-prefix=N64 %s
// Test that the size_t is correct for the ABI. It's not sufficient to be the
// correct size, it must be the same type for correct name mangling.
long *alloc_long() {
long *rv = new long; // size_t is implicit in the new operator
return rv;
}
// O32-LABEL: define i32* @_Z10alloc_longv()
// O32: call noalias i8* @_Znwj(i32 4)
// N32-LABEL: define i32* @_Z10alloc_longv()
// N32: call noalias i8* @_Znwj(i32 4)
// N64-LABEL: define i64* @_Z10alloc_longv()
// N64: call noalias i8* @_Znwm(i64 8)
long *alloc_long_array() {
long *rv = new long[2];
return rv;
}
// O32-LABEL: define i32* @_Z16alloc_long_arrayv()
// O32: call noalias i8* @_Znaj(i32 8)
// N32-LABEL: define i32* @_Z16alloc_long_arrayv()
// N32: call noalias i8* @_Znaj(i32 8)
// N64-LABEL: define i64* @_Z16alloc_long_arrayv()
// N64: call noalias i8* @_Znam(i64 16)
#include <stddef.h>
void size_t_arg(size_t a) {
}
// O32-LABEL: _Z10size_t_argj
// N32-LABEL: _Z10size_t_argj
// N64-LABEL: _Z10size_t_argm
void ptrdiff_t_arg(ptrdiff_t a) {
}
// O32-LABEL: _Z13ptrdiff_t_argi
// N32-LABEL: _Z13ptrdiff_t_argi
// N64-LABEL: _Z13ptrdiff_t_argl