replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

FileNameMatchTrie: Use StringRef instead of Twines where possible. 

llvm-svn: 165412
This commit is contained in:
Daniel Jasper 2012-10-08 18:31:54 +00:00
parent 22b9fd2f2e
commit fddb32c3d6
3 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
clang/include/clang/Tooling/FileMatchTrie.h
View File

@ -18,7 +18,6 @@
#include "clang/Basic/LLVM.h"
#include "llvm/ADT/OwningPtr.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/ADT/Twine.h"
#include <string>
#include <vector>
@ -28,7 +27,7 @@ namespace tooling {
struct PathComparator {
virtual ~PathComparator() {}
virtual bool equivalent(const Twine &FileA, const Twine &FileB) const = 0;
virtual bool equivalent(StringRef FileA, StringRef FileB) const = 0;
};
class FileMatchTrieNode;

5
clang/lib/Tooling/FileMatchTrie.cpp
View File

@ -23,9 +23,8 @@ namespace tooling {
/// \brief Default \c PathComparator using \c llvm::sys::fs::equivalent().
struct DefaultPathComparator : public PathComparator {
virtual ~DefaultPathComparator() {}
virtual bool equivalent(const Twine &FileA, const Twine &FileB) const {
return FileA.str() == FileB.str() ||
llvm::sys::fs::equivalent(FileA, FileB);
virtual bool equivalent(StringRef FileA, StringRef FileB) const {
return FileA == FileB || llvm::sys::fs::equivalent(FileA, FileB);
}
};

4
clang/unittests/Tooling/CompilationDatabaseTest.cpp
View File

@ -84,8 +84,8 @@ static CompileCommand findCompileArgsInJsonDatabase(StringRef FileName,
struct FakeComparator : public PathComparator {
virtual ~FakeComparator() {}
virtual bool equivalent(const Twine &FileA, const Twine &FileB) const {
return StringRef(FileA.str()).equals_lower(FileB.str());
virtual bool equivalent(StringRef FileA, StringRef FileB) const {
return FileA.equals_lower(FileB);
}
};