replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Remove IsDefinition from CodeGenModule::setTypeVisibility; it is always true. 

llvm-svn: 124529
This commit is contained in:
Anders Carlsson 2011-01-29 05:26:32 +00:00
parent 6b3afd7df1
commit fd4834061c
4 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clang/lib/CodeGen/CGRTTI.cpp
View File

@ -644,7 +644,7 @@ llvm::Constant *RTTIBuilder::BuildTypeInfo(QualType Ty, bool Force) {
// compatibility.
if (const RecordType *RT = dyn_cast<RecordType>(Ty))
CGM.setTypeVisibility(GV, cast<CXXRecordDecl>(RT->getDecl()),
/*ForRTTI*/ true, /*ForDefinition*/ true);
/*ForRTTI=*/true);
else if (Hidden ||
(CGM.getCodeGenOpts().HiddenWeakVTables &&
Linkage == llvm::GlobalValue::LinkOnceODRLinkage)) {

2
clang/lib/CodeGen/CGVTables.cpp
View File

@ -3019,7 +3019,7 @@ CodeGenVTables::EmitVTableDefinition(llvm::GlobalVariable *VTable,
VTable->setLinkage(Linkage);
// Set the right visibility.
CGM.setTypeVisibility(VTable, RD, /*ForRTTI*/ false, /*ForDef*/ true);
CGM.setTypeVisibility(VTable, RD, /*ForRTTI=*/false);
}
llvm::GlobalVariable *

5
clang/lib/CodeGen/CodeGenModule.cpp
View File

@ -195,9 +195,8 @@ void CodeGenModule::setGlobalVisibility(llvm::GlobalValue *GV,
/// associated with the given type.
void CodeGenModule::setTypeVisibility(llvm::GlobalValue *GV,
const CXXRecordDecl *RD,
bool IsForRTTI,
bool IsForDefinition) const {
setGlobalVisibility(GV, RD, IsForDefinition);
bool IsForRTTI) const {
setGlobalVisibility(GV, RD, /*IsForDefinition=*/true);
if (!CodeGenOpts.HiddenWeakVTables)
return;

2
clang/lib/CodeGen/CodeGenModule.h
View File

@ -265,7 +265,7 @@ public:
/// setTypeVisibility - Set the visibility for the given global
/// value which holds information about a type.
void setTypeVisibility(llvm::GlobalValue *GV, const CXXRecordDecl *D,
bool IsForRTTI, bool IsForDefinition) const;
bool IsForRTTI) const;
llvm::Constant *GetAddrOfGlobal(GlobalDecl GD) {
if (isa<CXXConstructorDecl>(GD.getDecl()))