[clang-tidy] Replace redundant checks with an assert().
findStyleKind is only called if D is an explicit identifier with a name, so the checks for operators will never return true. The explicit assert() enforces this invariant. Differential Revision: https://reviews.llvm.org/D52179 llvm-svn: 342514
This commit is contained in:
parent
aaf4e2cbba
commit
fcfcd508e4
|
@ -385,6 +385,9 @@ static StyleKind findStyleKind(
|
||||||
const NamedDecl *D,
|
const NamedDecl *D,
|
||||||
const std::vector<llvm::Optional<IdentifierNamingCheck::NamingStyle>>
|
const std::vector<llvm::Optional<IdentifierNamingCheck::NamingStyle>>
|
||||||
&NamingStyles) {
|
&NamingStyles) {
|
||||||
|
assert(D && D->getIdentifier() && !D->getName().empty() && !D->isImplicit() &&
|
||||||
|
"Decl must be an explicit identifier with a name.");
|
||||||
|
|
||||||
if (isa<ObjCIvarDecl>(D) && NamingStyles[SK_ObjcIvar])
|
if (isa<ObjCIvarDecl>(D) && NamingStyles[SK_ObjcIvar])
|
||||||
return SK_ObjcIvar;
|
return SK_ObjcIvar;
|
||||||
|
|
||||||
|
@ -548,8 +551,6 @@ static StyleKind findStyleKind(
|
||||||
|
|
||||||
if (const auto *Decl = dyn_cast<CXXMethodDecl>(D)) {
|
if (const auto *Decl = dyn_cast<CXXMethodDecl>(D)) {
|
||||||
if (Decl->isMain() || !Decl->isUserProvided() ||
|
if (Decl->isMain() || !Decl->isUserProvided() ||
|
||||||
Decl->isUsualDeallocationFunction() ||
|
|
||||||
Decl->isCopyAssignmentOperator() || Decl->isMoveAssignmentOperator() ||
|
|
||||||
Decl->size_overridden_methods() > 0)
|
Decl->size_overridden_methods() > 0)
|
||||||
return SK_Invalid;
|
return SK_Invalid;
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue