replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Replacing a custom AST matcher with some builtin AST matchers; NFC, and existing tests should provide sufficient coverage. 

llvm-svn: 245492
This commit is contained in:
Aaron Ballman 2015-08-19 20:26:22 +00:00
parent 814b705984
commit f7c25368b7
1 changed files with 1 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
clang-tools-extra/clang-tidy/modernize/PassByValueCheck.cpp
View File

@ -45,19 +45,6 @@ AST_MATCHER(CXXRecordDecl, isMoveConstructible) {
return false;
}
/// \brief Matches non-deleted copy constructors.
///
/// Given
/// \code
/// struct Foo { Foo(const Foo &) = default; };
/// struct Bar { Bar(const Bar &) = deleted; };
/// \endcode
/// constructorDecl(isNonDeletedCopyConstructor())
/// matches "Foo(const Foo &)".
AST_MATCHER(CXXConstructorDecl, isNonDeletedCopyConstructor) {
return Node.isCopyConstructor() && !Node.isDeleted();
}
static TypeMatcher constRefType() {
return lValueReferenceType(pointee(isConstQualified()));
}
@ -158,7 +145,7 @@ void PassByValueCheck::registerMatchers(MatchFinder *Finder) {
anyOf(constRefType(), nonConstValueType()))))
.bind("Param")))),
hasDeclaration(constructorDecl(
isNonDeletedCopyConstructor(),
isCopyConstructor(), unless(isDeleted()),
hasDeclContext(recordDecl(isMoveConstructible())))))))
.bind("Initializer")))
.bind("Ctor"),