replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fixed a VC++ issue related to bitmasks. As it turns out the compiler fills the unused bits of the word a bitmask is stored in with '1' (or randomly, I can't tell, I've seen '1' so far only), which creates wrong results in certain cases. 

Please review.

llvm-svn: 42061
This commit is contained in:
Hartmut Kaiser 2007-09-17 21:11:08 +00:00
parent 39d641f526
commit f696cfcf06
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
clang/include/clang/AST/Type.h
View File

@ -222,7 +222,10 @@ protected:
virtual ~Type();
friend class ASTContext;
public:
TypeClass getTypeClass() const { return TC; }
// Masking the 4 bits from the bitfield above is necessary, since at least
// VC++ fills the unused bits of the word the bitfield is stored in with
// '1' resulting in invalid values returned from this function otherwise.
TypeClass getTypeClass() const { return static_cast<TypeClass>(TC & 0xf); }
bool isCanonical() const { return CanonicalType.getTypePtr() == this; }