[lldb-mi] Remove use of dialog box
Summary: This really is only implemented on Windows, and it requires us to pull in User32. This was only useful when debugging on lldb-mi on Windows, and there doesn't seem to be a good reason why using a dialog box is better than what exists for other platforms. Reviewers: zturner, jingham, compnerd Subscribers: ki.stfu Differential Revision: https://reviews.llvm.org/D56755 llvm-svn: 351276
This commit is contained in:
parent
34ac509ac8
commit
f510bc7972
|
@ -165,11 +165,7 @@ bool DriverSystemShutdown(const bool vbAppExitOk) {
|
|||
//--
|
||||
int main(int argc, char const *argv[]) {
|
||||
#if MICONFIG_DEBUG_SHOW_ATTACH_DBG_DLG
|
||||
#ifdef _WIN32
|
||||
CMIUtilDebug::ShowDlgWaitForDbgAttach();
|
||||
#else
|
||||
CMIUtilDebug::WaitForDbgAttachInfinteLoop();
|
||||
#endif // _WIN32
|
||||
#endif // MICONFIG_DEBUG_SHOW_ATTACH_DBG_DLG
|
||||
|
||||
llvm::StringRef ToolName = argv[0];
|
||||
|
|
|
@ -37,25 +37,6 @@ CMIUtilDebug::CMIUtilDebug() {}
|
|||
//--
|
||||
CMIUtilDebug::~CMIUtilDebug() {}
|
||||
|
||||
//++
|
||||
//------------------------------------------------------------------------------------
|
||||
// Details: Show a dialog to the process/application halts. It gives the
|
||||
// opportunity to
|
||||
// attach a debugger.
|
||||
// Type: Static method.
|
||||
// Args: None.
|
||||
// Return: None.
|
||||
// Throws: None.
|
||||
//--
|
||||
void CMIUtilDebug::ShowDlgWaitForDbgAttach() {
|
||||
const CMIUtilString strCaption(CMIDriver::Instance().GetAppNameShort());
|
||||
#ifdef _WIN32
|
||||
::MessageBoxA(NULL, "Attach your debugger now", strCaption.c_str(), MB_OK);
|
||||
#else
|
||||
// ToDo: Implement other platform version of an Ok to continue dialog box
|
||||
#endif // _WIN32
|
||||
}
|
||||
|
||||
//++
|
||||
//------------------------------------------------------------------------------------
|
||||
// Details: Temporarily stall the process/application to give the programmer the
|
||||
|
|
|
@ -24,7 +24,6 @@ class CMICmnLog;
|
|||
class CMIUtilDebug {
|
||||
// Statics:
|
||||
public:
|
||||
static void ShowDlgWaitForDbgAttach();
|
||||
static void WaitForDbgAttachInfinteLoop();
|
||||
|
||||
// Methods:
|
||||
|
|
Loading…
Reference in New Issue