replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[libc++] Make sure that the symbol differ takes into account symbol types 

Summary:
Otherwise, it doesn't take into account things like whether the symbol
is defined or undefined, and whether symbols are indirect references
(re-exports) or not.

Reviewers: EricWF

Subscribers: christof, jkorous, dexonsmith, libcxx-commits

Tags: #libc

Differential Revision: https://reviews.llvm.org/D60416

llvm-svn: 358408
This commit is contained in:
Louis Dionne 2019-04-15 14:04:52 +00:00
parent c71433335a
commit f3e4f24ed7
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libcxx/utils/libcxx/sym_check/diff.py
View File

@ -14,10 +14,10 @@ from libcxx.sym_check import util
def _symbol_difference(lhs, rhs):
lhs_names = set((n['name'] for n in lhs))
rhs_names = set((n['name'] for n in rhs))
lhs_names = set(((n['name'], n['type']) for n in lhs))
rhs_names = set(((n['name'], n['type']) for n in rhs))
diff_names = lhs_names - rhs_names
return [n for n in lhs if n['name'] in diff_names]
return [n for n in lhs if (n['name'], n['type']) in diff_names]
def _find_by_key(sym_list, k):