replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

DebugInfo: Simplify logic in DIType::Verify(), NFC 

Clarify the logic in `DIType::Verify()` by checking `isBasicType()`
earlier, by skipping `else` after `return`s, and by documenting an
otherwise opaque check.

No functionality change.

llvm-svn: 232410
This commit is contained in:
Duncan P. N. Exon Smith 2015-03-16 20:46:27 +00:00
parent 01d73c9678
commit f37404033f
1 changed files with 20 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
llvm/lib/IR/DebugInfo.cpp
View File

@ -266,30 +266,32 @@ bool DIType::Verify() const {
if (!isScopeRef(N->getScope()))
return false;
// FIXME: Sink this into the various subclass verifies.
uint16_t Tag = getTag();
if (!isBasicType() && Tag != dwarf::DW_TAG_const_type &&
Tag != dwarf::DW_TAG_volatile_type && Tag != dwarf::DW_TAG_pointer_type &&
Tag != dwarf::DW_TAG_ptr_to_member_type &&
Tag != dwarf::DW_TAG_reference_type &&
Tag != dwarf::DW_TAG_rvalue_reference_type &&
Tag != dwarf::DW_TAG_restrict_type && Tag != dwarf::DW_TAG_array_type &&
Tag != dwarf::DW_TAG_enumeration_type &&
Tag != dwarf::DW_TAG_subroutine_type &&
Tag != dwarf::DW_TAG_inheritance && Tag != dwarf::DW_TAG_friend &&
getFilename().empty())
return false;
// DIType is abstract, it should be a BasicType, a DerivedType or
// a CompositeType.
if (isBasicType())
return DIBasicType(DbgNode).Verify();
else if (isCompositeType())
// FIXME: Sink this into the various subclass verifies.
if (getFilename().empty()) {
// Check whether the filename is allowed to be empty.
uint16_t Tag = getTag();
if (Tag != dwarf::DW_TAG_const_type && Tag != dwarf::DW_TAG_volatile_type &&
Tag != dwarf::DW_TAG_pointer_type &&
Tag != dwarf::DW_TAG_ptr_to_member_type &&
Tag != dwarf::DW_TAG_reference_type &&
Tag != dwarf::DW_TAG_rvalue_reference_type &&
Tag != dwarf::DW_TAG_restrict_type && Tag != dwarf::DW_TAG_array_type &&
Tag != dwarf::DW_TAG_enumeration_type &&
Tag != dwarf::DW_TAG_subroutine_type &&
Tag != dwarf::DW_TAG_inheritance && Tag != dwarf::DW_TAG_friend)
return false;
}
if (isCompositeType())
return DICompositeType(DbgNode).Verify();
else if (isDerivedType())
if (isDerivedType())
return DIDerivedType(DbgNode).Verify();
else
return false;
return false;
}
bool DIBasicType::Verify() const { return getRaw(); }