replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

[ORC] Remove an incorrect use of 'cantFail'. 

This code was moved out from BasicObjectLayerMaterializationUnit, which required
the supplied object to be well formed. The getObjectSymbolFlags function does
not require a well-formed object, so we have to propagate the error here.

llvm-svn: 338975
This commit is contained in:
Lang Hames 2018-08-05 23:55:35 +00:00
parent c0514f00bf
commit efd72d6a85
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
llvm/lib/ExecutionEngine/Orc/Layer.cpp
View File

@ -116,8 +116,10 @@ Expected<SymbolFlagsMap> getObjectSymbolFlags(ExecutionSession &ES,
for (auto &Sym : (*Obj)->symbols()) {
if (!(Sym.getFlags() & object::BasicSymbolRef::SF_Undefined) &&
(Sym.getFlags() & object::BasicSymbolRef::SF_Exported)) {
auto InternedName =
ES.getSymbolStringPool().intern(cantFail(Sym.getName()));
auto Name = Sym.getName();
if (!Name)
return Name.takeError();
auto InternedName = ES.getSymbolStringPool().intern(*Name);
auto SymFlags = JITSymbolFlags::fromObjectSymbol(Sym);
if (!SymFlags)
return SymFlags.takeError();