From ef986e8fc34ef5fa66a4e1ed29990ca15545a257 Mon Sep 17 00:00:00 2001 From: Douglas Gregor Date: Thu, 12 Nov 2009 15:31:47 +0000 Subject: [PATCH] Improve source-location information for implicitly-generated member call expressions llvm-svn: 86989 --- clang/include/clang/AST/ExprCXX.h | 2 ++ clang/lib/AST/ExprCXX.cpp | 8 ++++++++ clang/lib/Sema/SemaExprCXX.cpp | 2 +- 3 files changed, 11 insertions(+), 1 deletion(-) diff --git a/clang/include/clang/AST/ExprCXX.h b/clang/include/clang/AST/ExprCXX.h index 5931a3fcf984..9e6fd4fd065b 100644 --- a/clang/include/clang/AST/ExprCXX.h +++ b/clang/include/clang/AST/ExprCXX.h @@ -95,6 +95,8 @@ public: /// operation would return "x". Expr *getImplicitObjectArgument(); + virtual SourceRange getSourceRange() const; + static bool classof(const Stmt *T) { return T->getStmtClass() == CXXMemberCallExprClass; } diff --git a/clang/lib/AST/ExprCXX.cpp b/clang/lib/AST/ExprCXX.cpp index 7c6fc41ef12b..0ba4608ee198 100644 --- a/clang/lib/AST/ExprCXX.cpp +++ b/clang/lib/AST/ExprCXX.cpp @@ -323,6 +323,14 @@ Expr *CXXMemberCallExpr::getImplicitObjectArgument() { return 0; } +SourceRange CXXMemberCallExpr::getSourceRange() const { + SourceLocation LocStart = getCallee()->getLocStart(); + if (LocStart.isInvalid() && getNumArgs() > 0) + LocStart = getArg(0)->getLocStart(); + return SourceRange(LocStart, getRParenLoc()); +} + + //===----------------------------------------------------------------------===// // Named casts //===----------------------------------------------------------------------===// diff --git a/clang/lib/Sema/SemaExprCXX.cpp b/clang/lib/Sema/SemaExprCXX.cpp index 94550e6f1920..964334b20bb0 100644 --- a/clang/lib/Sema/SemaExprCXX.cpp +++ b/clang/lib/Sema/SemaExprCXX.cpp @@ -2120,7 +2120,7 @@ CXXMemberCallExpr *Sema::BuildCXXMemberCallExpr(Expr *Exp, CXXMemberCallExpr *CE = new (Context) CXXMemberCallExpr(Context, ME, 0, 0, ResultType, - SourceLocation()); + Exp->getLocEnd()); return CE; }