diff --git a/clang/include/clang/Basic/DiagnosticParseKinds.td b/clang/include/clang/Basic/DiagnosticParseKinds.td index 86078027dfc1..0b067842feb4 100644 --- a/clang/include/clang/Basic/DiagnosticParseKinds.td +++ b/clang/include/clang/Basic/DiagnosticParseKinds.td @@ -527,8 +527,8 @@ def warn_cxx98_compat_attribute : Warning< InGroup, DefaultIgnore; def err_cxx11_attribute_forbids_arguments : Error< "attribute %0 cannot have an argument list">; -def err_attribute_requires_arguements : Error< - "attribute %0 requires a nonempty argument list">; +def err_attribute_requires_arguments : Error< + "parentheses must be omitted if %0 attribute's argument list is empty">; def err_cxx11_attribute_forbids_ellipsis : Error< "attribute '%0' cannot be used as an attribute pack">; def err_cxx11_attribute_repeated : Error< diff --git a/clang/lib/Parse/ParseDecl.cpp b/clang/lib/Parse/ParseDecl.cpp index 3fa3031ad06f..07e606c98640 100644 --- a/clang/lib/Parse/ParseDecl.cpp +++ b/clang/lib/Parse/ParseDecl.cpp @@ -517,7 +517,7 @@ bool Parser::ParseMicrosoftDeclSpecArgs(IdentifierInfo *AttrName, // arguments but none were provided, emit a diagnostic. const AttributeList *Attr = Attrs.getList(); if (Attr && Attr->getMaxArgs() && !NumArgs) { - Diag(OpenParenLoc, diag::err_attribute_requires_arguements) << AttrName; + Diag(OpenParenLoc, diag::err_attribute_requires_arguments) << AttrName; return false; } return true; diff --git a/clang/lib/Parse/ParseDeclCXX.cpp b/clang/lib/Parse/ParseDeclCXX.cpp index 94d46eff1df9..be2349985e52 100644 --- a/clang/lib/Parse/ParseDeclCXX.cpp +++ b/clang/lib/Parse/ParseDeclCXX.cpp @@ -3254,12 +3254,12 @@ bool Parser::ParseCXX11AttributeArgs(IdentifierInfo *AttrName, // parsing an argument list, we need to determine whether this attribute // was allowed to have an argument list (such as [[deprecated]]), and how // many arguments were parsed (so we can diagnose on [[deprecated()]]). - if (Attr->getMaxArgs() && !NumArgs) { - // The attribute was allowed to have arguments, but none were provided - // even though the attribute parsed successfully. This is an error. - Diag(LParenLoc, diag::err_attribute_requires_arguements) << AttrName; + if (!NumArgs) { + // Diagnose an empty argument list when parenthesis are present. + // FIXME: This is a good place for a fixit which removes the parens. + Diag(LParenLoc, diag::err_attribute_requires_arguments) << AttrName; return false; - } else if (!Attr->getMaxArgs()) { + } else if (NumArgs && !Attr->getMaxArgs()) { // The attribute parsed successfully, but was not allowed to have any // arguments. It doesn't matter whether any were provided -- the // presence of the argument list (even if empty) is diagnosed. diff --git a/clang/test/Parser/MicrosoftExtensions.c b/clang/test/Parser/MicrosoftExtensions.c index 1998703e3d93..badd2049f5c0 100644 --- a/clang/test/Parser/MicrosoftExtensions.c +++ b/clang/test/Parser/MicrosoftExtensions.c @@ -104,7 +104,7 @@ struct __declspec("testing") S3 {}; /* expected-warning {{__declspec attribute ' /* declspecs with arguments cannot have an empty argument list, even if the arguments are optional. */ -__declspec(deprecated()) void dep_func_test(void); /* expected-error {{attribute 'deprecated' requires a nonempty argument list}} */ +__declspec(deprecated()) void dep_func_test(void); /* expected-error {{parentheses must be omitted if 'deprecated' attribute's argument list is empty}} */ __declspec(deprecated) void dep_func_test2(void); __declspec(deprecated("")) void dep_func_test3(void); diff --git a/clang/test/Parser/cxx0x-attributes.cpp b/clang/test/Parser/cxx0x-attributes.cpp index 777a40a4e8ab..f8abc76fb2f3 100644 --- a/clang/test/Parser/cxx0x-attributes.cpp +++ b/clang/test/Parser/cxx0x-attributes.cpp @@ -326,6 +326,6 @@ namespace GccASan { namespace { [[deprecated]] void bar(); [[deprecated("hello")]] void baz(); - [[deprecated()]] void foo(); // expected-error {{attribute 'deprecated' requires a nonempty argument list}} + [[deprecated()]] void foo(); // expected-error {{parentheses must be omitted if 'deprecated' attribute's argument list is empty}} [[gnu::deprecated()]] void quux(); }