replica
/
hanchenye-llvm-project
2
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Use open+fstat instead of stat+open. 

llvm-svn: 186381
This commit is contained in:
Rafael Espindola 2013-07-16 03:34:31 +00:00
parent 8c1ee47fb0
commit eed7690155
1 changed files with 13 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
llvm/tools/llvm-ar/llvm-ar.cpp
View File

@ -555,13 +555,23 @@ static void performWriteOperation(ArchiveOperation Operation,
printWithSpacePadding(Out, Name, 16);
if (I->isNewMember()) {
// FIXME: we do a stat + open. We should do a open + fstat.
const char *FileName = I->getNew();
int OpenFlags = O_RDONLY;
#ifdef O_BINARY
OpenFlags |= O_BINARY;
#endif
int FD = ::open(FileName, OpenFlags);
if (FD == -1)
return failIfError(error_code(errno, posix_category()), FileName);
sys::fs::file_status Status;
failIfError(sys::fs::status(FileName, Status), FileName);
failIfError(sys::fs::status(FD, Status), FileName);
OwningPtr<MemoryBuffer> File;
failIfError(MemoryBuffer::getFile(FileName, File), FileName);
failIfError(
MemoryBuffer::getOpenFile(FD, FileName, File, Status.getSize()),
FileName);
uint64_t secondsSinceEpoch =
Status.getLastModificationTime().toEpochTime();